Skip to content

Commit 4f8e301

Browse files
committed
PB-170: TinyMCE Performance is very poor with multiple instances on Stage
- Add test coverage for double clicking before TinyMCE is init
1 parent eb5830d commit 4f8e301

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -702,6 +702,13 @@
702702
<comment userInput="Verify variable on stage" stepKey="commentVerifyImageOnStage"/>
703703
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
704704
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEVariableBaseURL.editPanelValue)}}" stepKey="waitForVariabBaseURLleStage2"/>
705+
<!--Verify ability to double click on variable prior to focusing TinyMCE-->
706+
<doubleClick selector="{{TextOnStage.directive('1', TinyMCEVariableBaseURL.editPanelValue)}}" stepKey="doubleClickOnVariablePlaceholder2"/>
707+
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear2"/>
708+
<waitForElementVisible selector="{{VariableSection.Radio(TinyMCEVariableBaseURL.variableName)}}" stepKey="waitForVariableAfterDoubleClick"/>
709+
<waitForElementVisible selector="{{VariableSection.CancelBtnEnabled}}" stepKey="waitForCancelButton"/>
710+
<click selector="{{VariableSection.CancelBtnEnabled}}" stepKey="clickCancelButton"/>
711+
<waitForElementNotVisible selector="{{VariableSection.CancelBtnEnabled}}" stepKey="waitForVariableCancelNotVisible"/>
705712
<!-- Validate Storefront -->
706713
<comment userInput="Verify variable on storefront" stepKey="commentVerifyEmptyBlock"/>
707714
<amOnPage url="$$createCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
@@ -716,7 +723,7 @@
716723
<severity value="MAJOR"/>
717724
<useCaseId value="MC-1416"/>
718725
<testCaseId value="MC-3468"/>
719-
<group value="pagebuilder"/>
726+
<!-- <group value="pagebuilder"/>-->
720727
<group value="pagebuilder-text"/>
721728
</annotations>
722729
<before>
@@ -747,7 +754,7 @@
747754
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="waitForWidgetStage1"/>
748755
<!--Verify widget edit page-->
749756
<comment userInput="Verify widget edit page" stepKey="commentVerifyEditWidget"/>
750-
<doubleClick selector="{{TextOnStage.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="doubleClickOnWidgetPlaceholder"/>
757+
<doubleClick selector="{{TextOnStage.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="doubleClickOnWidgetPlaceholder"/>
751758
<waitForPageLoad stepKey="waitForPageLoad"/>
752759
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear"/>
753760
<waitForElementVisible selector="{{WidgetSection.CancelBtnEnabled}}" stepKey="waitForWidgetType"/>
@@ -769,6 +776,13 @@
769776
<comment userInput="Verify Widget Content Type on stage" stepKey="commentVerifyWidgetOnStage"/>
770777
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
771778
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="waitForWidgetStage2"/>
779+
<!--Verify ability to double click on variable prior to focusing TinyMCE-->
780+
<doubleClick selector="{{TextOnStage.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="doubleClickOnWidgetPlaceholder2"/>
781+
<waitForPageLoad stepKey="waitForPageLoad2"/>
782+
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear6"/>
783+
<waitForElementVisible selector="{{WidgetSection.CancelBtnEnabled}}" stepKey="waitForWidgetType2"/>
784+
<click selector="{{WidgetSection.CancelBtnEnabled}}" stepKey="clickInsertWidget3"/>
785+
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear7"/>
772786
<!-- Validate Storefront -->
773787
<comment userInput="Verify Widget Content Type on storefront" stepKey="commentVerifyWidgetOnStorefront"/>
774788
<amOnPage url="$$createCMSPageA.identifier$$" stepKey="amOnPageTestPage"/>

0 commit comments

Comments
 (0)