Skip to content

Commit 53b41ef

Browse files
committed
ACP2E-3122: refactored fix to cover all scenarios to add image
1 parent 2a32832 commit 53b41ef

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/file-uploader.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ define([
1515
* {@inheritDoc}
1616
*/
1717
replaceInputTypeFile: function (fileInput) {
18-
let fileId = fileInput.id, fileName = fileInput.name,
19-
spanElement = '<span id=\'' + fileId + '\'></span>';
18+
let fileId = fileInput.id, fileName = fileInput.name, fileClass = fileInput.className,
19+
spanElement = '<span id=\'' + fileId + fileClass + '\' ></span>';
2020

2121
$('#' + fileId).closest('.file-uploader-area').attr('upload-area-id', fileName);
2222
$(fileInput).replaceWith(spanElement);
2323
$('#' + fileId).closest('.file-uploader-area').find('.file-uploader-button:first').on('click', function () {
24-
$('#' + fileId).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
24+
$(this).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
2525
});
26-
$('#' + fileId).closest('.pagebuilder-image-uploader-container').find('.action-upload-image').on('click', function () {
27-
$('#' + fileId).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
26+
$('#' + fileId + fileClass).closest('.file-uploader-area').find('.action-upload-image').on('click', function () {
27+
$(this).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
2828
});
2929
},
3030
});

app/code/Magento/PageBuilder/view/adminhtml/web/template/form/element/uploader/preview/image.html

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,20 @@
99
<div class="pagebuilder-options-wrapper">
1010
<ul class="pagebuilder-options-links">
1111
<li class="pagebuilder-options-link">
12-
<label
13-
data-bind="event: {mousedown: stopEvent}"
14-
class="file-uploader-button action-default action-upload-image"
15-
attr="for: uid"
16-
disable="disabled"
17-
translate="translations.uploadNewImage"></label>
12+
<span class="file-uploader-area" if="visibleControls">
13+
<input
14+
type="file"
15+
afterRender="onElementRender"
16+
attr="id: uid, name: inputName, multiple: isMultipleFiles"
17+
class="file-upload-options-link"
18+
disable="disabled"></input>
19+
<label
20+
data-bind="event: {mousedown: stopEvent}"
21+
class="file-uploader-button action-default action-upload-image"
22+
attr="for: uid"
23+
disable="disabled"
24+
translate="translations.uploadNewImage"></label>
25+
</span>
1826
</li>
1927
<li class="pagebuilder-options-link">
2028
<label
@@ -33,18 +41,12 @@
3341
<div class="pagebuilder-image-uploader-container-dropzone-overlay" if="visibleControls">
3442
<span class="dropzone-placeholder-text" translate="translations.dropHere"></span>
3543
</div>
36-
<div class="file-uploader-area" if="visibleControls">
37-
<input
38-
type="file"
39-
afterRender="onElementRender"
40-
attr="id: uid, name: inputName, multiple: isMultipleFiles"
41-
disable="disabled"></input>
42-
</div>
4344
<div class="pagebuilder-image-empty-preview" data-bind="visible: !hasData() && isShowImageUploadInstructions">
4445
<div class="admin__field-control">
4546
<div class="file-uploader image-uploader">
46-
<div class="image-uploader-area" if="visibleControls">
47+
<div class="file-uploader-area" if="visibleControls">
4748
<p class="image-upload-instructions" translate="translations.dragImageHere"></p>
49+
<input type="file" class="file-upload-empty-preview" afterRender="onElementRender" attr="id: uid, name: inputName, multiple: isMultipleFiles" disable="disabled"/>
4850
<label class="file-uploader-button action-default action-upload-image" attr="for: uid" disable="disabled" translate="translations.uploadImage"></label>
4951
<span translate="translations.or"></span>
5052
<label

0 commit comments

Comments
 (0)