Skip to content

Commit 57d5a30

Browse files
committed
#557: User access Row action panel with 2+ level nesting - Mftf tests fixes
1 parent c424e0b commit 57d5a30

7 files changed

+22
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeRowActionGroup/ValidateFullWidthRowAppearanceActionGroup.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@
1717
<argument name="childContentTypeIndex" defaultValue="1" type="string"/>
1818
<argument name="padding" defaultValue="PageBuilderPaddingPropertyRowDefault"/>
1919
<argument name="acceptableOffset" defaultValue="2" type="string"/>
20+
<argument name="affordanceValue" defaultValue="0" type="string"/>
2021
</arguments>
2122
<comment userInput="Increase window size to see varying widths for rows" stepKey="commentResizeWindow"/>
2223
<resizeWindow width="1920" height="1024" stepKey="resizeWindow"/>
23-
<executeJS function="return {{pageOrStageWidthJS}}" stepKey="pageOrStageWidth"/>
24+
<executeJS function="return {{pageOrStageWidthJS}} - {{affordanceValue}}" stepKey="pageOrStageWidth"/>
2425
<executeJS function="return {{section.rowWidthJS(rowIndex)}}" stepKey="rowWidth"/>
2526
<executeJS function="return parseInt({{section.rowChildContentWidthJS(rowIndex, childContentType.role, childContentTypeIndex)}} + {{padding.paddingLeft}} + {{padding.paddingRight}} + ({{childContentTypeBorder.value}}*2))" stepKey="rowChildElementWidth"/>
2627
<executeJS function="return Math.abs({$pageOrStageWidth} - {$rowWidth})" stepKey="pageMinusRowWidth"/>

app/code/Magento/PageBuilder/Test/Mftf/Data/RowData.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
<entity name="PageBuilderRowDefaultHeight" type="pagebuilder_row">
1111
<data key="value">300</data>
1212
</entity>
13+
<entity name="PageBuilderRowAffordanceWidth" type="pagebuilder_row">
14+
<data key="value">30</data>
15+
</entity>
1316
<!-- Appearance -->
1417
<entity name="PageBuilderRowAppearance_Contained" type="pagebuilder_row_background_appearance_property">
1518
<data key="name">Appearance</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderColumnDragAndDropMultipleColumnsResizingThroughBlockContentTypeTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
<actualResult type="variable">columnRatio3CMSBlockStage</actualResult>
8585
</assertEquals>
8686
<executeJS function="return Math.round({$columnOneWidthCMSBlockStage}+{$columnTwoWidthCMSBlockStage}+{$columnThreeWidthCMSBlockStage}+{$columnFourWidthCMSBlockStage})" stepKey="totalColumnWidthCMSBlockStage"/>
87-
<executeJS function="return Math.round({{RowOnStage.rowWidthJS('1')}}-{{PageBuilderPaddingPropertyRowDefault.paddingLeft}}-{{PageBuilderPaddingPropertyRowDefault.paddingRight}})" stepKey="rowWidthCMSBlockStage"/>
87+
<executeJS function="return Math.round({{RowOnStage.rowWidthJS('1')}}-{{PageBuilderPaddingPropertyRowDefault.paddingLeft}}-{{PageBuilderPaddingPropertyRowDefault.paddingRight}}-{{PageBuilderRowAffordanceWidth.value}})" stepKey="rowWidthCMSBlockStage"/>
8888
<executeJS function="return Math.abs({$totalColumnWidthCMSBlockStage}-{$rowWidthCMSBlockStage})" stepKey="widthDifferenceCMSBlockStage"/>
8989
<assertLessThanOrEqual stepKey="assertWidthOfAllColumnsCMSBlockStage">
9090
<expectedResult type="int">2</expectedResult>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowFullBleedAppearanceThroughBlockContentTypeTest.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
</actionGroup>
3030
<comment userInput="---merging to remove step---" stepKey="enterParallaxBackgroundSpeed"/>
3131
<!-- Validate CMS Block Stage -->
32-
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSBlockStage"/>
32+
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSBlockStage">
33+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
34+
</actionGroup>
3335
<actionGroup ref="validateBackgroundAttributes" stepKey="validateBackgroundCMSBlockStage">
3436
<argument name="section" value="RowOnStage"/>
3537
<argument name="index" value="1"/>
@@ -49,6 +51,7 @@
4951
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSPageStage">
5052
<argument name="section" value="RowOnStorefront"/>
5153
<argument name="rowIndex" value="2"/>
54+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
5255
</actionGroup>
5356
<actionGroup ref="validateBackgroundAttributesWithNoImage" stepKey="validateRowBackgroundCMSPageStage">
5457
<argument name="section" value="RowOnStorefront_FullWidth_FullBleed"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowFullBleedAppearanceWithParallaxThroughBlockContentTypeTest.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,14 @@
2626
<argument name="property" value="PageBuilderRowAppearance_FullBleed"/>
2727
</actionGroup>
2828
<!-- Validate CMS Block Stage -->
29-
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSBlockStage"/>
29+
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSBlockStage">
30+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
31+
</actionGroup>
3032
<!-- Validate CMS Page Stage -->
3133
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSPageStage">
3234
<argument name="section" value="RowOnStorefront"/>
3335
<argument name="rowIndex" value="2"/>
36+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
3437
</actionGroup>
3538
<actionGroup ref="validateRowBackgroundAttributesWithAllUpdatedAndParallaxEnabled" stepKey="validateRowBackgroundCMSPageStage">
3639
<argument name="page" value="RowOnStorefront_FullWidth_FullBleed"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowFullWidthAppearanceThroughBlockContentTypeTest.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
</actionGroup>
3030
<comment userInput="---merging to remove step---" stepKey="enterParallaxBackgroundSpeed"/>
3131
<!-- Validate CMS Block Stage -->
32-
<actionGroup ref="validateFullWidthRowAppearance" stepKey="validateRowAppearanceCMSBlockStage"/>
32+
<actionGroup ref="validateFullWidthRowAppearance" stepKey="validateRowAppearanceCMSBlockStage">
33+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
34+
</actionGroup>
3335
<actionGroup ref="validateBackgroundAttributes" stepKey="validateBackgroundCMSBlockStage">
3436
<argument name="section" value="RowOnStage"/>
3537
<argument name="index" value="1"/>
@@ -55,6 +57,7 @@
5557
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSPageStage">
5658
<argument name="section" value="RowOnStorefront"/>
5759
<argument name="rowIndex" value="2"/>
60+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
5861
</actionGroup>
5962
<actionGroup ref="validateBackgroundAttributesWithNoImage" stepKey="validateRowBackgroundCMSPageStage">
6063
<argument name="section" value="RowOnStorefront_FullWidth_FullBleed"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderRowFullWidthAppearanceWithParallaxThroughBlockContentTypeTest.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,14 @@
2626
<argument name="property" value="PageBuilderRowAppearance_FullWidth"/>
2727
</actionGroup>
2828
<!-- Validate CMS Block Stage -->
29-
<actionGroup ref="validateFullWidthRowAppearance" stepKey="validateRowAppearanceCMSBlockStage"/>
29+
<actionGroup ref="validateFullWidthRowAppearance" stepKey="validateRowAppearanceCMSBlockStage">
30+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
31+
</actionGroup>
3032
<!-- Validate CMS Page Stage -->
3133
<actionGroup ref="validateFullBleedRowAppearance" stepKey="validateRowAppearanceCMSPageStage">
3234
<argument name="section" value="RowOnStorefront"/>
3335
<argument name="rowIndex" value="2"/>
36+
<argument name="affordanceValue" value="{{PageBuilderRowAffordanceWidth.value}}"/>
3437
</actionGroup>
3538
<actionGroup ref="validateRowBackgroundAttributesWithAllUpdatedAndParallaxEnabled" stepKey="validateRowBackgroundCMSPageStage">
3639
<argument name="page" value="RowOnStorefront_FullWidth_FullBleed"/>

0 commit comments

Comments
 (0)