Skip to content

Commit 590c553

Browse files
committed
MC-3803: Update MFTF tests for Row
- Add background image check - Remove unused data entries
1 parent 9dc3f37 commit 590c553

File tree

2 files changed

+8
-49
lines changed

2 files changed

+8
-49
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/RowData.xml

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,6 @@
5959
<data key="section">background</data>
6060
<data key="fieldName">background_image</data>
6161
</entity>
62-
<entity name="PageBuilderRowBackgroundImage_MagentoJpg" type="pagebuilder_row_background_image_property">
63-
<data key="name">Background Image</data>
64-
<data key="section">background</data>
65-
<data key="fieldName">background_image</data>
66-
<data key="value">magento.jpg</data>
67-
<data key="fileName">magento</data>
68-
<data key="extension">jpg</data>
69-
<data key="path">wysiwyg/magento</data>
70-
<data key="url">/(\b(https?|ftp|file):\/\/)[-A-Za-z0-9+&amp;@#/%?=~_|!:,.;]+[-A-Za-z0-9+&amp;@#/%=~_|]/g</data>
71-
</entity>
7262
<!-- Background Position -->
7363
<entity name="PageBuilderRowBackgroundPosition_Default" type="pagebuilder_row_background_position_property">
7464
<data key="name">Background Position</data>
@@ -77,39 +67,13 @@
7767
<data key="value">Top Aligned</data>
7868
<data key="styleValue">left top</data>
7969
</entity>
80-
<entity name="PageBuilderRowBackgroundPosition_TopAligned" type="pagebuilder_row_background_position_property">
81-
<data key="name">Background Position</data>
82-
<data key="section">background</data>
83-
<data key="fieldName">background_position</data>
84-
<data key="value">Top Aligned</data>
85-
<data key="styleValue">left top</data>
86-
</entity>
87-
<entity name="PageBuilderRowBackgroundPosition_Centered" type="pagebuilder_row_background_position_property">
88-
<data key="name">Background Position</data>
89-
<data key="section">background</data>
90-
<data key="fieldName">background_position</data>
91-
<data key="value">Centered</data>
92-
<data key="styleValue">center center</data>
93-
</entity>
9470
<!-- Background Size -->
9571
<entity name="PageBuilderRowBackgroundSize_Default" type="pagebuilder_row_background_size_property">
9672
<data key="name">Background Size</data>
9773
<data key="section">background</data>
9874
<data key="fieldName">background_size</data>
9975
<data key="value">cover</data>
10076
</entity>
101-
<entity name="PageBuilderRowBackgroundSize_Cover" type="pagebuilder_row_background_size_property">
102-
<data key="name">Background Size</data>
103-
<data key="section">background</data>
104-
<data key="fieldName">background_size</data>
105-
<data key="value">cover</data>
106-
</entity>
107-
<entity name="PageBuilderRowBackgroundSize_Contain" type="pagebuilder_row_background_size_property">
108-
<data key="name">Background Size</data>
109-
<data key="section">background</data>
110-
<data key="fieldName">background_size</data>
111-
<data key="value">contain</data>
112-
</entity>
11377
<!-- Background Repeat -->
11478
<entity name="PageBuilderRowBackgroundRepeat_Default" type="pagebuilder_row_background_repeat_property">
11579
<data key="name">Background Repeat</data>
@@ -118,26 +82,13 @@
11882
<data key="value">0</data>
11983
<data key="styleValue">no-repeat</data>
12084
</entity>
121-
<entity name="PageBuilderRowBackgroundRepeat_Enabled" type="pagebuilder_row_background_repeat_property">
122-
<data key="name">Background Repeat</data>
123-
<data key="section">background</data>
124-
<data key="fieldName">background_repeat</data>
125-
<data key="value">1</data>
126-
<data key="styleValue">repeat</data>
127-
</entity>
12885
<!-- Background Attachment -->
12986
<entity name="PageBuilderRowBackgroundAttachment_Default" type="pagebuilder_row_background_attachment_property">
13087
<data key="name">Background Attachment</data>
13188
<data key="section">background</data>
13289
<data key="fieldName">background_attachment</data>
13390
<data key="value">scroll</data>
13491
</entity>
135-
<entity name="PageBuilderRowBackgroundAttachment_Fixed" type="pagebuilder_row_background_attachment_property">
136-
<data key="name">Background Attachment</data>
137-
<data key="section">background</data>
138-
<data key="fieldName">background_attachment</data>
139-
<data key="value">fixed</data>
140-
</entity>
14192
<!-- Parallax Enabled -->
14293
<entity name="PageBuilderRowParallax_Default" type="pagebuilder_row_parallax_property">
14394
<data key="name">Enable Parallax Background</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,10 @@
189189
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
190190
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Scroll"/>
191191
</actionGroup>
192+
<actionGroup ref="validateBackgroundImage" stepKey="validateImageOnStage1">
193+
<argument name="section" value="RowOnStage"/>
194+
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
195+
</actionGroup>
192196
<!-- Validate on stage after save -->
193197
<comment userInput="Validate on stage after save" stepKey="commentValidateOnStage"/>
194198
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
@@ -202,6 +206,10 @@
202206
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
203207
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Scroll"/>
204208
</actionGroup>
209+
<actionGroup ref="validateBackgroundImage" stepKey="validateImageOnStage2">
210+
<argument name="section" value="RowOnStage"/>
211+
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
212+
</actionGroup>
205213
<!-- Validate edit form after save -->
206214
<comment userInput="Validate edit form after save" stepKey="commentValidateEditForm"/>
207215
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterSave">

0 commit comments

Comments
 (0)