Skip to content

Commit 6219d02

Browse files
anthoulaanthoula
committed
MC-3723: Advanced properties saving when invalid value is specified
- add test to check for invalid border-radius values
1 parent 1e929fa commit 6219d02

File tree

2 files changed

+103
-1
lines changed

2 files changed

+103
-1
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/AdvancedData.xml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,11 +269,26 @@
269269
<data key="fieldName">border_radius</data>
270270
<data key="value">500</data>
271271
</entity>
272-
<entity name="PageBuilderAdvancedBorderRadiusPropertyInvalid" type="pagebuilder_advanced_border_radius_property">
272+
<entity name="PageBuilderAdvancedBorderRadiusProperty_NonNumeric" type="pagebuilder_advanced_border_radius_property">
273273
<data key="name">Border Radius</data>
274274
<data key="section">advanced</data>
275275
<data key="fieldName">border_radius</data>
276276
<data key="value">garbage</data>
277+
<data key="errorMessage">Please enter a valid number in this field.</data>
278+
</entity>
279+
<entity name="PageBuilderAdvancedBorderRadiusProperty_Negative" type="pagebuilder_advanced_border_radius_property">
280+
<data key="name">Border Radius</data>
281+
<data key="section">advanced</data>
282+
<data key="fieldName">border_radius</data>
283+
<data key="value">-1</data>
284+
<data key="errorMessage">Please enter a value greater than or equal to 0.</data>
285+
</entity>
286+
<entity name="PageBuilderAdvancedBorderRadiusProperty_51" type="pagebuilder_advanced_border_radius_property">
287+
<data key="name">Border Radius</data>
288+
<data key="section">advanced</data>
289+
<data key="fieldName">border_radius</data>
290+
<data key="value">51</data>
291+
<data key="errorMessage">Please enter a value less than or equal to 50.</data>
277292
</entity>
278293
<!-- CSS Classes -->
279294
<entity name="PageBuilderAdvancedCssClassesDefaultProperty" type="pagebuilder_advanced_css_classes_property">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1370,6 +1370,93 @@
13701370
<argument name="index" value="1"/>
13711371
</actionGroup>
13721372
</test>
1373+
<test name="AdvancedConfigurationInvalidBorderRadius">
1374+
<annotations>
1375+
<features value="PageBuilder"/>
1376+
<stories value="Advanced Configuration"/>
1377+
<title value="Functional - Invalid Border Radius"/>
1378+
<description value="A user cannot add an invalid value for border radius"/>
1379+
<severity value="CRITICAL"/>
1380+
<useCaseId value="MAGETWO-83415"/>
1381+
<testCaseId value="MC-4185"/>
1382+
<group value="pagebuilder"/>
1383+
<group value="pagebuilder-advancedConfig"/>
1384+
</annotations>
1385+
<before>
1386+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1387+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1388+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1389+
</before>
1390+
<after>
1391+
<actionGroup ref="logout" stepKey="logout"/>
1392+
</after>
1393+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1394+
<argument name="contentType" value="PageBuilderTextContentType"/>
1395+
</actionGroup>
1396+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1397+
<argument name="group" value="PageBuilderTextContentType"/>
1398+
</actionGroup>
1399+
<!-- Add Text to Stage -->
1400+
<comment userInput="Add Text to Stage" stepKey="commentAddTextToStage"/>
1401+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage">
1402+
<argument name="contentType" value="PageBuilderTextContentType"/>
1403+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1404+
<argument name="containerTargetIndex" value="1"/>
1405+
<argument name="contentTypeIndex" value="1"/>
1406+
</actionGroup>
1407+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
1408+
<!-- Add Invalid Border Radius: NonNumeric -->
1409+
<comment userInput="Add Border Radius: NonNumeric" stepKey="commentAddBorderRadiusNonNumeric"/>
1410+
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage">
1411+
<argument name="contentType" value="PageBuilderTextContentType"/>
1412+
<argument name="contentTypeIndex" value="1"/>
1413+
</actionGroup>
1414+
<actionGroup ref="addTextToTinyMCE" stepKey="enterText">
1415+
<argument name="property" value="PageBuilderTextProperty"/>
1416+
</actionGroup>
1417+
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enterNonNumericBorderRadius">
1418+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_NonNumeric"/>
1419+
</actionGroup>
1420+
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateErrorNonNumeric">
1421+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_NonNumeric"/>
1422+
</actionGroup>
1423+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderRadiusNonNumeric">
1424+
<argument name="property" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
1425+
</actionGroup>
1426+
<!-- Add Invalid Border Radius: Negative -->
1427+
<comment userInput="Add Border Radius: Negative" stepKey="commentAddBorderRadiusNegative"/>
1428+
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enterNegativeBorderRadius">
1429+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_Negative"/>
1430+
</actionGroup>
1431+
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateErrorNegative">
1432+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_Negative"/>
1433+
</actionGroup>
1434+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderRadiusNegative">
1435+
<argument name="property" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
1436+
</actionGroup>
1437+
<!-- Add Invalid Border Radius: 51 -->
1438+
<comment userInput="Add Border Radius: 51" stepKey="commentAddBorderRadius51"/>
1439+
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enter51BorderRadius">
1440+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_51"/>
1441+
</actionGroup>
1442+
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateError51">
1443+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_51"/>
1444+
</actionGroup>
1445+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderRadius51">
1446+
<argument name="property" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
1447+
</actionGroup>
1448+
<!-- User can recover after invalid input -->
1449+
<comment userInput="User can recover after invalid input" stepKey="commentCanRecover"/>
1450+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderRadius12">
1451+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty12"/>
1452+
</actionGroup>
1453+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1454+
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage12">
1455+
<argument name="page" value="TextOnStage"/>
1456+
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty12"/>
1457+
<argument name="index" value="1"/>
1458+
</actionGroup>
1459+
</test>
13731460
<test name="AdvancedConfigurationFunctionalBorderRadius">
13741461
<annotations>
13751462
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)