MAGETWO-91923 static test failures

Michael Yu · Michael Yu · commit 65c9997bf20b · 2018-05-20T11:28:23.000-05:00
- Fixed more less file static test failures
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_config.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_config.less
@@ -3,12 +3,12 @@
 //  * See COPYING.txt for license details.
 //  */
 
-@black: #000;
+@color-black: #000;
 
 [data-role='modal'] {
     .action-pagebuilder-cancel,
     .action-pagebuilder-cancel:hover {
-        color: @black;
+        color: @color-black;
     }
 
     .pagebuilder-modal-content-body li {
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_page-builder.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_page-builder.less
@@ -4,7 +4,8 @@
 //  */
 
 @border-size: 2px;
-@white: #fff;
+@color-white: #fff;
+@color-black: #000;
 
 .pagebuilder-header {
     text-align: right;
@@ -21,7 +22,7 @@
 
 .pagebuilder-stage-wrapper {
     &.stage-full-screen {
-        background: @white;
+        background: @color-white;
         height: 100%;
         left: 0;
         overflow: scroll;
@@ -43,7 +44,7 @@
         -webkit-border-radius: 5px;
         background: @row-color;
         border-radius: 5px;
-        color: @white;
+        color: @color-white;
         display: inline-block;
         font-size: 26px;
         height: 50px;
@@ -69,7 +70,7 @@
     user-select: none;
 
     &.stage-full-screen {
-        background: @black;
+        background: @color-black;
     }
 
     &.pagebuilder-no-user-select {
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/_preview.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/_preview.less
@@ -3,11 +3,12 @@
 //  * See COPYING.txt for license details.
 //  */
 
-@white: #fff;
+@color-white: #fff;
 @f8f8f8: #f8f8f8;
 @eee: #eee;
 @dark-gray: #534d49;
-@light_gray: #f8f3eb;
+@light-gray: #f8f3eb;
+@darker-gray: #2b2625;
 
 .pagebuilder-content-type {
     [contenteditable=true] {
@@ -97,7 +98,7 @@
 
         &.pagebuilder-abstract {
             background: @entityColor;
-            color: @white;
+            color: @color-white;
             text-align: center;
 
             i {
@@ -110,7 +111,7 @@
             }
 
             * {
-                color: @white;
+                color: @color-white;
             }
         }
 
@@ -395,7 +396,7 @@
     }
 
     .pagebuilder-options-wrapper {
-        background: @white;
+        background: @color-white;
         border: 1px solid rgba(153, 153, 153, .7);
         box-shadow: 0 2px 6px rgba(0, 0, 0, .3);
         display: flex;
@@ -420,7 +421,7 @@
         }
 
         .pagebuilder-options-links {
-            background: @white;
+            background: @color-white;
             display: flex;
             list-style: none;
             margin: 0;
@@ -437,7 +438,7 @@
                         cursor: not-allowed;
 
                         &:hover {
-                            background-color: #fff;
+                            background-color: @color-white;
                             color: @color-dark-gray;
                         }
                     }
@@ -479,7 +480,7 @@
                     }
 
                     &:hover:not(&.option-title) {
-                        background-color: #eee;
+                        background-color: @eee;
                         color: @color-very-dark-gray-black;
                     }
                 }
@@ -516,7 +517,7 @@
 
         .pagebuilder-options-wrapper {
             &:after {
-                background: @white;
+                background: @color-white;
                 border: 1px solid rgba(153, 153, 153, .7);
                 bottom: -6px;
                 content: '';
@@ -574,11 +575,11 @@
 .pagebuilder-live-edit-wrapper {
     -moz-border-radius: 3px;
     -webkit-border-radius: 3px;
-    background: #2b2625;
+    background: @darker-gray;
     border: none;
     border-radius: 3px;
     box-shadow: 0 1px 2px rgba(0, 0, 0, .25);
-    color: #f8f3eb;
+    color: @light-gray;
     display: none;
     left: 10px !important;
     overflow: hidden;
@@ -613,7 +614,7 @@
                     display: inline-block;
 
                     a {
-                        color: @white;
+                        color: @color-white;
                         display: block;
                         font-size: 13px;
                         line-height: 42px;
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/column/_default.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/column/_default.less
@@ -26,7 +26,7 @@
     }
 
     .pagebuilder-column-resize-handle {
-        background: #bfe2f0;
+        background: @light-blue;
         bottom: 0;
         cursor: col-resize;
         opacity: 0;
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slider/_default.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slider/_default.less
@@ -3,13 +3,13 @@
 //  * See COPYING.txt for license details.
 //  */
 
-@gray: #aaa6a0;
-@white: #fff;
-@yellow: #fffbbb;
+@color-gray: #aaa6a0;
+@color-white: #fff;
+@color-yellow: #fffbbb;
 @light-gray: #afadac;
 @c-gray: #ccc;
 @dark-gray: #373330;
-@blue: #007bdb;
+@color-blue: #007bdb;
 @b3: #b3b3b3;
 @darker-gray: #1c1918;
 
@@ -54,7 +54,7 @@
 
     .slider-empty {
         align-items: flex-end;
-        color: @gray;
+        color: @color-gray;
         display: flex;
         font-size: 20px;
         font-weight: lighter;
@@ -91,7 +91,7 @@
                 );
 
                 .tooltip-content {
-                    background: @yellow;
+                    background: @color-yellow;
                     border: 1px solid @light-gray;
                     border-radius: 1px;
                     bottom: 97.5%;
@@ -123,7 +123,7 @@
                         z-index: 3;
                     }
                     &:after {
-                        border-top-color: @yellow;
+                        border-top-color: @color-yellow;
                         z-index: 4;
                     }
                 }
@@ -142,7 +142,7 @@
                     }
 
                     &:after {
-                        background: @white;
+                        background: @color-white;
                         border: 1px solid @c-gray;
                         border-radius: 10px;
                         content: ' ';
@@ -212,7 +212,7 @@
                 }
 
                 &:focus {
-                    outline: 1px solid @blue;
+                    outline: 1px solid @color-blue;
 
                     .pagebuilder-options {
                         .pagebuilder-options-visible;
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/tabs/_default.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/tabs/_default.less
@@ -5,8 +5,8 @@
 
 @f6: #f6f6f6;
 @ccc: #ccc;
-@black: #000;
-@white: #fff;
+@color-black: #000;
+@color-white: #fff;
 
 //
 //  Default appearance styles
@@ -36,7 +36,7 @@
 
             a.tab-title {
                 border-right: 0;
-                color: @black;
+                color: @color-black;
                 cursor: pointer !important;
                 display: block;
                 font-size: 14px;
@@ -78,16 +78,15 @@
                         .abs-icon;
                         color: @color-dark-gray0;
                         content: @icon-gripper__content;
+                        cursor: move; /* fallback if grab cursor is unsupported */
+                        cursor: grab;
+                        cursor: -moz-grab;
+                        cursor: -webkit-grab;
                         display: block;
                         font-size: 16px;
                         position: absolute;
                         top: 50%;
                         transform: translateY(-50%);
-
-                        cursor: move; /* fallback if grab cursor is unsupported */
-                        cursor: grab;
-                        cursor: -moz-grab;
-                        cursor: -webkit-grab;
                     }
 
                     &:active:before {
@@ -119,7 +118,7 @@
             }
 
             &.ui-state-active {
-                background: @white;
+                background: @color-white;
                 z-index: 19;
 
                 a.tab-title {
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/text/_default.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/text/_default.less
@@ -3,7 +3,7 @@
 //  * See COPYING.txt for license details.
 //  */
 
-@black: #000;
+@color-black: #000;
 @light-gray: #f8f3eb;
 @dark-gray: #534d49;
 @darker-gray: #2b2625;
@@ -19,7 +19,7 @@
             padding-bottom: 0;
             padding-top: 0;
             .redactor-color-picker {
-                background: @black;
+                background: @color-black;
                 border: 2px solid @light-gray;
                 border-radius: 10px;
                 float: left;
diff --git a/app/code/Magento/PageBuilder/view/base/web/css/source/hljs/hljs.less b/app/code/Magento/PageBuilder/view/base/web/css/source/hljs/hljs.less
@@ -8,7 +8,7 @@
 @light-red: #ff79c6;
 @light-gray: #f8f8f2;
 @light-green: #50fa7b;
-@yellow: #f1fa8c;
+@color-yellow: #f1fa8c;
 @dark-purple: #6272a4;
 @light-purple: #bd93f9;
 
@@ -50,7 +50,7 @@
 .hljs-variable,
 .hljs-template-tag,
 .hljs-template-variable {
-    color: @yellow;
+    color: @color-yellow;
 }
 
 .hljs-comment,
diff --git a/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/accordion/_default.less b/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/accordion/_default.less
@@ -3,15 +3,15 @@
 //  * See COPYING.txt for license details.
 //  */
 
-@gray: #ccc;
+@color-gray: #ccc;
 
 //
 //  Default appearance styles
 //  _____________________________________________
 
 .pagebuilder-accordion {
     .accordion-collapsible {
-        border-bottom: 1px solid @gray;
+        border-bottom: 1px solid @color-gray;
         cursor: pointer;
         font-weight: bold;
         padding: 14px 8px;
diff --git a/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/tabs/_default.less b/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/tabs/_default.less
@@ -5,8 +5,8 @@
 
 @f6: #f6f6f6;
 @ccc: #ccc;
-@black: #000;
-@white: #fff;
+@color-black: #000;
+@color-white: #fff;
 
 //
 //  Default appearance styles
@@ -40,7 +40,7 @@ div[data-role='tabs'] {
 
             a.tab-title {
                 border-right: 0;
-                color: @black;
+                color: @color-black;
                 cursor: pointer !important;
                 display: block;
                 font-size: 14px;
@@ -65,7 +65,7 @@ div[data-role='tabs'] {
             }
 
             &.ui-state-active {
-                background: @white;
+                background: @color-white;
                 z-index: 19;
 
                 a.tab-title {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`.pagebuilder-column-resize-handle {`
`29`		`- background: #bfe2f0;`
	`29`	`+ background: @light-blue;`
`30`	`30`	`bottom: 0;`
`31`	`31`	`cursor: col-resize;`
`32`	`32`	`opacity: 0;`