Skip to content

Commit 666e5c6

Browse files
committed
MAGETWO-87898: Stabilize tests
1 parent bcfed05 commit 666e5c6

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Banner/Test/AdminPageBuilderEnabledTest.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
<annotations>
1515
<features value="Pagebuilder"/>
1616
<stories value="MAGETWO-71404: Enabling PageBuilder on Webstore"/>
17-
<title value="Admin are able to see PageBuilder on Dynmic Block after enable PageBuilder from Configuration"/>
18-
<description value="Admin are able to see PageBuilder on Dynmic Block after enable PageBuilder from Configuration"/>
17+
<title value="Admin are able to see PageBuilder on Dynamic Block after enable PageBuilder from Configuration"/>
18+
<description value="Admin are able to see PageBuilder on Dynamic Block after enable PageBuilder from Configuration"/>
1919
<severity value="CRITICAL"/>
2020
<group value="pagebuilder"/>
2121
<group value="pagebuilder-ee"/>
@@ -78,5 +78,10 @@
7878
</actionGroup>
7979
<seeElement selector="{{TinyMCESection.TinyMCE4}}" stepKey="seeTinyMCE4Visible" />
8080
<!--Missing step of asserting PageBuilder text convert to TinyMCE4 (blocked by current testing framework - unable to grab text from TinyMCE4)-->
81+
<executeJS function="var div = document.createElement('div'); div.innerHTML = tinymce.activeEditor.getContent(); div.innerText.trim();" stepKey="textFromPageBuilder"/>
82+
<assertEquals stepKey="assertEquals1" message="pass">
83+
<expectedResult type="string">Hello Dynamic Block from PageBuilder</expectedResult>
84+
<actualResult type="variable">textFromPageBuilder</actualResult>
85+
</assertEquals>
8186
</test>
8287
</tests>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Staging/Test/AdminPageBuilderEnabledTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
<annotations>
5050
<features value="Pagebuilder"/>
5151
<stories value="MAGETWO-71404: Enabling PageBuilder on Webstore"/>
52-
<title value="Admin are able to see PageBuilder on CMS Page, Block Page, Dynmic Block after enable PageBuilder from Configuration"/>
53-
<description value="Admin are able to see PageBuilder on CMS Page, Block Page, Dynmic Block after enable PageBuilder from Configuration"/>
52+
<title value="Admin are able to see PageBuilder on CMS Page, Block Page, Dynamic Block after enable PageBuilder from Configuration"/>
53+
<description value="Admin are able to see PageBuilder on CMS Page, Block Page, Dynamic Block after enable PageBuilder from Configuration"/>
5454
<severity value="CRITICAL"/>
5555
<group value="pagebuilder"/>
5656
<group value="pagebuilder-ee"/>
@@ -81,7 +81,7 @@
8181
<actionGroup ref="navigateToCreatedCMSBlockPage" stepKey="navigateToContentCreatedBlock">
8282
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
8383
</actionGroup>
84-
<actionGroup ref="verifyPageBuilderVisibleOnPage" stepKey="verifyPageBuilderVisibleOnBlockPage"/>
84+
<actionGroup ref="verifyPageBuilderVisibleOnPage" stepKey="verifyPageBuilderVisibleOnBlockBlockPage"/>
8585
<!--Verify PageBuilder visible on staging slideout of CMS Block-->
8686
<scrollTo selector="div.pagebuilder-header" x="0" y="-100" stepKey="scrollToTop2"/>
8787
<actionGroup ref="navigateToStagingSlideout" stepKey="navigateToStagingSlideoutBlock"/>
@@ -94,6 +94,6 @@
9494
<!--Verify PageBuilder visible on Dynamic Block creation form -->
9595
<amOnPage url="{{AdminBannerPage.url}}" stepKey="openNewBannerForm"/>
9696
<waitForPageLoad stepKey="waitForPageLoad5"/>
97-
<actionGroup ref="verifyPageBuilderVisibleOnPage" stepKey="verifyBluefootVisibleOnBlockPage"/>
97+
<actionGroup ref="verifyPageBuilderVisibleOnPage" stepKey="verifyPageBuilderVisibleOnDynamicBlockPage"/>
9898
</test>
9999
</tests>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Staging/Test/UploadImageToCategoryOnStaging.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<waitForText userInput="Category Image" stepKey="waitForText" />
3939
<seeElement selector="{{CategoryContentSection.SelectFromGalleryBtn}}" stepKey="seeSelectFromGallery" />
4040
<see userInput="Maximum file size" stepKey="seeMediaGalleryValidationMsg"/>
41-
<see userInput="Browse to find or drag image here" stepKey="seeBrowseImageonPlaceHolder1"/>
41+
<see userInput="Browse to find or drag image here" stepKey="seeBrowseImageOnPlaceHolder1"/>
4242
<seeElement selector="{{CategoryContentSection.ImagePlaceHolder}}" stepKey="seeImagePlaceHolder"/>
4343
<!--Upload image from local machine using image placeholder button-->
4444
<comment userInput="Upload image from local machine using image placeholder button" stepKey="uploadImageComment"/>
@@ -49,7 +49,7 @@
4949
<!--Remove uploaded image-->
5050
<waitForElementVisible selector="{{ImageOnConfigurationPanel.trashBinIcon}}" stepKey="waitForDeleteIconAppear"/>
5151
<click selector="{{ImageOnConfigurationPanel.trashBinIcon}}" stepKey="removeUploadedImage"/>
52-
<see userInput="Browse to find or drag image here" stepKey="seeBrowseImageonPlaceHolder2"/>
52+
<see userInput="Browse to find or drag image here" stepKey="seeBrowseImageOnPlaceHolder2"/>
5353
<!--Upload another image from local machine using image placeholder button-->
5454
<comment userInput="Upload another image from local machine using image placeholder button" stepKey="uploadImageComment2"/>
5555
<attachFile selector="{{CategoryContentSection.Upload}}" userInput="{{ImageUpload.value}}" stepKey="uploadImage2"/>
@@ -68,7 +68,7 @@
6868
<argument name="Image" value="ImageUpload1"/>
6969
</actionGroup>
7070
<actionGroup ref="saveImage" stepKey="saveImage"/>
71-
<seeElement selector="{{ImageOnConfigurationPanel.imageName(ImageUpload1.fileName)}}" stepKey="seeImgeNameOnPreview3"/>
71+
<seeElement selector="{{ImageOnConfigurationPanel.imageName(ImageUpload1.fileName)}}" stepKey="seeImageNameOnPreview3"/>
7272
<seeElement selector="{{ImageOnConfigurationPanel.imageSource(ImageUpload1.fileName)}}" stepKey="seeMainImageSource3"/>
7373
<seeElement selector="{{ImageOnConfigurationPanel.trashBinIcon}}" stepKey="seeTrashBinBtn"/>
7474
<fillField selector="{{AdminStagingSlideOutSection.updateName}}" userInput="{{_staging.update_name}}" stepKey="fillUpdateName" />

0 commit comments

Comments
 (0)