Skip to content

Commit 6d40f6f

Browse files
MC-3735: Allow inline WYSIWYG editing of slides
- Introduce events and delegate mechanism - Fix slider width on Column resize - Fix image upload buttons size - Fix width of poster overlay
1 parent d166c7d commit 6d40f6f

File tree

14 files changed

+217
-47
lines changed

14 files changed

+217
-47
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideCommonTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1946,8 +1946,7 @@
19461946
<description value="Verify that user are able to add text into Slide Content Type and see it on storefront"/>
19471947
<severity value="MAJOR"/>
19481948
<useCaseId value="MC-937"/>
1949-
<!-- TODO: Write test -->
1950-
<testCaseId value="MC-3465"/>
1949+
<testCaseId value="MC-3813"/>
19511950
<group value="pagebuilder"/>
19521951
<group value="pagebuilder-text"/>
19531952
</annotations>
@@ -2004,8 +2003,7 @@
20042003
<description value="Verify that user are able to add other content types on Stage when inline edit enabled in Slide Content Type"/>
20052004
<severity value="MAJOR"/>
20062005
<useCaseId value="MC-937"/>
2007-
<!-- TODO: Write test -->
2008-
<testCaseId value="MC-3465"/>
2006+
<testCaseId value="MC-3814"/>
20092007
<group value="pagebuilder"/>
20102008
<group value="pagebuilder-text"/>
20112009
</annotations>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_default.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
.pagebuilder-empty-slide {
1414
color: @color-gray65-lighten;
15-
font-size: 20px;
15+
font-size: 14px;
1616
font-weight: lighter;
1717
}
1818

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_poster.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
.wysiwyg-container {
2121
text-align: center;
22-
min-width: 50%;
22+
width: 100%;
2323
}
2424
}
2525
}

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/form/element/uploader/preview/_image.less

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
.file-uploader-button {
3737
margin-left: 15px;
3838
margin-right: 15px;
39-
width: 180px;
39+
width: 165px;
4040
}
4141

4242
.image-upload-instructions {
@@ -159,26 +159,21 @@
159159
.pagebuilder-options {
160160
top: 45px;
161161

162-
.file-uploader-button {
163-
margin-bottom: 3px;
164-
margin-top: 3px;
165-
166-
&:first-child {
167-
margin-left: 9px;
168-
}
169-
170-
&:not(:first-child) {
171-
margin-left: 15px;
172-
}
173-
162+
.pagebuilder-options-link {
174163
&:last-child {
175-
margin-right: 9px;
164+
.file-uploader-button {
165+
margin-left: 9px;
166+
}
176167
}
177168
}
169+
170+
.file-uploader-button {
171+
margin: 0;
172+
}
178173
}
179174

180175
.pagebuilder-options-wrapper {
181-
padding: 12px 6px;
176+
padding: 10px;
182177
}
183178
}
184179

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column/preview.js

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview-collection.js

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview.js

Lines changed: 66 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)