Skip to content

Commit 7ce399a

Browse files
committed
MC-5184: Missing validation message when uploading big image
Rename GetMaxFileSize to MaxFileSize
1 parent 3363d7d commit 7ce399a

File tree

6 files changed

+12
-6
lines changed

6 files changed

+12
-6
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
/**
1515
* Provides maximum file size for uploader
1616
*/
17-
class GetMaxFileSize implements ProviderInterface
17+
class MaxFileSize implements ProviderInterface
1818
{
1919
/**
2020
* @var Size

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/banner.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,9 @@
284284
<item name="uploaderConfig" xsi:type="array">
285285
<item name="isShowImageUploadInstructions" xsi:type="boolean">false</item>
286286
<item name="isShowImageUploadOptions" xsi:type="boolean">true</item>
287-
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\GetMaxFileSize</item>
287+
<item name="maxFileSize" xsi:type="object">
288+
Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\MaxFileSize
289+
</item>
288290
<item name="allowedExtensions" xsi:type="string">jpg jpeg gif png</item>
289291
<item name="component" xsi:type="string">Magento_PageBuilder/js/form/element/image-uploader</item>
290292
<item name="componentType" xsi:type="string">imageUploader</item>

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/image.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@
7878
</appearances>
7979
<additional_data>
8080
<item name="uploaderConfig" xsi:type="array">
81-
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\GetMaxFileSize</item>
81+
<item name="maxFileSize" xsi:type="object">
82+
Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\MaxFileSize
83+
</item>
8284
<item name="allowedExtensions" xsi:type="string">jpg jpeg gif png</item>
8385
<item name="component" xsi:type="string">Magento_PageBuilder/js/form/element/image-uploader</item>
8486
<item name="componentType" xsi:type="string">imageUploader</item>

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/slide.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,9 @@
284284
<item name="uploaderConfig" xsi:type="array">
285285
<item name="isShowImageUploadInstructions" xsi:type="boolean">false</item>
286286
<item name="isShowImageUploadOptions" xsi:type="boolean">true</item>
287-
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\GetMaxFileSize</item>
287+
<item name="maxFileSize" xsi:type="object">
288+
Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\MaxFileSize
289+
</item>
288290
<item name="allowedExtensions" xsi:type="string">jpg jpeg gif png</item>
289291
<item name="component" xsi:type="string">Magento_PageBuilder/js/form/element/image-uploader</item>
290292
<item name="componentType" xsi:type="string">imageUploader</item>

docs/configurations/additional-configurations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Use `additional_data` in your `Vendor/ModuleName/view/adminhtml/pagebuilder/cont
2525
``` xml
2626
<additional_data>
2727
<item name="uploaderConfig" xsi:type="array">
28-
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\GetMaxFileSize</item>
28+
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\MaxFileSize</item>
2929
<item name="allowedExtensions" xsi:type="string">jpg jpeg gif png</item>
3030
<item name="component" xsi:type="string">Magento_PageBuilder/js/form/element/image-uploader</item>
3131
<item name="componentType" xsi:type="string">imageUploader</item>

docs/how-to/how-to-use-image-uploader.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Use `additional_data` in your `<YourModule>/view/base/pagebuilder/content_type/<
2323
<item name="uploaderConfig" xsi:type="array">
2424
<item name="isShowImageUploadInstructions" xsi:type="boolean">false</item>
2525
<item name="isShowImageUploadOptions" xsi:type="boolean">true</item>
26-
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\GetMaxFileSize</item>
26+
<item name="maxFileSize" xsi:type="object">Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\MaxFileSize</item>
2727
<item name="allowedExtensions" xsi:type="string">jpg jpeg gif png</item>
2828
<item name="component" xsi:type="string">Magento_PageBuilder/js/form/element/image-uploader</item>
2929
<item name="componentType" xsi:type="string">imageUploader</item>

0 commit comments

Comments
 (0)