Skip to content

Commit 816163f

Browse files
author
Hwashiang Yu
committed
MC-3889: Adding spaces to Button/Heading text on stage results in   added to the text after save
- Updated test coverage after QA review
1 parent 283f33c commit 816163f

11 files changed

+29
-36
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@
940940
<annotations>
941941
<features value="PageBuilder"/>
942942
<stories value="Banner"/>
943-
<title value="Banner Collage Center - Update All Attributes"/>
943+
<title value="Collage Center - Update All Attributes"/>
944944
<description value="A user should be able to add a collage center banner with all attribute fields filled."/>
945945
<severity value="CRITICAL"/>
946946
<useCaseId value="MC-1433"/>
@@ -1286,7 +1286,7 @@
12861286
<annotations>
12871287
<features value="PageBuilder"/>
12881288
<stories value="Banner"/>
1289-
<title value="Banner Collage Center - HTML Value In Buttons Does Not Render As HTML"/>
1289+
<title value="Collage Center - HTML Value In Buttons Does Not Render As HTML"/>
12901290
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12911291
<severity value="MAJOR"/>
12921292
<useCaseId value="MC-849"/>
@@ -1355,11 +1355,11 @@
13551355
<annotations>
13561356
<features value="PageBuilder"/>
13571357
<stories value="Banner"/>
1358-
<title value="Banner Collage Center - Non Breaking Space In Button Does Not Render as nbsp;"/>
1358+
<title value="Collage Center - Non Breaking Space In Button Does Not Render as nbsp;"/>
13591359
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
13601360
<severity value="MAJOR"/>
13611361
<useCaseId value="MC-3889"/>
1362-
<testCaseId value="MC-3654"/>
1362+
<testCaseId value="MC-4196"/>
13631363
<group value="pagebuilder"/>
13641364
<group value="pagebuilder-banner"/>
13651365
<group value="pagebuilder-bannerCollageCenter"/>
@@ -1387,7 +1387,7 @@
13871387
<!-- Fill Out Edit Panel -->
13881388
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
13891389
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
1390-
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
1390+
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
13911391
</actionGroup>
13921392
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButtonAlwaysProperty">
13931393
<argument name="property" value="PageBuilderBannerShowButtonAlwaysProperty"/>
@@ -1396,7 +1396,7 @@
13961396
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
13971397
<!-- Validate Stage -->
13981398
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1399-
<seeElementInDOM selector="{{BannerOnBackend.editableButtonOnStage('1')}}" stepKey="seeButtonIsEditable"/>
1399+
<waitForElementVisible selector="{{BannerOnBackend.editableButtonOnStage('1')}}" stepKey="waitForButtonIsEditable"/>
14001400
<click selector="{{BannerOnBackend.editableButtonOnStage('1')}}" stepKey="clickButtonToEdit"/>
14011401
<pressKey selector="{{BannerOnBackend.editableButtonOnStage('1')}}" userInput="{{PageBuilderBannerButtonTextProperty_Non_Breaking_Space.value}}" stepKey="enterButtonText"/>
14021402
<see selector="{{BannerOnBackend.editableButtonOnStage('1')}}" userInput="{{PageBuilderBannerButtonTextProperty_Non_Breaking_Space.value}}" stepKey="seeStageNBSPBannerButtonText"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@
940940
<annotations>
941941
<features value="PageBuilder"/>
942942
<stories value="Banner"/>
943-
<title value="Banner Collage Left - Update All Attributes"/>
943+
<title value="Collage Left - Update All Attributes"/>
944944
<description value="A user should be able to add a collage left banner with all attribute fields filled."/>
945945
<severity value="CRITICAL"/>
946946
<useCaseId value="MC-1433"/>
@@ -1286,7 +1286,7 @@
12861286
<annotations>
12871287
<features value="PageBuilder"/>
12881288
<stories value="Banner"/>
1289-
<title value="Banner Collage Left - HTML Value In Buttons Does Not Render As HTML"/>
1289+
<title value="Collage Left - HTML Value In Buttons Does Not Render As HTML"/>
12901290
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12911291
<severity value="MAJOR"/>
12921292
<useCaseId value="MC-849"/>
@@ -1303,11 +1303,11 @@
13031303
<annotations>
13041304
<features value="PageBuilder"/>
13051305
<stories value="Banner"/>
1306-
<title value="Banner Collage Left - Non Breaking Space In Button Does Not Render as nbsp;"/>
1306+
<title value="Collage Left - Non Breaking Space In Button Does Not Render as nbsp;"/>
13071307
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
13081308
<severity value="MAJOR"/>
13091309
<useCaseId value="MC-3889"/>
1310-
<testCaseId value="MC-3654"/>
1310+
<testCaseId value="MC-4197"/>
13111311
<group value="pagebuilder"/>
13121312
<group value="pagebuilder-banner"/>
13131313
<group value="pagebuilder-bannerCollageLeft"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@
940940
<annotations>
941941
<features value="PageBuilder"/>
942942
<stories value="Banner"/>
943-
<title value="Banner Collage Right - Update All Attributes"/>
943+
<title value="Collage Right - Update All Attributes"/>
944944
<description value="A user should be able to add a collage right banner with all attribute fields filled."/>
945945
<severity value="CRITICAL"/>
946946
<useCaseId value="MC-1433"/>
@@ -1286,7 +1286,7 @@
12861286
<annotations>
12871287
<features value="PageBuilder"/>
12881288
<stories value="Banner"/>
1289-
<title value="Banner Collage Right - HTML Value In Buttons Does Not Render As HTML"/>
1289+
<title value="Collage Right - HTML Value In Buttons Does Not Render As HTML"/>
12901290
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12911291
<severity value="MAJOR"/>
12921292
<useCaseId value="MC-849"/>
@@ -1303,11 +1303,11 @@
13031303
<annotations>
13041304
<features value="PageBuilder"/>
13051305
<stories value="Banner"/>
1306-
<title value="Banner Collage Right - Non Breaking Space In Button Does Not Render as nbsp;"/>
1306+
<title value="Collage Right - Non Breaking Space In Button Does Not Render as nbsp;"/>
13071307
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
13081308
<severity value="MAJOR"/>
13091309
<useCaseId value="MC-3889"/>
1310-
<testCaseId value="MC-3654"/>
1310+
<testCaseId value="MC-4198"/>
13111311
<group value="pagebuilder"/>
13121312
<group value="pagebuilder-banner"/>
13131313
<group value="pagebuilder-bannerCollageRight"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1454,7 +1454,7 @@
14541454
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
14551455
<severity value="MAJOR"/>
14561456
<useCaseId value="MC-3889"/>
1457-
<testCaseId value="MC-3654"/>
1457+
<testCaseId value="MC-4199"/>
14581458
<group value="pagebuilder"/>
14591459
<group value="pagebuilder-banner"/>
14601460
<group value="pagebuilder-bannerPoster"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonItemTests.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,7 +1356,7 @@
13561356
<description value="Validate that non breaking space can be entered into the button and that the string literal is not in stage after save."/>
13571357
<severity value="MAJOR"/>
13581358
<useCaseId value="MC-3889"/>
1359-
<testCaseId value="MC-3658"/>
1359+
<testCaseId value="MC-4200"/>
13601360
<group value="pagebuilder"/>
13611361
<group value="pagebuilder-buttons"/>
13621362
<group value="pagebuilder-buttonItem"/>
@@ -1385,7 +1385,6 @@
13851385
<comment userInput="Edit button item text inline on stage" stepKey="commentEditButtonItem"/>
13861386
<pressKey selector="{{ButtonItemOnStage.editableButtonItemElement('1')}}" userInput="{{PageBuilderButtonItemText_NBSP.value}}" stepKey="enterNBSPButtonItemText"/>
13871387
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
1388-
<waitForPageLoad stepKey="waitForAnimationAlign1" time="30"/>
13891388
<!-- Stage: Check NBSP in button item -->
13901389
<comment userInput="Check NBSP in button item" stepKey="commentStageCheckNBSP"/>
13911390
<see selector="{{ButtonItemOnStage.base('1')}}" userInput="{{PageBuilderButtonItemText_NBSP.value}}" stepKey="seeStageNBSPButtonItemText"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingEditOnStageTest.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1556,9 +1556,9 @@
15561556
<stories value="Heading"/>
15571557
<title value="Stage Edit - Heading Non Breaking Space"/>
15581558
<description value="Add non breaking space on stage and view the rendered content type in stage and storefront."/>
1559-
<severity value="CRITICAL"/>
1559+
<severity value="MAJOR"/>
15601560
<useCaseId value="MC-3889"/>
1561-
<testCaseId value="MC-2566"/>
1561+
<testCaseId value="MC-4215"/>
15621562
<group value="pagebuilder"/>
15631563
<group value="pagebuilder-heading"/>
15641564
</annotations>
@@ -1585,10 +1585,6 @@
15851585
<!--Edit heading text inline on stage -->
15861586
<comment userInput="Edit heading text inline on stage" stepKey="commentEditHeading"/>
15871587
<pressKey selector="{{HeadingOnStage.headingEditableText('1')}}" userInput="{{PageBuilderHeadingNonBreakingSpaceProperty.value}}" stepKey="enterNBSPHeadingText"/>
1588-
<waitForPageLoad stepKey="waitForAnimationAlign1" time="30"/>
1589-
<actionGroup ref="clickOutsideLiveEditHeading" stepKey="clickOutsideLiveEditHeading">
1590-
<argument name="index" value="1"/>
1591-
</actionGroup>
15921588
<!-- Stage: Check NBSP in heading -->
15931589
<comment userInput="Check NBSP in heading" stepKey="commentStageCheckNBSP"/>
15941590
<see selector="{{HeadingOnStage.base('1')}}" userInput="{{PageBuilderHeadingNonBreakingSpaceProperty.value}}" stepKey="seeStageNBSPHeadingText"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,6 @@
548548
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
549549
<seeElement selector="{{SlideOnFrontend.buttonText('1', PageBuilderSlideItemButtonText_Html.value)}}" stepKey="seeButtonTextStorefront"/>
550550
</test>
551-
552551
<test name="SliderCollageCenterNonBreakingSpaceValueInButtons">
553552
<annotations>
554553
<features value="PageBuilder"/>
@@ -557,7 +556,7 @@
557556
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
558557
<severity value="MAJOR"/>
559558
<useCaseId value="MC-3889"/>
560-
<testCaseId value="MC-3659"/>
559+
<testCaseId value="MC-4202"/>
561560
<group value="pagebuilder"/>
562561
<group value="pagebuilder-slider"/>
563562
<group value="pagebuilder-sliderCollageCenter"/>
@@ -591,7 +590,7 @@
591590
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
592591
<!-- Validate Stage -->
593592
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
594-
<seeElementInDOM selector="{{SlideOnBackend.editableButtonItemElement('1')}}" stepKey="seeButtonIsEditable"/>
593+
<waitForElementVisible selector="{{SlideOnBackend.editableButtonItemElement('1')}}" stepKey="waitForButtonIsEditable"/>
595594
<click selector="{{SlideOnBackend.editableButtonItemElement('1')}}" stepKey="clickButtonToEdit"/>
596595
<pressKey selector="{{SlideOnBackend.editableButtonItemElement('1')}}" userInput="{{PageBuilderSlideItemButtonText_Non_Breaking_Space.value}}" stepKey="enterButtonText"/>
597596
<see selector="{{SlideOnBackend.editableButtonItemElement('1')}}" userInput="{{PageBuilderSlideItemButtonText_Non_Breaking_Space.value}}" stepKey="seeStageNBSPBannerButtonText"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,11 +384,11 @@
384384
<annotations>
385385
<features value="PageBuilder"/>
386386
<stories value="Slider"/>
387-
<title value="Slider Collage Left - Non Breaking Space In Button Does Not Render as nbsp;"/>
387+
<title value="Collage Left - Non Breaking Space In Button Does Not Render as nbsp;"/>
388388
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
389389
<severity value="MAJOR"/>
390390
<useCaseId value="MC-3889"/>
391-
<testCaseId value="MC-3654"/>
391+
<testCaseId value="MC-4203"/>
392392
<group value="pagebuilder"/>
393393
<group value="pagebuilder-slider"/>
394394
<group value="pagebuilder-sliderCollageLeft"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,11 +384,11 @@
384384
<annotations>
385385
<features value="PageBuilder"/>
386386
<stories value="Slider"/>
387-
<title value="Slider Collage Right - Non Breaking Space In Button Does Not Render as nbsp;"/>
387+
<title value="Collage Right - Non Breaking Space In Button Does Not Render as nbsp;"/>
388388
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
389389
<severity value="MAJOR"/>
390390
<useCaseId value="MC-3889"/>
391-
<testCaseId value="MC-3654"/>
391+
<testCaseId value="MC-4204"/>
392392
<group value="pagebuilder"/>
393393
<group value="pagebuilder-slider"/>
394394
<group value="pagebuilder-sliderCollageRight"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1219,7 +1219,7 @@
12191219
<description value="Validate that non breaking space can be entered into the button and that the html doesn't render on stage and storefront as nbsp."/>
12201220
<severity value="MAJOR"/>
12211221
<useCaseId value="MC-3889"/>
1222-
<testCaseId value="MC-3654"/>
1222+
<testCaseId value="MC-4205"/>
12231223
<group value="pagebuilder"/>
12241224
<group value="pagebuilder-slider"/>
12251225
<group value="pagebuilder-sliderPoster"/>

0 commit comments

Comments
 (0)