Skip to content

Commit 82a93e0

Browse files
author
joiecaquicla
committed
magento2/magento2-page-builder#636: Responsive breakpoint switcher - applied requested changes
1 parent a25b362 commit 82a93e0

File tree

23 files changed

+84
-128
lines changed

23 files changed

+84
-128
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderAddContentContentTypesTest/BlockRenderProductsThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,11 @@
143143
<actionGroup ref="clickProductAddToCartInProductsOnStorefront" stepKey="clickProductAddToCartInProductsCMSPageStorefront">
144144
<argument name="product" value="$$createProduct2.name$$"/>
145145
</actionGroup>
146-
<reloadPage stepKey="reloadPage1"/>
146+
<scrollTo selector="{{ProductsOnStorefront.productAddToCompareByProductName($$createProduct2.name$$)}}" stepKey="scrollToAddToCompare"/>
147147
<actionGroup ref="clickProductAddToCompareInProductsOnStorefront" stepKey="clickProductAddToCompareInProductsCMSPageStorefront">
148148
<argument name="product" value="$$createProduct2.name$$"/>
149149
</actionGroup>
150-
<reloadPage stepKey="reloadPage2"/>
150+
<scrollTo selector="{{ProductsOnStorefront.productAddToWishListByProductName($$createProduct2.name$$)}}" stepKey="scrollToAddToWishList"/>
151151
<actionGroup ref="clickProductAddToWishListInProductsOnStorefront" stepKey="clickProductAddToWishListInProductsCMSPageStorefront">
152152
<argument name="product" value="$$createProduct2.name$$"/>
153153
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherButtonsThroughBlockContentTypeStackedNotSameSizeTest.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Buttons Through Block Content Type: Stacked and Not Same Size"/>
15-
<description value="Verify that users are able to successfully render and use the Buttons content type (stacked and not same size) through the Block content type."/>
14+
<title value="Mobile Viewport: Render Buttons Through Block Content Type: Stacked and Not Same Size"/>
15+
<description value="Verify that users are able to successfully render and use the Buttons content type (stacked and not same size) through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>
@@ -34,6 +34,7 @@
3434
</actionGroup>
3535
</before>
3636
<after>
37+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
3738
<deleteData createDataKey="createCMSBlock" stepKey="deleteCMSBlock"/>
3839
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
3940
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerCollageCenteredAppearanceThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Banner Collage Centered Appearance Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render and use the banner content type collage centered appearance through the Block content type."/>
14+
<title value="Mobile Viewport: Render Banner Collage Centered Appearance Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render and use the banner content type collage centered appearance through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerCollageLeftAppearanceWithVideoBackgroundThroughBlockContentTypeTest.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Banner Collage Left Appearance with Video Background Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render the banner content type collage left appearance with a video background through the Block content type."/>
14+
<title value="Mobile Viewport: Render Banner Collage Left Appearance with Video Background Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render the banner content type collage left appearance with a video background through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>
@@ -37,6 +37,7 @@
3737
</actionGroup>
3838
</before>
3939
<after>
40+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
4041
<deleteData createDataKey="createCMSBlock" stepKey="deleteCMSBlock"/>
4142
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
4243
<actionGroup ref="NavigateToMediaGalleryActionGroup" stepKey="navigateToMediaGallery"/>
@@ -183,6 +184,10 @@
183184
<waitForElementVisible selector="{{BannerOnFrontend.buttonText('1', PageBuilderBannerButtonTextProperty.value)}}" stepKey="waitForButtonTextCMSPageStage"/>
184185

185186
<!-- Validate CMS Page Stage Desktop Viewport -->
187+
<actionGroup ref="AdminSwitchPageBuilderViewportActionGroup" stepKey="switchToDesktopViewportPage">
188+
<argument name="viewportButton" value="desktop"/>
189+
<argument name="viewportStage" value="desktop"/>
190+
</actionGroup>
186191
<actionGroup ref="validateVideoBackgroundWithAllAttributes" stepKey="validateCMSPageStageDesktop">
187192
<argument name="section" value="BannerOnFrontend"/>
188193
<argument name="backgroundColor" value="{{PageBuilderBackgroundColor_Pink.rgb}}"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerCollageRightAppearanceWithVideoBackgroundThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Banner Collage Right Appearance with Video Background Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render the banner content type collage right appearance with a video background through the Block content type."/>
14+
<title value="Mobile Viewport: Render Banner Collage Right Appearance with Video Background Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render the banner content type collage right appearance with a video background through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerPosterAppearanceThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Banner Poster Appearance Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render and use the banner content type poster appearance through the Block content type."/>
14+
<title value="Mobile Viewport: Render Banner Poster Appearance Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render and use the banner content type poster appearance through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBlockThroughBlockContentTypeTest.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Block Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render and use the block content type through the Block content type."/>
14+
<title value="Mobile Viewport: Render Block Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render and use the block content type through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>
@@ -34,6 +34,7 @@
3434
</actionGroup>
3535
</before>
3636
<after>
37+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
3738
<deleteData createDataKey="createPreReqBlock" stepKey="deletePreReqBlock"/>
3839
<deleteData createDataKey="createCMSBlock" stepKey="deleteCMSBlock"/>
3940
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileButtonsThroughBlockContentTypeInlineSameSizeTest.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Render Buttons Through Block Content Type: Inline and Same Size"/>
15-
<description value="Verify that users are able to successfully render and use the Buttons content type (inline and same size) through the Block content type."/>
14+
<title value="Mobile Viewport: Render Buttons Through Block Content Type: Inline and Same Size"/>
15+
<description value="Verify that users are able to successfully render and use the Buttons content type (inline and same size) through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>
@@ -34,6 +34,7 @@
3434
</actionGroup>
3535
</before>
3636
<after>
37+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
3738
<deleteData createDataKey="createCMSBlock" stepKey="deleteCMSBlock"/>
3839
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
3940
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileColumnBottomAlignmentAppearanceThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Viewport Switcher - Render Column Bottom Alignment Appearance Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render and use the column content type with bottom alignment appearance and all attributes through the Block content type."/>
14+
<title value="Mobile Viewport: Render Column Bottom Alignment Appearance Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render and use the column content type with bottom alignment appearance and all attributes through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileColumnCenterAlignmentAppearanceThroughBlockContentTypeTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Viewport Switcher"/>
14-
<title value="Viewport Switcher - Render Column Center Alignment Appearance Through Block Content Type"/>
15-
<description value="Verify that users are able to successfully render and use the column content type with center alignment appearance and all attributes through the Block content type."/>
14+
<title value="Mobile Viewport: Render Column Center Alignment Appearance Through Block Content Type"/>
15+
<description value="Verify that users are able to successfully render and use the column content type with center alignment appearance and all attributes through the Block content type in the mobile viewport."/>
1616
<severity value="CRITICAL"/>
1717
<group value="pagebuilder"/>
1818
<group value="pagebuilder-block"/>

0 commit comments

Comments
 (0)