Skip to content

Commit 85b5dbe

Browse files
author
Hwashiang Yu
committed
MC-4232: Button text draggable triggers the image drop zones
- Updated button-item and tabs template to prevent dragging
1 parent 743eb45 commit 85b5dbe

File tree

2 files changed

+3
-2
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type

2 files changed

+3
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/button-item/default/preview.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
<a attr="data.link.attributes"
1414
ko-style="data.link.style"
1515
css="data.link.css"
16-
click="function (context, event) { onClick($index(), event); }">
16+
click="function (context, event) { onClick($index(), event); }"
17+
event="{dragstart: function(context, event) { event.preventDefault(); }}">
1718
<span class="button-item-drag-handle" css="{disabled: parent.parent.children().length <= 1}"></span>
1819
<span attr="data.link_text.attributes"
1920
data-bind="liveEdit: { field: 'button_text', placeholder: buttonPlaceholder, selectAll: true }, hasFocusNoScroll: $parent.parent.preview.focusedButton() === $index()"

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/tabs/default/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
click="function (context, event) { parent.parent.preview.onTabClick($index(), event); }"
1818
ko-style="parent.parent.preview.getTabHeaderStyles()"
1919
event="{ focusin: function () { parent.parent.preview.setFocusedTab($index(), true) }, focusout: function () { window.getSelection().removeAllRanges(); parent.parent.preview.setFocusedTab(null); } }">
20-
<a href="#no-tab" class="tab-title focus-options" attr="{ href: '#' + parent.id }">
20+
<a href="#no-tab" class="tab-title focus-options" attr="{ href: '#' + parent.id }" event="{ dragstart: function(context, event) { event.preventDefault(); }}">
2121
<render args="getOptions().template" />
2222
<span class="tab-drag-handle" css="{disabled: parent.parent.children().length <= 1}"></span>
2323
<span class="tab-title tab-name" data-tab-title="true" data-bind="liveEdit: { field: 'tab_name', placeholder: $t('...'), selectAll: true }, hasFocusNoScroll: parent.parent.preview.focusedTab() === $index()"></span>

0 commit comments

Comments
 (0)