Skip to content

Commit 863478a

Browse files
committed
Merge from 559_no-predefined-gutters--map
2 parents 55afd84 + 3cd0749 commit 863478a

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapCommonComponentTest/MapValidateAdvancedConfigurationDefaultValuesTest.xml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
109
<test name="MapValidateAdvancedConfigurationDefaultValuesTest">
1110
<annotations>
1211
<features value="PageBuilder"/>
@@ -63,10 +62,12 @@
6362
<argument name="property" value="PageBuilderAdvancedCssClassesProperty_Empty"/>
6463
</actionGroup>
6564
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins">
66-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
65+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
66+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
6767
</actionGroup>
6868
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding">
69-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
69+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
70+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
7071
</actionGroup>
7172
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
7273
<!-- Validate Stage -->
@@ -110,10 +111,12 @@
110111
<argument name="property" value="PageBuilderAdvancedCssClassesProperty_Empty"/>
111112
</actionGroup>
112113
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins2">
113-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
114+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
115+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
114116
</actionGroup>
115117
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding2">
116-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
118+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
119+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
117120
</actionGroup>
118121
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
119122
<argument name="contentType" value="PageBuilderMapContentType"/>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_map_form.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,15 @@
3636
</item>
3737
</argument>
3838
</container>
39+
<fieldset name="advanced">
40+
<field name="margins_and_padding">
41+
<argument name="data" xsi:type="array">
42+
<item name="config" xsi:type="array">
43+
<item name="default" xsi:type="null" />
44+
</item>
45+
</argument>
46+
</field>
47+
</fieldset>
3948
<fieldset name="appearance_fieldset" sortOrder="20" component="Magento_PageBuilder/js/form/element/dependent-fieldset">
4049
<settings>
4150
<label translate="true">Appearance</label>

0 commit comments

Comments
 (0)