Skip to content

Commit 8a8634d

Browse files
author
Michael Yu
committed
MC-2208: Update events to new naming convention
- Updated sortableChildren event to camelcase
1 parent db5a1ed commit 8a8634d

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/binding/sortable-children.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/sortable-children.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ ko.bindingHandlers.sortableChildren = {
3232
.on("sortstart", (event: Event, ui: JQueryUI.SortableUIParams) => {
3333
originalPosition = ui.item.index();
3434
draggedContentType = instance.children()[originalPosition];
35-
events.trigger("sortableChildren:sortstart", {
35+
events.trigger("sortableChildren:sortStart", {
3636
instance,
3737
originalPosition,
3838
ui,
3939
});
4040
})
4141
.on("sortstop", (event: Event, ui: JQueryUI.SortableUIParams) => {
42-
events.trigger("sortableChildren:sortstop", {
42+
events.trigger("sortableChildren:sortStop", {
4343
instance,
4444
ui,
4545
});
@@ -55,7 +55,7 @@ ko.bindingHandlers.sortableChildren = {
5555
} else {
5656
moveContentType(draggedContentType, index, targetParent);
5757
}
58-
events.trigger("sortableChildren:sortupdate", {
58+
events.trigger("sortableChildren:sortUpdate", {
5959
instance,
6060
newPosition: index,
6161
originalPosition,

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ export default class Preview extends PreviewCollection {
257257
});
258258

259259
// Set the active slide to the new position of the sorted slide
260-
events.on("sortableChildren:sortupdate", (args: PreviewSortableSortUpdateEventParams) => {
260+
events.on("sortableChildren:sortUpdate", (args: PreviewSortableSortUpdateEventParams) => {
261261
if (args.instance.id === this.parent.id) {
262262
$(args.ui.item).remove(); // Remove the item as the container's children is controlled by knockout
263263
this.setActiveSlide(args.newPosition);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export default class Preview extends PreviewCollection {
8686
}
8787
});
8888
// Refresh tab contents and set the focus to the new position of the sorted tab
89-
events.on("sortableChildren:sortupdate", (args: PreviewSortableSortUpdateEventParams) => {
89+
events.on("sortableChildren:sortUpdate", (args: PreviewSortableSortUpdateEventParams) => {
9090
if (args.instance.id === this.parent.id) {
9191
this.refreshTabs(args.newPosition, true);
9292
/**

0 commit comments

Comments
 (0)