Skip to content

Commit 8acf886

Browse files
omiroshnichenkoomiroshnichenko
committed
PB-379: Full height Slider/Slide
- add tests
1 parent afd31ea commit 8acf886

5 files changed

+306
-7
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
<element name="infiniteLoop" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][@data-infinite-loop='{{arg2}}']" parameterized="true"/>
2424
<element name="showArrows" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][@data-show-arrows='{{arg2}}']" parameterized="true"/>
2525
<element name="showDots" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][@data-show-dots='{{arg2}}']" parameterized="true"/>
26-
<element name="minHeight" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
26+
<element name="minHeight" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][contains(@style,'min-height: {{arg2}}')]" parameterized="true"/>
27+
<element name="noMinHeight" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][not(contains(@style,'min-height:'))]" parameterized="true"/>
2728
<!-- Advanced Configuration -->
2829
<element name="alignment" type="text" selector="(//div[@data-content-type='slider'])[{{arg1}}][contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
2930
<element name="noAlignment" type="text" selector="(//div[@data-content-type='slider'])[{{arg1}}][not(contains(@style,'text-align:'))]" parameterized="true"/>
@@ -39,7 +40,7 @@
3940
<section name="SliderOnStage">
4041
<element name="all" type="button" selector="div[data-content-type=slider]"/>
4142
<element name="base" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}]" parameterized="true"/>
42-
<element name="containerCSS" type="text" selector="[data-content-type=slider] .slider-container"/>
43+
<element name="containerCSS" type="text" selector="[data-content-type=slider] > .slider-container"/>
4344
<element name="hidden" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
4445
<element name="notHidden" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
4546
<element name="slideNavigationDot" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}]//div[contains(@class,'navigation-dot')][{{arg2}}]" parameterized="true"/>
@@ -56,7 +57,8 @@
5657
<element name="infiniteLoop" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][@data-infinite-loop='{{arg2}}']" parameterized="true"/>
5758
<element name="showArrows" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][@data-show-arrows='{{arg2}}']" parameterized="true"/>
5859
<element name="showDots" type="button" selector="(//div[@data-content-type='slider'])[{{arg1}}][@data-show-dots='{{arg2}}']" parameterized="true"/>
59-
<element name="minHeight" type="button" selector="(//div[@data-content-type='slider']/div[contains(@class,'slider-container')])[{{arg1}}][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
60+
<element name="minHeight" type="button" selector="(//div[@data-content-type='slider']/div[contains(@class,'slider-container')])[{{arg1}}][contains(@style,'min-height: {{arg2}};')]" parameterized="true"/>
61+
<element name="noMinHeight" type="button" selector="(//div[@data-content-type='slider']/div[contains(@class,'slider-container')])[{{arg1}}][not(contains(@style,'min-height:'))]" parameterized="true"/>
6062
<!-- Advanced Configuration -->
6163
<element name="alignment" type="text" selector="(//div[@data-content-type='slider']/div[contains(@class,'slider-container')])[{{arg1}}][contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
6264
<element name="noAlignment" type="text" selector="(//div[@data-content-type='slider']/div[contains(@class,'slider-container')])[{{arg1}}][not(contains(@style,'text-align:'))]" parameterized="true"/>
@@ -83,7 +85,8 @@
8385
<!-- Appearance Configuration -->
8486
<element name="appearance" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
8587
<element name="slideName" type="button" selector="(//div[@data-content-type='slide'])[{{arg1}}][@data-slide-name='{{arg2}}']" parameterized="true"/>
86-
<element name="minimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@data-element='wrapper'][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
88+
<element name="minimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@data-element='wrapper'][contains(@style,'min-height: {{arg2}};')]" parameterized="true"/>
89+
<element name="noMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@data-element='wrapper'][not(contains(@style,'min-height:'))]" parameterized="true"/>
8790
<!-- Background Configuration -->
8891
<element name="backgroundColor" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@data-element='wrapper'][contains(@style,'background-color: {{arg2}};')]" parameterized="true"/>
8992
<element name="noBackgroundColor" type="button" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@data-element='wrapper'][not(contains(@style,'background-color:'))]" parameterized="true"/>
@@ -152,8 +155,10 @@
152155
<!-- Appearance Configuration -->
153156
<element name="appearance" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
154157
<element name="slideName" type="button" selector="(//div[@data-content-type='slide'])[{{arg1}}][@data-slide-name='{{arg2}}']" parameterized="true"/>
155-
<element name="posterMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@class='pagebuilder-slide-wrapper'][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
156-
<element name="collageMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]/div[contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
158+
<element name="posterMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@class='pagebuilder-slide-wrapper'][contains(@style,'min-height: {{arg2}};')]" parameterized="true"/>
159+
<element name="noPosterMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]//div[@class='pagebuilder-slide-wrapper'][not(contains(@style,'min-height:'))]" parameterized="true"/>
160+
<element name="collageMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]/div[contains(@style,'min-height: {{arg2}};')]" parameterized="true"/>
161+
<element name="noCollageMinimumHeight" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]/div[not(contains(@style,'min-height:'))]" parameterized="true"/>
157162
<!-- Background Configuration -->
158163
<element name="backgroundColor" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]/div[contains(@style,'background-color: {{arg2}};')]" parameterized="true"/>
159164
<element name="noBackgroundColor" type="text" selector="(//div[@data-content-type='slide'])[{{arg1}}]/div[not(contains(@style,'background-color:'))]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -699,4 +699,26 @@
699699
<executeJS function="return Math.abs(Math.round({$overlayRightPositionAfterSave}-{$buttonRightPositionAfterSave}-30))" stepKey="overlayMinusButtonMinusPaddingAfterSave"/>
700700
<executeJS function="return Math.abs(Math.round({$overlayRightPositionStoreFront}-{$buttonRightPositionStoreFront}-30))" stepKey="overlayMinusButtonMinusPaddingStoreFront"/>
701701
</test>
702+
<test name="SliderMinHeightWithCollageCenterSlideMinHeight" extends="SliderMinHeightWithSlideMinHeight">
703+
<annotations>
704+
<features value="PageBuilder"/>
705+
<stories value="Slider"/>
706+
<title value="Slider Min Height With Collage Center Slide Min Height"/>
707+
<description value="A user can submit an different valid min height values for slider and slide with collage center appearance"/>
708+
<severity value="CRITICAL"/>
709+
<useCaseId value="PB-379"/>
710+
<testCaseId value="MC-31543"/>
711+
<group value="pagebuilder"/>
712+
<group value="pagebuilder-slide"/>
713+
<group value="pagebuilder-slider"/>
714+
<group value="pagebuilder-sliderCollageCenter"/>
715+
</annotations>
716+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertySlider1" before="enterSlideMinHeight1">
717+
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
718+
</actionGroup>
719+
<waitForElementVisible selector="{{SlideOnBackend.noCollageMinimumHeight('1')}}" stepKey="seeFirstSlideHeightStage"/>
720+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('2', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeSecondSlideHeightStage"/>
721+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeThirdSlideHeightStage"/>
722+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('4', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeFourthSlideHeightStage"/>
723+
</test>
702724
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -576,4 +576,26 @@
576576
<executeJS function="return Math.abs(Math.round({$overlayRightPositionAfterSave}-{$buttonRightPositionAfterSave}-30))" stepKey="overlayMinusButtonMinusPaddingAfterSave"/>
577577
<executeJS function="return Math.abs(Math.round({$overlayRightPositionStoreFront}-{$buttonRightPositionStoreFront}-30))" stepKey="overlayMinusButtonMinusPaddingStoreFront"/>
578578
</test>
579+
<test name="SliderMinHeightWithCollageLeftSlideMinHeight" extends="SliderMinHeightWithSlideMinHeight">
580+
<annotations>
581+
<features value="PageBuilder"/>
582+
<stories value="Slider"/>
583+
<title value="Slider Min Height With Collage Left Slide Min Height"/>
584+
<description value="A user can submit an different valid min height values for slider and slide with collage left appearance"/>
585+
<severity value="CRITICAL"/>
586+
<useCaseId value="PB-379"/>
587+
<testCaseId value="MC-31542"/>
588+
<group value="pagebuilder"/>
589+
<group value="pagebuilder-slide"/>
590+
<group value="pagebuilder-slider"/>
591+
<group value="pagebuilder-sliderCollageLeft"/>
592+
</annotations>
593+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertySlider1" before="enterSlideMinHeight1">
594+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
595+
</actionGroup>
596+
<waitForElementVisible selector="{{SlideOnBackend.noCollageMinimumHeight('1')}}" stepKey="seeFirstSlideHeightStage"/>
597+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('2', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeSecondSlideHeightStage"/>
598+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeThirdSlideHeightStage"/>
599+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('4', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeFourthSlideHeightStage"/>
600+
</test>
579601
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -477,4 +477,26 @@
477477
<executeJS function="return Math.abs(Math.round({$overlayRightPositionAfterSave}-{$buttonRightPositionAfterSave}-30))" stepKey="overlayMinusButtonMinusPaddingAfterSave"/>
478478
<executeJS function="return Math.abs(Math.round({$overlayRightPositionStoreFront}-{$buttonRightPositionStoreFront}-30))" stepKey="overlayMinusButtonMinusPaddingStoreFront"/>
479479
</test>
480+
<test name="SliderMinHeightWithCollageRightSlideMinHeight" extends="SliderMinHeightWithSlideMinHeight">
481+
<annotations>
482+
<features value="PageBuilder"/>
483+
<stories value="Slider"/>
484+
<title value="Slider Min Height With Collage Right Slide Min Height"/>
485+
<description value="A user can submit an different valid min height values for slider and slide with collage right appearance"/>
486+
<severity value="CRITICAL"/>
487+
<useCaseId value="PB-379"/>
488+
<testCaseId value="MC-31541"/>
489+
<group value="pagebuilder"/>
490+
<group value="pagebuilder-slide"/>
491+
<group value="pagebuilder-slider"/>
492+
<group value="pagebuilder-sliderCollageRight"/>
493+
</annotations>
494+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearancePropertySlider1" before="enterSlideMinHeight1">
495+
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
496+
</actionGroup>
497+
<waitForElementVisible selector="{{SlideOnBackend.noCollageMinimumHeight('1')}}" stepKey="seeFirstSlideHeightStage"/>
498+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('2', PageBuilderMinHeightProperty_200px.value)}}" stepKey="seeSecondSlideHeightStage"/>
499+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('3', PageBuilderMinHeightProperty_100vh.value)}}" stepKey="seeThirdSlideHeightStage"/>
500+
<waitForElementVisible selector="{{SlideOnBackend.collageMinimumHeight('4', PageBuilderMinHeightProperty_100vh_Minus_200px.value)}}" stepKey="seeFourthSlideHeightStage"/>
501+
</test>
480502
</tests>

0 commit comments

Comments
 (0)