MAGETWO-91377: Create MFTF Tests

- addressing code review comments

Author: owlpelletz

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ActionGroup.xml

@@ -787,19 +787,6 @@
             <actualResult type="variable">expectedContentBlockHeightWithPadding</actualResult>
         </assertEquals>
     </actionGroup>
-    <actionGroup name="validateContentBlockHeightOnStageFromInteger">
-        <arguments>
-            <argument name="contentBlock"/>
-            <argument name="index" defaultValue="1" type="string"/>
-            <argument name="expectedHeight" defaultValue="1" type="string"/>
-        </arguments>
-        <executeJS function="{{PageBuilderActionsSection.computedHeightOnStage(contentBlock.role,index)}}" stepKey="actualStageContentBlockHeight"/>
-        <executeJS function="return Math.round({{expectedHeight}})" stepKey="expectedContentBlockHeight"/>
-        <assertEquals stepKey="assertHeightOnStageMatchesExpected">
-            <expectedResult type="variable">actualStageContentBlockHeight</expectedResult>
-            <actualResult type="variable">expectedContentBlockHeight</actualResult>
-        </assertEquals>
-    </actionGroup>
     <actionGroup name="validateContentBlockHeightOnStageWithoutPadding">
         <arguments>
             <argument name="contentBlock"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnContentTest.xml

@@ -107,7 +107,6 @@
             <argument name="containerTargetIndex" value="1"/>
         </actionGroup>
         <comment userInput="Validate Column Height does not shrink to Tabs Height" stepKey="commentValidateColumnHeightWithTabs"/>
-        <executeJS function="{{PageBuilderActionsSection.computedHeightOnStage(PageBuilderTabsContentBlock.role,'1')}}" stepKey="actualStageTabsHeight"/>
         <executeJS function="{{PageBuilderActionsSection.computedHeightOnStage(PageBuilderColumnContentBlock.role,'1')}}" stepKey="actualStageColumnHeightWithTabs"/>
         <assertEquals stepKey="assertColumnHeightDoesNotAdjustToTabsHeight">
             <expectedResult type="variable">actualStageInitialColumnHeight</expectedResult>
@@ -152,11 +151,12 @@
         </actionGroup>
         <actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
         <comment userInput="Validate Column Height On Stage With Custom Min Height Matches Expected" stepKey="commentValidateColumnHeight"/>
-        <actionGroup ref="validateContentBlockHeightOnStageFromInteger" stepKey="assertInitialColumnHeightMatchesExpected">
-            <argument name="contentBlock" value="PageBuilderColumnContentBlock"/>
-            <argument name="index" value="1"/>
-            <argument name="expectedHeight" value="210"/>
-        </actionGroup>
+        <executeJS function="{{PageBuilderActionsSection.computedHeightOnStage(PageBuilderColumnContentBlock.role,'1')}}" stepKey="actualStageContentBlockHeight"/>
+        <executeJS function="return Math.round({{PageBuilderAppearanceMinHeightProperty_200.value}} + {{PageBuilderAdvancedMarginsAndPaddingProperty.paddingTop}} + {{PageBuilderAdvancedMarginsAndPaddingProperty.paddingBottom}})" stepKey="expectedColumnHeight"/>
+        <assertEquals stepKey="assertHeightOnStageMatchesExpected">
+            <expectedResult type="variable">actualStageContentBlockHeight</expectedResult>
+            <actualResult type="variable">expectedColumnHeight</actualResult>
+        </assertEquals>
         <executeJS function="{{PageBuilderActionsSection.computedHeightOnStage(PageBuilderColumnContentBlock.role,'1')}}" stepKey="actualStageInitialColumnHeight"/>
         <comment userInput="Validate Row Height adjusts to Column Height" stepKey="commentValidateRowHeightAdjustToColumn"/>
         <executeJS function="{{PageBuilderActionsSection.computedHeightOnStage(PageBuilderRowContentBlock.role,'1')}}" stepKey="actualStageRowHeightWithColumns"/>