Skip to content

Commit 93f9ff5

Browse files
committed
MC-3723: Advanced properties saving when invalid value is specified
- add margin invalid max check
1 parent 02ead51 commit 93f9ff5

File tree

1 file changed

+56
-0
lines changed

1 file changed

+56
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1893,6 +1893,62 @@
18931893
<argument name="field" value="marginLeft"/>
18941894
<argument name="value" value=""/>
18951895
</actionGroup>
1896+
<!-- Add Invalid Margin: Invalid Max - Margin Top -->
1897+
<comment userInput="Add Invalid Margin: Invalid Max - Margin Top" stepKey="commentInvalidMaxMarginTop"/>
1898+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxMarginTop">
1899+
<argument name="field" value="marginTop"/>
1900+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
1901+
</actionGroup>
1902+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxMarginTop">
1903+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
1904+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
1905+
</actionGroup>
1906+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxMarginTop">
1907+
<argument name="field" value="marginTop"/>
1908+
<argument name="value" value=""/>
1909+
</actionGroup>
1910+
<!-- Add Invalid Margin: Invalid Max - Margin Right -->
1911+
<comment userInput="Add Invalid Margin: Invalid Max - Margin Right" stepKey="commentInvalidMaxMarginRight"/>
1912+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxMarginRight">
1913+
<argument name="field" value="marginRight"/>
1914+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
1915+
</actionGroup>
1916+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxMarginRight">
1917+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
1918+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
1919+
</actionGroup>
1920+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxMarginRight">
1921+
<argument name="field" value="marginRight"/>
1922+
<argument name="value" value=""/>
1923+
</actionGroup>
1924+
<!-- Add Invalid Margin: Invalid Max - Margin Bottom -->
1925+
<comment userInput="Add Invalid Margin: Invalid Max - Margin Bottom" stepKey="commentInvalidMaxMarginBottom"/>
1926+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxMarginBottom">
1927+
<argument name="field" value="marginBottom"/>
1928+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
1929+
</actionGroup>
1930+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxMarginBottom">
1931+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
1932+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
1933+
</actionGroup>
1934+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxMarginBottom">
1935+
<argument name="field" value="marginBottom"/>
1936+
<argument name="value" value=""/>
1937+
</actionGroup>
1938+
<!-- Add Invalid Margin: Invalid Max - Margin Left -->
1939+
<comment userInput="Add Invalid Margin: Invalid Max - Margin Left" stepKey="commentInvalidMaxMarginLeft"/>
1940+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxMarginLeft">
1941+
<argument name="field" value="marginLeft"/>
1942+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
1943+
</actionGroup>
1944+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxMarginLeft">
1945+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
1946+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
1947+
</actionGroup>
1948+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxMarginLeft">
1949+
<argument name="field" value="marginLeft"/>
1950+
<argument name="value" value=""/>
1951+
</actionGroup>
18961952
<!-- User can recover after invalid input -->
18971953
<comment userInput="User can recover after invalid input" stepKey="commentCanRecover"/>
18981954
<actionGroup ref="fillSlideOutPanelFieldMargins" stepKey="enterMargins">

0 commit comments

Comments
 (0)