Skip to content

Commit a2001d0

Browse files
committed
#514: User sees content snapshot on Category Page in Admin Panel - PageBuilderContentSnapshotFullScreenTest, Category Page mftf refactoring.
1 parent 0cfb592 commit a2001d0

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/AdminOpenPageBuilderFromContentPreviewOverlayActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="adminOpenPageBuilderFromContentPreviewOverlay">
10+
<actionGroup name="AdminOpenPageBuilderFromContentPreviewOverlay">
1111
<annotations>
1212
<description>Verifies Page Builder Full Screen is ready.</description>
1313
</annotations>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/ValidatePageBuilderPreviewActionGroup.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,21 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="validatePageBuilderPreview">
10+
<actionGroup name="ValidatePageBuilderPreview">
1111
<annotations>
1212
<description>Verifies Page Builder preview is ready.</description>
1313
</annotations>
1414
<arguments>
1515
<argument name="pageBuilderArea" defaultValue="" type="string"/>
1616
</arguments>
17-
<waitForElementVisible selector="{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="waitForEditWithPageBuilderButton"/>
17+
<waitForElementVisible selector="{{pageBuilderArea}}{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="waitForEditWithPageBuilderButton"/>
18+
<see userInput="Edit with Page Builder" selector="{{pageBuilderArea}}{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="seeEditWithPageBuilderButton"/>
1819
<dontSeeElementInDOM selector="{{PageBuilderPanel.leftPanel}}" stepKey="dontSeePageBuilderContentTypePanel"/>
1920
<dontSeeElementInDOM selector="{{pageBuilderArea}}{{PageBuilderStage.applyTemplateButton}}" stepKey="dontSeePageBuilderApplyTemplateButton"/>
2021
<dontSeeElementInDOM selector="{{pageBuilderArea}}{{PageBuilderStage.saveAsTemplateButton}}" stepKey="dontSeePageBuilderSaveAsTemplateButton"/>
2122
<waitForElementVisible selector="{{PageBuilderStage.stageOverlay}}" stepKey="waitForStageOverlay"/>
2223
<moveMouseOver selector="{{PageBuilderStage.stageOverlay}}" stepKey="mouseOverStageOverlay"/>
2324
<waitForElementVisible selector="{{PageBuilderStage.stageOverlayOnHover}}" stepKey="waitForStageOverlayOnHover"/>
25+
<dontSeeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenu(PageBuilderRowContentType.role)}}" stepKey="dontSeeRowOptionMenu"/>
2426
</actionGroup>
2527
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection/PageBuilderStageSection.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@
88
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1010
<section name="PageBuilderStage">
11-
<element name="pageBuilderArea" type="text" selector="//div[@data-index='{{var1}}']" parameterized="true"/>
1211
<element name="imageSource" type="text" selector="//img[contains(@src,'{{var1}}')]" parameterized="true"/>
1312
<element name="applyTemplateButton" type="button" selector="//button[contains(@data-bind,'toggleTemplateManger') and text()='Apply Template']"/>
1413
<element name="saveAsTemplateButton" type="button" selector="//button[contains(@data-bind,'saveAsTemplate') and text()='Save as Template']"/>
15-
<element name="editWithPageBuilderButton" type="button" selector="button.action-default"/>
14+
<element name="editWithPageBuilderButton" type="button" selector="//button[contains(@data-bind,'pageBuilderEditButtonClick')]"/>
1615
<element name="openFullScreen" type="button" selector="//i[@class='icon-pagebuilder-fullscreen']"/>
1716
<element name="exitFullScreen" type="button" selector=".pagebuilder-header .icon-pagebuilder-fullscreen-exit"/>
1817
<element name="stageLoading" type="button" selector="div.pagebuilder-stage-loading"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminContentSnapshot/PageBuilderCatalogCategoryContentSnapshotTest.xml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,11 @@
3131
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3232
</after>
3333
<!-- Verify Page Builder preview is ready -->
34-
<actionGroup ref="validatePageBuilderPreview" stepKey="verifyPageBuilderPreview">
35-
<argument name="pageBuilderArea" value="{{PageBuilderStage.pageBuilderArea('description')}}"/>
36-
</actionGroup>
34+
<actionGroup ref="ValidatePageBuilderPreview" stepKey="verifyPageBuilderPreview"/>
3735
<!-- Verify Empty Row -->
3836
<actionGroup ref="verifyEmptyStage" stepKey="verifyStageEmptyRow"/>
3937
<!-- Verify Page Builder Full Screen -->
40-
<actionGroup ref="adminOpenPageBuilderFromContentPreviewOverlay" stepKey="verifyPageBuilderFullScreen"/>
38+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlay" stepKey="verifyPageBuilderFullScreen"/>
4139
<!-- Verify Empty Row -->
4240
<actionGroup ref="verifyEmptyStage" stepKey="verifyFullScreenEmptyRow"/>
4341
<!-- Add Button to Row -->
@@ -47,18 +45,18 @@
4745
<actionGroup ref="dragContentTypeToStage" stepKey="dragContentTypeToStage">
4846
<argument name="contentType" value="PageBuilderButtonsContentType"/>
4947
</actionGroup>
48+
<actionGroup ref="inlineEditButton" stepKey="inlineEditButton">
49+
<argument name="text" value="PageBuilderButtonItemText_OneCharacter"/>
50+
</actionGroup>
5051
<!-- Exit full screen -->
5152
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitFullScreen"/>
52-
<!-- Verify PageBuilder Button Content Type is on Stage -->
53-
<!-- ERROR -->
54-
<waitForElementVisible selector="{{ButtonItemOnStage.emptyButtonItemElement('1')}}" stepKey="seePageBuilderButtonsContentTypeEmpty"/>
53+
<!-- Verify PageBuilder Button Content Type is on Stage -->
54+
<waitForElementVisible selector="{{ButtonItemOnStorefrontEmptyLink.buttonItemText('1', PageBuilderButtonItemText_OneCharacter.value)}}" stepKey="seePageBuilderButtonText"/>
5555
<!-- Verify no Empty Preview Message on Stage -->
5656
<dontSeeElementInDOM selector="{{RowOnStage.empty('1')}}" stepKey="dontSeeEmptyPreviewMessageOnStage"/>
5757
<!-- Verify Page Builder preview is ready -->
58-
<actionGroup ref="validatePageBuilderPreview" stepKey="verifyPageBuilderPreviewAfterFullScreen">
59-
<argument name="pageBuilderArea" value="{{PageBuilderStage.pageBuilderArea('description')}}"/>
60-
</actionGroup>
58+
<actionGroup ref="ValidatePageBuilderPreview" stepKey="verifyPageBuilderPreviewAfterFullScreen"/>
6159
<!-- Verify Page Builder Full Screen -->
62-
<actionGroup ref="adminOpenPageBuilderFromContentPreviewOverlay" stepKey="verifyPageBuilderFullScreenAfterFullScreen"/>
60+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlay" stepKey="verifyPageBuilderFullScreenAfterFullScreen"/>
6361
</test>
6462
</tests>

0 commit comments

Comments
 (0)