Skip to content

Commit aa7df53

Browse files
committed
MC-5079: Add Box Sizing to Storefront Styles (Border & Height Storefront Issues)
- add new test to assert row with borders and padding is equal to min height
1 parent 84013fe commit aa7df53

File tree

1 file changed

+71
-0
lines changed

1 file changed

+71
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowLayoutTest.xml

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,77 @@
149149
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
150150
<waitForElementVisible selector="{{RowOnStage.minHeight('1', PageBuilderMinHeightProperty_500.value)}}" stepKey="seeFirstRowMinHeightAfterSave"/>
151151
</test>
152+
<test name="RowWithBordersAndPaddingEqualToMinHeight">
153+
<annotations>
154+
<features value="PageBuilder"/>
155+
<stories value="Row"/>
156+
<title value="Row height is equal to min height"/>
157+
<description value="A user can see Row height with borders and padding is equal to min height"/>
158+
<severity value="CRITICAL"/>
159+
<useCaseId value="MC-5079"/>
160+
<testCaseId value="MC-5765"/>
161+
<group value="pagebuilder"/>
162+
<group value="pagebuilder-row"/>
163+
<group value="pagebuilder-rowLayout"/>
164+
</annotations>
165+
<before>
166+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
167+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
168+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
169+
</before>
170+
<after>
171+
<actionGroup ref="logout" stepKey="logout"/>
172+
</after>
173+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
174+
<argument name="contentType" value="PageBuilderRowContentType"/>
175+
</actionGroup>
176+
<!-- Configure content type -->
177+
<comment userInput="Configure content type" stepKey="commentConfigureContentType"/>
178+
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel">
179+
<argument name="contentType" value="PageBuilderRowContentType"/>
180+
<argument name="contentTypeIndex" value="1"/>
181+
</actionGroup>
182+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty">
183+
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
184+
</actionGroup>
185+
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBorder">
186+
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
187+
</actionGroup>
188+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderColor">
189+
<argument name="property" value="PageBuilderAdvancedBorderColorProperty_green"/>
190+
</actionGroup>
191+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderWidth">
192+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty10"/>
193+
</actionGroup>
194+
<actionGroup ref="fillSlideOutPanelFieldPadding" stepKey="enterPadding">
195+
<argument name="property" value="PageBuilderPaddingProperty10"/>
196+
</actionGroup>
197+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
198+
<!-- Validate height on stage before save -->
199+
<comment userInput="Validate height on stage before save" stepKey="commentValidateHeightOnStageBeforeSave"/>
200+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
201+
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
202+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
203+
<argument name="padding" value="PageBuilderPaddingProperty10"/>
204+
</actionGroup>
205+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
206+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
207+
<!-- Validate height on stage after save -->
208+
<comment userInput="Validate height on stage after save" stepKey="commentValidateHeightOnStageAfterSave"/>
209+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
210+
<argument name="content" value="{{RowOnStage.baseCSS}}"/>
211+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
212+
<argument name="padding" value="PageBuilderPaddingProperty10"/>
213+
</actionGroup>
214+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
215+
<argument name="contentType" value="PageBuilderRowContentType"/>
216+
</actionGroup>
217+
<!-- Validate height on storefront -->
218+
<comment userInput="Validate height on storefront" stepKey="commentValidateHeightOnStorefront"/>
219+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
220+
<argument name="content" value="{{RowOnStorefront.baseCSS}}"/>
221+
</actionGroup>
222+
</test>
152223
<test name="RowContentIsVerticallyAligned">
153224
<annotations>
154225
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)