MC-3865: Content Types With Links Redirect On Storefront If Link Is Empty

Use "javascript:void(0)" for empty href attribute values, and style as cursor: auto

Author: danmooney2

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/attribute/link-href.js

@@ -62,7 +62,7 @@ export default class CreateValueForHref implements ConverterInterface {
     public toDom(name: string, data: DataObject): string {
 
         const link = data[name];
-        let href = "";
+        let href = "javascript:void(0)";
 
         if (!link) {
             return href;

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/link-href.ts

@@ -7,13 +7,19 @@
 //  Default appearance styles
 //  _____________________________________________
 
-[data-role='banner'] > a {
-    color: inherit;
-    text-decoration: inherit;
-
-    &:hover {
+[data-role='banner'] {
+    > a {
         color: inherit;
         text-decoration: inherit;
+
+        &:hover {
+            color: inherit;
+            text-decoration: inherit;
+        }
+    }
+
+    [data-element='link'][href='javascript:void(0)'] {
+        cursor: auto;
     }
 }
 

app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/banner/_default.less

@@ -12,6 +12,9 @@
     [data-element='link'] {
         max-width: 100%;
         word-wrap: break-word;
+        &[href='javascript:void(0)'] {
+            cursor: auto;
+        }
     }
 }
 

app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/button-item/_default.less

@@ -11,6 +11,10 @@
     box-sizing: border-box;
     overflow: hidden;
 
+    [data-element='link'][href='javascript:void(0)'] {
+        cursor: auto;
+    }
+
     > a {
         color: inherit;
         text-decoration: inherit;