Skip to content

Commit b42d40c

Browse files
author
Michael Yu
committed
MC-518: Simplify mapping of content type
- Removed extra line - Fixed advanced slider renderer logic
1 parent 0e1544f commit b42d40c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/AdvancedSliderItem.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,8 @@ public function render(array $itemData, array $additionalData = []) : string
103103
}
104104

105105
// mobile wrapper div
106-
$rootElementHtml = '<div' . $this->printAttributes($rootElementAttributes) . '><a';
107-
$rootElementHtml .= isset($eavData['link_url']) ?
108-
' data-element="link" href="' . $eavData['link_url'] . '">' : ' data-element="link">';
106+
$rootElementHtml = '<div' . $this->printAttributes($rootElementAttributes) . '><a data-element="link"';
107+
$rootElementHtml .= isset($eavData['link_url']) ? ' href="' . $eavData['link_url'] . '">' : '>';
109108
$rootElementHtml .= '<div'
110109
. $this->printAttributes($wrapperDivElementAttributes)
111110
. '><div'

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
<argument name="contentType" value="PageBuilderBannerContentType"/>
6565
</actionGroup>
6666
<waitForElementVisible selector="{{BannerOnFrontend.linkUrl(ExternalLink.googleUrl)}}" stepKey="waitForBannerStorefront"/>
67-
6867
</test>
6968
<test name="BannerPosterButtonNeverShow">
7069
<annotations>

0 commit comments

Comments
 (0)