Skip to content

Commit b46e85b

Browse files
anthoulaanthoula
committed
MC-3723: Advanced properties saving when invalid value is specified
- unskip test - update for valid cases
1 parent 377e18d commit b46e85b

File tree

1 file changed

+29
-136
lines changed

1 file changed

+29
-136
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 29 additions & 136 deletions
Original file line numberDiff line numberDiff line change
@@ -1091,9 +1091,6 @@
10911091
<testCaseId value="MC-2821"/>
10921092
<group value="pagebuilder"/>
10931093
<group value="pagebuilder-advancedConfig"/>
1094-
<skip>
1095-
<issueId value="MC-3723"/>
1096-
</skip>
10971094
</annotations>
10981095
<before>
10991096
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -1106,137 +1103,63 @@
11061103
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
11071104
<argument name="contentType" value="PageBuilderTextContentType"/>
11081105
</actionGroup>
1109-
<!-- Add A Row For Each Text Border Width Test -->
1110-
<comment userInput="Add Rows" stepKey="commentAddRows"/>
1111-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage1">
1112-
<argument name="contentType" value="PageBuilderRowContentType"/>
1113-
</actionGroup>
1114-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage2">
1115-
<argument name="contentType" value="PageBuilderRowContentType"/>
1116-
</actionGroup>
1117-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage3">
1118-
<argument name="contentType" value="PageBuilderRowContentType"/>
1119-
</actionGroup>
1120-
<!-- Add Border Width: Empty -->
1121-
<comment userInput="Add Border Width: Empty" stepKey="commentAddBorderWidthEmpty"/>
11221106
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
11231107
<argument name="group" value="PageBuilderTextContentType"/>
11241108
</actionGroup>
1125-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage1">
1109+
<!-- Add Text to Stage -->
1110+
<comment userInput="Add Text to Stage" stepKey="commentAddTextToStage"/>
1111+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage">
11261112
<argument name="contentType" value="PageBuilderTextContentType"/>
11271113
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1128-
<argument name="containerTargetIndex" value="1"/>
11291114
<argument name="contentTypeIndex" value="1"/>
11301115
</actionGroup>
1131-
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage1">
1116+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage2">
11321117
<argument name="contentType" value="PageBuilderTextContentType"/>
1118+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
11331119
<argument name="contentTypeIndex" value="1"/>
11341120
</actionGroup>
1135-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText1">
1136-
<argument name="property" value="PageBuilderTextProperty"/>
1121+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
1122+
<!-- Add Border Width: Empty -->
1123+
<comment userInput="Add Border Width: Empty" stepKey="commentAddBorderWidthEmpty"/>
1124+
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage">
1125+
<argument name="contentType" value="PageBuilderTextContentType"/>
1126+
<argument name="contentTypeIndex" value="1"/>
11371127
</actionGroup>
1138-
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder1">
1128+
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder">
11391129
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
11401130
</actionGroup>
1141-
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidth1">
1131+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidth">
11421132
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
11431133
</actionGroup>
11441134
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
1145-
<!-- Add Border Width: 0 -->
1146-
<comment userInput="Add Border Width: 0" stepKey="commentAddBorderWidth0"/>
1147-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage2">
1148-
<argument name="contentType" value="PageBuilderTextContentType"/>
1149-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1150-
<argument name="containerTargetIndex" value="2"/>
1151-
<argument name="contentTypeIndex" value="2"/>
1152-
</actionGroup>
1135+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor2"/>
1136+
<!-- Add Border Width: 10 -->
1137+
<comment userInput="Add Border Width: 10" stepKey="commentAddBorderWidth10"/>
11531138
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage2">
11541139
<argument name="contentType" value="PageBuilderTextContentType"/>
11551140
<argument name="contentTypeIndex" value="2"/>
11561141
</actionGroup>
1157-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText2">
1158-
<argument name="property" value="PageBuilderTextProperty"/>
1159-
</actionGroup>
11601142
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder2">
11611143
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
11621144
</actionGroup>
11631145
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderWidth2">
1164-
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty0"/>
1146+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty10"/>
11651147
</actionGroup>
11661148
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
1167-
<!-- Add Border Width: 1 -->
1168-
<comment userInput="Add Border Width: 1" stepKey="commentAddBorderWidth1"/>
1169-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage3">
1170-
<argument name="contentType" value="PageBuilderTextContentType"/>
1171-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1172-
<argument name="containerTargetIndex" value="3"/>
1173-
<argument name="contentTypeIndex" value="3"/>
1174-
</actionGroup>
1175-
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage3">
1176-
<argument name="contentType" value="PageBuilderTextContentType"/>
1177-
<argument name="contentTypeIndex" value="3"/>
1178-
</actionGroup>
1179-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText3">
1180-
<argument name="property" value="PageBuilderTextProperty"/>
1181-
</actionGroup>
1182-
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder3">
1183-
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
1184-
</actionGroup>
1185-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderWidth3">
1186-
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1187-
</actionGroup>
1188-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
1189-
<!-- Add Border Width: Invalid -->
1190-
<comment userInput="Add Border Width: Invalid" stepKey="commentAddBorderWidthInvalid"/>
1191-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage4">
1192-
<argument name="contentType" value="PageBuilderTextContentType"/>
1193-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1194-
<argument name="containerTargetIndex" value="4"/>
1195-
<argument name="contentTypeIndex" value="4"/>
1196-
</actionGroup>
1197-
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage4">
1198-
<argument name="contentType" value="PageBuilderTextContentType"/>
1199-
<argument name="contentTypeIndex" value="4"/>
1200-
</actionGroup>
1201-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText4">
1202-
<argument name="property" value="PageBuilderTextProperty"/>
1203-
</actionGroup>
1204-
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder4">
1205-
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
1206-
</actionGroup>
1207-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderWidth4">
1208-
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyInvalid"/>
1209-
</actionGroup>
1210-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings4"/>
12111149
<!-- Stage: Check Border Width: Empty -->
12121150
<comment userInput="Stage: Check Border Width: Empty" stepKey="commentStageCheckEmpty"/>
12131151
<actionGroup ref="validateAdvancedStyleWithNoBorderWidth" stepKey="validateStageEmpty">
12141152
<argument name="page" value="TextOnStage"/>
12151153
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
12161154
<argument name="index" value="1"/>
12171155
</actionGroup>
1218-
<!-- Stage: Check Border Width: 0 -->
1219-
<comment userInput="Stage: Check Border Width: 0" stepKey="commentStageCheck0"/>
1220-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage0">
1221-
<argument name="page" value="TextOnStage"/>
1222-
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1223-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty0"/>
1224-
<argument name="index" value="2"/>
1225-
</actionGroup>
1226-
<!-- Stage: Check Border Width: 1 -->
1227-
<comment userInput="Stage: Check Border Width: 1" stepKey="commentStageCheck1"/>
1156+
<!-- Stage: Check Border Width: 10 -->
1157+
<comment userInput="Stage: Check Border Width: 10" stepKey="commentStageCheck1"/>
12281158
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage1">
12291159
<argument name="page" value="TextOnStage"/>
12301160
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1231-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1232-
<argument name="index" value="3"/>
1233-
</actionGroup>
1234-
<!-- Stage: Check Border Width: Invalid -->
1235-
<comment userInput="Stage: Check Border Width: Invalid" stepKey="commentStageCheckInvalid"/>
1236-
<actionGroup ref="validateAdvancedStyleWithNoBorderWidth" stepKey="validateStageInvalid">
1237-
<argument name="page" value="TextOnStage"/>
1238-
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1239-
<argument name="index" value="4"/>
1161+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
1162+
<argument name="index" value="2"/>
12401163
</actionGroup>
12411164
<comment userInput="Validate Stage After Save" stepKey="commentStageAfterSave"/>
12421165
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
@@ -1248,28 +1171,13 @@
12481171
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
12491172
<argument name="index" value="1"/>
12501173
</actionGroup>
1251-
<!-- Stage: Check Border Width: 0 -->
1252-
<comment userInput="Stage: Check Border Width: 0" stepKey="commentStageCheck02"/>
1253-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage02">
1254-
<argument name="page" value="TextOnStage"/>
1255-
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1256-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty0"/>
1257-
<argument name="index" value="2"/>
1258-
</actionGroup>
1259-
<!-- Stage: Check Border Width: 1 -->
1260-
<comment userInput="Stage: Check Border Width: 1" stepKey="commentStageCheck12"/>
1174+
<!-- Stage: Check Border Width: 10 -->
1175+
<comment userInput="Stage: Check Border Width: 10" stepKey="commentStageCheck12"/>
12611176
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage12">
12621177
<argument name="page" value="TextOnStage"/>
12631178
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1264-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1265-
<argument name="index" value="3"/>
1266-
</actionGroup>
1267-
<!-- Stage: Check Border Width: Invalid -->
1268-
<comment userInput="Stage: Check Border Width: Invalid" stepKey="commentStageCheckInvalid2"/>
1269-
<actionGroup ref="validateAdvancedStyleWithNoBorderWidth" stepKey="validateStageInvalid2">
1270-
<argument name="page" value="TextOnStage"/>
1271-
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1272-
<argument name="index" value="4"/>
1179+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
1180+
<argument name="index" value="2"/>
12731181
</actionGroup>
12741182
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
12751183
<argument name="contentType" value="PageBuilderTextContentType"/>
@@ -1281,28 +1189,13 @@
12811189
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
12821190
<argument name="index" value="1"/>
12831191
</actionGroup>
1284-
<!-- Storefront: Check Border Width: 0 -->
1285-
<comment userInput="Storefront: Check Border Width: 0" stepKey="commentStorefrontCheck0"/>
1286-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStorefront0">
1287-
<argument name="page" value="TextOnStorefront"/>
1288-
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1289-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty0"/>
1290-
<argument name="index" value="2"/>
1291-
</actionGroup>
1292-
<!-- Storefront: Check Border Width: 1 -->
1293-
<comment userInput="Storefront: Check Border Width: 1" stepKey="commentStorefrontCheck1"/>
1192+
<!-- Storefront: Check Border Width: 10 -->
1193+
<comment userInput="Storefront: Check Border Width: 10" stepKey="commentStorefrontCheck1"/>
12941194
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStorefront1">
12951195
<argument name="page" value="TextOnStorefront"/>
12961196
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1297-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1298-
<argument name="index" value="3"/>
1299-
</actionGroup>
1300-
<!-- Storefront: Check Border Width: Invalid -->
1301-
<comment userInput="Storefront: Check Border Width: Invalid" stepKey="commentStorefrontCheckInvalid"/>
1302-
<actionGroup ref="validateAdvancedStyleWithNoBorderWidth" stepKey="validateStorefrontInvalid">
1303-
<argument name="page" value="TextOnStorefront"/>
1304-
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1305-
<argument name="index" value="4"/>
1197+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
1198+
<argument name="index" value="2"/>
13061199
</actionGroup>
13071200
</test>
13081201
<test name="AdvancedConfigurationFunctionalBorderWidth500">

0 commit comments

Comments
 (0)