Skip to content

Commit b6ae866

Browse files
#429: User can add content to the Stage directly
- fix tests after code review
1 parent e31db22 commit b6ae866

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdminActionGroup/SwitchToPageBuilderStageActionGroup.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<click selector="{{editButtonSelector}}" stepKey="clickEditButton"/>
2424
<waitForPageLoad stepKey="waitForFullScreenAnimation"/>
2525
<waitForElementNotVisible selector="{{PageBuilderStage.stageLoading}}" stepKey="waitForStageLoadingGraphicNotVisible"/>
26-
<waitForElementVisible time="30" selector="{{PageBuilderStage.rootContainer(rowIndex)}}" stepKey="waitForPageBuilderRow"/>
26+
<waitForElementVisible time="30" selector="{{PageBuilderStage.rootContainer(rowIndex)}}" stepKey="waitForPageBuilderRootContainer"/>
27+
<comment userInput="removing deprecated element" stepKey="waitForPageBuilderRow"/>
2728
</actionGroup>
2829
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/AdminVerifyEmptyStageActionGroup.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
</arguments>
1818
<waitForPageLoad stepKey="waitForStageLoad"/>
1919
<waitForElementVisible selector="{{PageBuilderStage.rootContainer(rotContainerIndex)}}" stepKey="waitForEmptyRootContainer"/>
20-
<seeElement selector="{{PageBuilderStage.rootContainer(rotContainerIndex)}}" stepKey="seeEmptyRootContainer"/>
2120
<see userInput="Drag Row, Columns, Tabs, Block, Dynamic Block or HTML Code here" selector="{{PageBuilderStage.rootContainerPlaceholder(rotContainerIndex)}}" stepKey="seeEmptyRootContainerPlaceholderMessage"/>
2221
<seeNumberOfElements userInput="0" selector="{{pageBuilderArea}}{{RowOnStage.allRows}}" stepKey="seeZeroRow"/>
2322
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest/BannerUploadImageFromStageTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
</actionGroup>
5454
<!-- Verify On Hover Upload Button Work-->
5555
<comment userInput="Verify On Hover Upload Buttons Work" stepKey="commentVerifyButtons"/>
56-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="loseFocus"/>
56+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusOptionMenu"/>
5757
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons">
5858
<argument name="contentType" value="PageBuilderBannerContentType"/>
5959
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest/BlockCannotAddToStageTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<group value="pagebuilder-block"/>
2121
<group value="pagebuilder-cannotAddToStage"/>
2222
<skip>
23-
<issueId value="PB-508"/>
23+
<issueId value="DEPRECATED">Block was allowed as a root container</issueId>
2424
</skip>
2525
</annotations>
2626
<before>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest/ColumnCannotAddToStageTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<group value="pagebuilder-columnGeneral"/>
2222
<group value="pagebuilder-cannotAddToStage"/>
2323
<skip>
24-
<issueId value="PB-508"/>
24+
<issueId value="DEPRECATED">Block was allowed as a root container</issueId>
2525
</skip>
2626
</annotations>
2727
<before>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHtmlTest/HTMLCannotAddToStageTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<group value="pagebuilder-html"/>
2121
<group value="pagebuilder-cannotAddToStage"/>
2222
<skip>
23-
<issueId value="PB-508"/>
23+
<issueId value="DEPRECATED">Block was allowed as a root container</issueId>
2424
</skip>
2525
</annotations>
2626
<before>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest/RowCantRemoveLastRowTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<group value="pagebuilder-row"/>
2121
<group value="pagebuilder-rowGeneral"/>
2222
<skip>
23-
<issueId value="PB-508"/>
23+
<issueId value="DEPRECATED">Block was allowed as a root container</issueId>
2424
</skip>
2525
</annotations>
2626
<before>

0 commit comments

Comments
 (0)