Skip to content

Commit b9b379b

Browse files
bdenhamdanmooney2
authored andcommitted
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Update the master-format documentation for slider and banner
1 parent 6f07be0 commit b9b379b

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

docs/master-format.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ Poster
564564

565565
```
566566
<div data-element="main" data-role="slide" data-slide-name="" data-appearance="poster" data-show-button="hover" data-show-overlay="always" style="...">
567-
<a data-element="link" href="" target="" data-link-type="default">
567+
<div data-element="link" data-href="" data-target="" data-link-type="default">
568568
<div data-element="desktop_image" class="pagebuilder-slide-wrapper pagebuilder-mobile-hidden" style="...">
569569
<div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="rgba(255,255,255,0.5)" style="">
570570
<div class="pagebuilder-poster-content">
@@ -581,15 +581,15 @@ Poster
581581
</div>
582582
</div>
583583
</div>
584-
</a>
584+
</div>
585585
</div>
586586
```
587587

588588
Collage Left
589589

590590
```
591591
<div data-element="main" data-role="slide" data-slide-name="" data-appearance="collage-left" data-show-button="hover" data-show-overlay="always" style="...">
592-
<a data-element="link" href="" target="" data-link-type="default">
592+
<div data-element="link" data-href="" data-target="" data-link-type="default">
593593
<div data-element="desktop_image" class="pagebuilder-slide-wrapper pagebuilder-mobile-hidden" style="...">
594594
<div data-element="overlay" class="pagebuilder-overlay" data-overlay-color="rgba(255,255,255,0.5)" style="">
595595
<div class="pagebuilder-collage-content">
@@ -606,15 +606,15 @@ Collage Left
606606
</div>
607607
</div>
608608
</div>
609-
</a>
609+
</div>
610610
</div>
611611
```
612612

613613
Collage Centered
614614

615615
```
616616
<div data-element="main" data-role="slide" data-slide-name="" data-appearance="collage-centered" data-show-button="hover" data-show-overlay="always" style="...">
617-
<a data-element="link" href="" target="" data-link-type="default">
617+
<div data-element="link" data-href="" data-target="" data-link-type="default">
618618
<div data-element="desktop_image" class="pagebuilder-slide-wrapper pagebuilder-mobile-hidden" style="...">
619619
<div data-element="overlay" class="pagebuilder-overlay" data-overlay-color="rgba(255,255,255,0.5)" style="">
620620
<div class="pagebuilder-collage-content">
@@ -631,15 +631,15 @@ Collage Centered
631631
</div>
632632
</div>
633633
</div>
634-
</a>
634+
</div>
635635
</div>
636636
```
637637

638638
Collage Right
639639

640640
```
641641
<div data-element="main" data-role="slide" data-slide-name="" data-appearance="collage-right" data-show-button="hover" data-show-overlay="always" style="...">
642-
<a data-element="link" href="" target="" data-link-type="default">
642+
<div data-element="link" data-href="" data-target="" data-link-type="default">
643643
<div data-element="desktop_image" class="pagebuilder-slide-wrapper pagebuilder-mobile-hidden" style="...">
644644
<div data-element="overlay" class="pagebuilder-overlay" data-overlay-color="rgba(255,255,255,0.5)" style="">
645645
<div class="pagebuilder-collage-content">
@@ -656,7 +656,7 @@ Collage Right
656656
</div>
657657
</div>
658658
</div>
659-
</a>
659+
</div>
660660
</div>
661661
```
662662

@@ -680,8 +680,8 @@ Inline styles
680680

681681
Attributes
682682
1. data-element [link]
683-
2. href
684-
3. target
683+
2. data-href
684+
3. data-target
685685
4. data-link-type
686686

687687
### overlay element
@@ -751,7 +751,7 @@ Poster
751751

752752
```
753753
<div data-element="main" data-role="banner" data-appearance="poster" data-overlay-color="rgb(0, 0, 0)" data-appearance="poster" style="...">
754-
<a data-element="link" href="" target="">
754+
<div data-element="link" data-href="" data-target="">
755755
<div data-element="mobile_image" class="wrapper pagebuilder-mobile-only">
756756
<div data-element="overlay" style="" class="overlay">
757757
<div class="content">
@@ -768,15 +768,15 @@ Poster
768768
</div>
769769
</div>
770770
</div>
771-
</a>
771+
</div>
772772
</div>
773773
```
774774

775775
Collage Left
776776

777777
```
778778
<div data-element="main" data-role="banner" data-appearance="collage-left" data-overlay-color="rgb(0, 0, 0)" data-appearance="collage-left" style="" class="pagebuilder-banner">
779-
<a data-element="link" href="" target="">
779+
<div data-element="link" data-href="" data-target="">
780780
<div data-element="desktop_image" style=""
781781
class="pagebuilder-desktop-only wrapper">
782782
<div data-element="overlay" style="" class="overlay>
@@ -794,15 +794,15 @@ Collage Left
794794
</div>
795795
</div>
796796
</div>
797-
</a>
797+
</div>
798798
</div>
799799
```
800800

801801
Collage Centered
802802

803803
```
804804
<div data-element="main" data-role="banner" data-appearance="collage-centered" data-overlay-color="rgb(0, 0, 0)" data-appearance="collage-center" style="" class="pagebuilder-banner">
805-
<a data-element="link" href="" target="">
805+
<div data-element="link" data-href="" data-target="">
806806
<div data-element="desktop_image" style="" class="pagebuilder-desktop-only wrapper">
807807
<div data-element="overlay" class="overlay">
808808
<div class="content">
@@ -819,14 +819,14 @@ Collage Centered
819819
</div>
820820
</div>
821821
</div>
822-
</a>
822+
</div>
823823
</div>
824824
```
825825
Collage Right
826826

827827
```
828828
<div data-element="main" data-role="banner" data-appearance="collage-right" data-overlay-color="rgb(0, 0, 0)" data-appearance="collage-right" style="" class="pagebuilder-banner">
829-
<a data-element="link" href="" target="">
829+
<div data-element="link" data-href="" data-target="">
830830
<div data-element="desktop_image" style="" class="pagebuilder-desktop-only wrapper">
831831
<div data-element="overlay" style="" class="overlay">
832832
<div class="content">
@@ -843,7 +843,7 @@ Collage Right
843843
</div>
844844
</div>
845845
</div>
846-
</a>
846+
</div>
847847
</div>
848848
```
849849

@@ -870,8 +870,8 @@ Attributes
870870
1. data-element [link]
871871
2. data-role
872872
3. data-appearance
873-
4. href
874-
5. target
873+
4. data-href
874+
5. data-target
875875
6. data-link-type
876876

877877
### overlay element
@@ -882,8 +882,8 @@ Attributes
882882
3. data-appearance
883883
4. data-link-type
884884
5. data-overlay-color
885-
6. href
886-
7. target
885+
6. data-href
886+
7. data-target
887887

888888
Inline styles
889889
1. background-color

0 commit comments

Comments
 (0)