Skip to content

Commit bf44d53

Browse files
committed
MC-5474: Anchor tag name is used on banner/slide/image wrapper when no link is specified by admin
Fix spacing of attribute output
1 parent e504631 commit bf44d53

File tree

1 file changed

+2
-2
lines changed
  • app/code/Magento/PageBuilder/Setup/DataConverter/Renderer

1 file changed

+2
-2
lines changed

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/ButtonItem.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ public function render(array $itemData, array $additionalData = []) : string
6969

7070
$linkNodeName = isset($eavData['link_url']) ? 'a' : 'div';
7171

72-
$rootElementHtml .= '><' . $linkNodeName . ' data-element="link" href="'
73-
. ($eavData['link_url'] ?? '') . '"'
72+
$rootElementHtml .= '><' . $linkNodeName . ' data-element="link"'
73+
. (isset($eavData['link_url']) ? ' href="' . $eavData['link_url'] . '"' : '')
7474
. $buttonStyleAttribute
7575
. ' class="pagebuilder-button-primary"><span data-element="link_text">'
7676
. ($eavData['link_text'] ?? '')

0 commit comments

Comments
 (0)