Skip to content

Commit c1c48cb

Browse files
committed
MAGETWO-91968: No Required Attributes
- Updating button group no required attribute test to check for no required classes - Adding supporting element
1 parent d1d6a27 commit c1c48cb

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/PageBuilder/Section/PageBuilderActionsSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
<element name="editFormClose" type="button" selector=".modal-header .page-main-actions [data-form-role='close']" timeout="30"/>
6767
<element name="editFormReset" type="button" selector=".modal-header .page-main-actions [data-form-role='reset']" timeout="30"/>
6868
<element name="editFormSave" type="button" selector=".modal-header .page-main-actions [data-form-role='save']" timeout="30"/>
69+
<element name="editFormAllRequiredFields" type="text" selector="aside.pagebuilder_modal_form_pagebuilder_modal_form_modal ._required:not([style*='display: none;'])"/>
6970
<element name="panelFieldLabel" type="text" selector='//aside//div[@data-index="{{arg1}}"]/descendant::div[@data-index="{{arg2}}"]/label | //aside//div[@data-index="{{arg3}}"]/descendant::*[@class="admin__field-label" or @class="title"]/span[text()="{{arg4}}"]' parameterized="true" />
7071
<element name="panelSectionChangedIcon" type="text" selector="[data-index='{{arg1}}'] ._changed .admin__page-nav-item-message-icon" parameterized="true"/>
7172
<element name="panelSectionError" type="text" selector="[data-index='{{arg1}}'] span._error .admin__page-nav-item-message-icon" parameterized="true"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/PageBuilder/Test/AdminPageBuilderButtonsTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1091,9 +1091,6 @@
10911091
<after>
10921092
<actionGroup ref="logout" stepKey="logout"/>
10931093
</after>
1094-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1095-
<argument name="contentBlockType" value="PageBuilderButtonsContentBlock"/>
1096-
</actionGroup>
10971094
<actionGroup ref="dragContentBlockToStage" stepKey="dragContentBlockToStage">
10981095
<argument name="contentBlockType" value="PageBuilderButtonsContentBlock"/>
10991096
</actionGroup>
@@ -1102,6 +1099,7 @@
11021099
</actionGroup>
11031100
<!-- Validate No Required Fields -->
11041101
<comment userInput="Validate No Required Fields" stepKey="commentValidateNoRequired"/>
1102+
<dontSeeElementInDOM selector="{{PageBuilderActionsSection.editFormAllRequiredFields}}" stepKey="dontSeeRequiredClassInEditForm"/>
11051103
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
11061104
<waitForElementVisible time="10" selector="{{CmsNewPagePageActionsSection.saveAndContinueEdit}}" stepKey="waitForCmsPageSaveButton"/>
11071105
</test>

0 commit comments

Comments
 (0)