Skip to content

Commit c6f5afc

Browse files
committed
MAGETWO-92821: [Tech Debt] Update slide & slider forms to use true / false values instead of 0 / 1
- Ensure settings are handled correctly on the admin
1 parent c328e9b commit c6f5afc

File tree

2 files changed

+8
-8
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+8
-8
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -350,12 +350,12 @@ export default class Preview extends PreviewCollection {
350350
private buildSlickConfig() {
351351
const data = this.parent.dataStore.get();
352352
return {
353-
arrows: data.show_arrows === "1",
354-
autoplay: data.autoplay === "1",
353+
arrows: data.show_arrows === "true",
354+
autoplay: data.autoplay === "true",
355355
autoplaySpeed: data.autoplay_speed,
356356
dots: false, // We have our own dots implemented
357-
fade: data.fade === "1",
358-
infinite: data.is_infinite === "1",
357+
fade: data.fade === "true",
358+
infinite: data.is_infinite === "true",
359359
waitForAnimate: false,
360360
};
361361
}

0 commit comments

Comments
 (0)