Skip to content

Commit cdc79e4

Browse files
danmooney2danmooney2
committed
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Update Slider*OverlayAndButtonOnHover tests to ensure inner/outer anchor navigation works
1 parent c438ae4 commit cdc79e4

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@
6969
<element name="base" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]" parameterized="true"/>
7070
<element name="slickSlideIndex" type="text" selector="[data-slick-index='{{arg1}}']" parameterized="true"/>
7171
<element name="computedBoxSizing" type="button" selector="return window.getComputedStyle(document.querySelector('[data-role=slide]')).boxSizing"/>
72+
<element name="wysiwygLinkUrl" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='desktop_image']//a[@href='{{arg2}}']" parameterized="true"/>
73+
<element name="mobileWysiwygLinkUrl" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='mobile_image']//a[@href='{{arg2}}']" parameterized="true"/>
7274
<!-- Appearance Configuration -->
7375
<element name="appearance" type="text" selector="(//div[@data-role='slide'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
7476
<element name="slideName" type="button" selector="(//div[@data-role='slide'])[{{arg1}}][@data-slide-name='{{arg2}}']" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,6 +566,17 @@
566566
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterOverlayTransparency">
567567
<argument name="property" value="PageBuilderSlideItemOverlayTransparency_70"/>
568568
</actionGroup>
569+
<actionGroup ref="fillSlideOutPanelLinkUrlField" stepKey="enterSlideLinkUrl">
570+
<argument name="property" value="PageBuilderSlideItemLinkURL_External"/>
571+
<argument name="selection" value="{{ExternalLink.url}}"/>
572+
<argument name="newTab" value="PageBuilderSlideItemLinkNewTab_False"/>
573+
</actionGroup>
574+
<!-- Add Link To WYSIWYG -->
575+
<comment userInput="Add Link To WYSIWYG" stepKey="commentAddLink"/>
576+
<actionGroup ref="insertLinkInWYSIWYG" stepKey="insertLinkInWYSIWYG">
577+
<argument name="url" value="{{ExternalLink.googleUrl}}"/>
578+
<argument name="textToDisplay" value="{{ExternalLink.googleUrl}}"/>
579+
</actionGroup>
569580
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
570581
<!-- Validate Stage -->
571582
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
@@ -592,17 +603,50 @@
592603
<seeElement selector="{{SlideOnFrontend.button('1')}}" stepKey="seeButtonOnHoverStorefront"/>
593604
<seeElement selector="{{SlideOnFrontend.overlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexWhite.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
594605
<moveMouseOver selector="{{SlideOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromSlide"/>
606+
607+
<!-- Click slide anchor -->
608+
<comment userInput="Click slide anchor" stepKey="clickSlideAnchorStorefront" />
609+
<click selector="{{SlideOnFrontend.linkUrl('1', PageBuilderSlideItemLinkURL_External.value)}}" stepKey="clickLinkUrlStorefront"/>
610+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefront" />
611+
<seeCurrentUrlEquals url="{{PageBuilderSlideItemLinkURL_External.value}}" stepKey="seeThatUrlIsChangedToButtonUrlStorefront" />
612+
<!-- Click wysiwyg anchor -->
613+
<comment userInput="Click wysiwyg anchor" stepKey="clickWysiwygLinkAnchorStorefront" />
614+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront2">
615+
<argument name="contentType" value="PageBuilderSliderContentType"/>
616+
</actionGroup>
617+
<seeElement selector="{{SlideOnFrontend.wysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="seeWysiwygLinkUrlStorefront"/>
618+
<click selector="{{SlideOnFrontend.wysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="clickWysiwygLinkUrlStorefront"/>
619+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefront2" />
620+
<seeCurrentUrlEquals url="{{ExternalLink.googleUrl}}" stepKey="seeThatUrlIsChangedToWysiwygLinkUrlStorefront" />
621+
595622
<!-- Validate Storefront Mobile -->
596623
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
624+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront3">
625+
<argument name="contentType" value="PageBuilderSliderContentType"/>
626+
</actionGroup>
597627
<resizeWindow width="375" height="667" stepKey="resizeWindowToMobile"/>
598628
<seeElement selector="{{SlideOnFrontend.appearance('1', PageBuilderAppearance_Poster.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
599629
<seeElement selector="{{SlideOnFrontend.mobileBackgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefrontMobile"/>
600630
<seeElementInDOM selector="{{SlideOnFrontend.mobileButton('1')}}" stepKey="seeButtonInDOMStorefrontMobile"/>
601-
<dontSeeElement selector="{{SlideOnFrontend.button('1')}}" stepKey="dontSeeButtonStorefrontMobile"/>
631+
<dontSeeElement selector="{{SlideOnFrontend.mobileButton('1')}}" stepKey="dontSeeButtonStorefrontMobile"/>
602632
<seeElement selector="{{SlideOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefrontMobile"/>
603633
<moveMouseOver selector="{{SlideOnFrontend.base('1')}}" x="1" y="1" stepKey="moveMouseOverSlideStorefrontMobile"/>
604634
<seeElement selector="{{SlideOnFrontend.mobileButton('1')}}" stepKey="seeButtonOnHoverStorefrontMobile"/>
605635
<seeElement selector="{{SlideOnFrontend.mobileOverlayColorAndTransparency('1', PageBuilderSlideItemOverlayColor_HexWhite.rgb, PageBuilderSlideItemOverlayTransparency_70.decimal)}}" stepKey="seeOverlayOnHoverStorefrontMobile"/>
636+
<!-- Click mobile slide anchor -->
637+
<comment userInput="Click mobile slide anchor" stepKey="clickMobileSlideAnchorStorefront" />
638+
<click selector="{{SlideOnFrontend.linkUrl('1', PageBuilderSlideItemLinkURL_External.value)}}" stepKey="clickLinkUrlStorefrontMobile"/>
639+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefrontMobile" />
640+
<seeCurrentUrlEquals url="{{PageBuilderSlideItemLinkURL_External.value}}" stepKey="seeThatUrlIsChangedToButtonUrlStorefrontMobile" />
641+
<!-- Click mobile wysiwyg anchor -->
642+
<comment userInput="Click mobile wysiwyg anchor" stepKey="clickMobileWysiwygLinkAnchorStorefront" />
643+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront4">
644+
<argument name="contentType" value="PageBuilderSliderContentType"/>
645+
</actionGroup>
646+
<seeElement selector="{{SlideOnFrontend.mobileWysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="seeMobileWysiwygLinkUrlStorefront"/>
647+
<click selector="{{SlideOnFrontend.mobileWysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="clickMobileWysiwygLinkUrlStorefront"/>
648+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefrontMobile2" />
649+
<seeCurrentUrlEquals url="{{ExternalLink.googleUrl}}" stepKey="seeThatUrlIsChangedToMobileWysiwygLinkUrlStorefront" />
606650
</test>
607651
<test name="SliderItemPosterButtonsCanBeEditedInline">
608652
<annotations>

0 commit comments

Comments
 (0)