PB-170: TinyMCE Performance is very poor with multiple instances on Stage

- Fix slider not always initializing

Author: davemacaulay

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/banner/preview.js

@@ -194,14 +194,16 @@ export default class Preview extends BasePreview {
      * @returns {Boolean}
      */
     public activateEditor(preview: Preview, event: JQueryEventObject) {
-        if (this.element && !this.wysiwyg && !this.handledDoubleClick) {
+        if (this.element && !this.wysiwyg) {
             const bookmark = createBookmark(event);
             lockImageSize(this.element);
             this.element.removeAttribute("contenteditable");
             _.defer(() => {
                 this.initWysiwygFromClick(true)
                     .then(() => delayUntil(
                         () => {
+                            // We no longer need to handle double click once it's initialized
+                            this.handledDoubleClick = true;
                             this.wysiwygDeferred.resolve();
                             moveToBookmark(bookmark);
                             unlockImageSize(this.element);

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

@@ -188,14 +188,16 @@ export default class Preview extends BasePreview {
      * @returns {Boolean}
      */
     public activateEditor(preview: Preview, event: JQueryEventObject) {
-        if (this.element && !this.wysiwyg && !this.handledDoubleClick) {
+        if (this.element && !this.wysiwyg) {
             const bookmark = createBookmark(event);
             lockImageSize(this.element);
             this.element.removeAttribute("contenteditable");
             _.defer(() => {
                 this.initWysiwygFromClick(true)
                     .then(() => delayUntil(
                         () => {
+                            // We no longer need to handle double click once it's initialized
+                            this.handledDoubleClick = true;
                             this.wysiwygDeferred.resolve();
                             moveToBookmark(bookmark);
                             unlockImageSize(this.element);

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/text/preview.js

@@ -181,14 +181,16 @@ export default class Preview extends BasePreview {
      * @returns {Boolean}
      */
     public activateEditor(preview: Preview, event: JQueryEventObject) {
-        if (this.element && !this.wysiwyg && !this.handledDoubleClick) {
+        if (this.element && !this.wysiwyg) {
             const bookmark = createBookmark(event);
             lockImageSize(this.element);
             this.element.removeAttribute("contenteditable");
             _.defer(() => {
                 this.initWysiwygFromClick(true)
                     .then(() => delayUntil(
                         () => {
+                            // We no longer need to handle double click once it's initialized
+                            this.handledDoubleClick = true;
                             this.wysiwygDeferred.resolve();
                             moveToBookmark(bookmark);
                             unlockImageSize(this.element);

app/code/Magento/PageBuilder/view/adminhtml/web/js/utils/editor.js

@@ -34,7 +34,7 @@ export function encodeContent(content: string) {
 }
 
 /**
- * Prior to parsing the content remove and invalid placeholders within the content
+ * Prior to parsing the content remove any invalid placeholders within the content
  *
  * @param content
  */