Skip to content

Commit d1efb33

Browse files
author
Michael Yu
committed
MAGETWO-92335: Architecture Review
- Fixed missed data scope location_name
1 parent e56611f commit d1efb33

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_map_form.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
<dataType>text</dataType>
166166
<label translate="true">Location Name</label>
167167
<visible>true</visible>
168-
<dataScope>name</dataScope>
168+
<dataScope>location_name</dataScope>
169169
<elementTmpl>ui/dynamic-rows/cells/text</elementTmpl>
170170
</settings>
171171
</field>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_map_location_form.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
<settings>
5353
<dataType>text</dataType>
5454
<label translate="true">Location Name</label>
55-
<dataScope>name</dataScope>
55+
<dataScope>location_name</dataScope>
5656
<validation>
5757
<rule name="required-entry-location-name" xsi:type="boolean">true</rule>
5858
<rule name="required-entry" xsi:type="boolean">true</rule>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type-factory.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/components/dynamic-rows.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ define([
101101
allLabels,
102102
placeholder;
103103

104-
if (!property().sortBy) {
104+
if (property().name === "actions") {
105105
return;
106106
}
107107

0 commit comments

Comments
 (0)