Skip to content

Commit d82c102

Browse files
committed
MC-4126: Duplicate row border after switching Row appearance
- Resolve CR comments
1 parent d1ce63e commit d82c102

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1836,7 +1836,7 @@
18361836
<annotations>
18371837
<features value="PageBuilder"/>
18381838
<stories value="Row"/>
1839-
<title value="Row border should change to correct element"/>
1839+
<title value="Row border should change to correct element on appearance change"/>
18401840
<description value="A user should be able to change the appearance on a row and see the border update as expected"/>
18411841
<severity value="MAJOR"/>
18421842
<useCaseId value="MC-4126"/>
@@ -1875,10 +1875,10 @@
18751875
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty10"/>
18761876
</actionGroup>
18771877
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1878-
<waitForElementVisible selector="{{RowOnStage.base('1')}}" stepKey="waitForElementVisible"/>
1879-
<waitForElementVisible selector="{{RowOnStage.border('1', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="waitForBorderVisible"/>
1880-
<waitForElementVisible selector="{{RowOnStage.borderColor('1', PageBuilderAdvancedBorderColorProperty_green.rbg)}}" stepKey="waitForBorderColorVisible"/>
1881-
<waitForElementVisible selector="{{RowOnStage.borderWidth('1', PageBuilderAdvancedBorderWidthProperty10.value)}}" stepKey="waitForBorderWidthVisible"/>
1878+
<seeElement selector="{{RowOnStage.base('1')}}" stepKey="waitForElementVisible"/>
1879+
<seeElement selector="{{RowOnStage.border('1', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="waitForBorderVisible"/>
1880+
<seeElement selector="{{RowOnStage.borderColor('1', PageBuilderAdvancedBorderColorProperty_green.rbg)}}" stepKey="waitForBorderColorVisible"/>
1881+
<seeElement selector="{{RowOnStage.borderWidth('1', PageBuilderAdvancedBorderWidthProperty10.value)}}" stepKey="waitForBorderWidthVisible"/>
18821882
<!-- Change appearance to contained -->
18831883
<comment userInput="Change appearance to contained" stepKey="commentContained"/>
18841884
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage1">
@@ -1888,10 +1888,10 @@
18881888
<argument name="property" value="PageBuilderRowAppearance_Contained"/>
18891889
</actionGroup>
18901890
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
1891-
<waitForElementVisible selector="{{RowOnStage.base('1')}}" stepKey="waitForElementVisible1"/>
1892-
<waitForElementVisible selector="{{RowOnStage.border('1', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="waitForBorderVisible1"/>
1893-
<waitForElementVisible selector="{{RowOnStage.borderColor('1', PageBuilderAdvancedBorderColorProperty_green.rbg)}}" stepKey="waitForBorderColorVisible1"/>
1894-
<waitForElementVisible selector="{{RowOnStage.borderWidth('1', PageBuilderAdvancedBorderWidthProperty10.value)}}" stepKey="waitForBorderWidthVisible1"/>
1891+
<seeElement selector="{{RowOnStage.base('1')}}" stepKey="waitForElementVisible1"/>
1892+
<seeElement selector="{{RowOnStage.border('1', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="waitForBorderVisible1"/>
1893+
<seeElement selector="{{RowOnStage.borderColor('1', PageBuilderAdvancedBorderColorProperty_green.rbg)}}" stepKey="waitForBorderColorVisible1"/>
1894+
<seeElement selector="{{RowOnStage.borderWidth('1', PageBuilderAdvancedBorderWidthProperty10.value)}}" stepKey="waitForBorderWidthVisible1"/>
18951895
<!-- Verify the border is not on the outside of the contained row -->
18961896
<comment userInput="Verify the border is not on the outside of the contained row" stepKey="commentVerifyBorder"/>
18971897
<dontSeeElement selector="{{RowOnStage_Contained_Invalid.border('1', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="dontSeeBorderOnOutside" />

0 commit comments

Comments
 (0)