Skip to content

Commit db8b026

Browse files
anthoulaanthoula
committed
MC-3725: Unify formatting and style across content types
- remove action expandConfigurationSection on Heading
1 parent d1c6709 commit db8b026

File tree

2 files changed

+0
-32
lines changed

2 files changed

+0
-32
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingEditOnStageTest.xml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@
206206
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType1">
207207
<argument name="property" value="PageBuilderHeadingTypeProperty_H1"/>
208208
</actionGroup>
209-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection1"/>
210209
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment1">
211210
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
212211
</actionGroup>
@@ -223,7 +222,6 @@
223222
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType2">
224223
<argument name="property" value="PageBuilderHeadingTypeProperty_H1"/>
225224
</actionGroup>
226-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
227225
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment2">
228226
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
229227
</actionGroup>
@@ -240,7 +238,6 @@
240238
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType3">
241239
<argument name="property" value="PageBuilderHeadingTypeProperty_H1"/>
242240
</actionGroup>
243-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
244241
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment3">
245242
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
246243
</actionGroup>
@@ -257,7 +254,6 @@
257254
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType4">
258255
<argument name="property" value="PageBuilderHeadingTypeProperty_H1"/>
259256
</actionGroup>
260-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection4"/>
261257
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment4">
262258
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
263259
</actionGroup>
@@ -447,7 +443,6 @@
447443
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType1">
448444
<argument name="property" value="PageBuilderHeadingTypeProperty_H2"/>
449445
</actionGroup>
450-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection1"/>
451446
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment1">
452447
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
453448
</actionGroup>
@@ -464,7 +459,6 @@
464459
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType2">
465460
<argument name="property" value="PageBuilderHeadingTypeProperty_H2"/>
466461
</actionGroup>
467-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
468462
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment2">
469463
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
470464
</actionGroup>
@@ -481,7 +475,6 @@
481475
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType3">
482476
<argument name="property" value="PageBuilderHeadingTypeProperty_H2"/>
483477
</actionGroup>
484-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
485478
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment3">
486479
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
487480
</actionGroup>
@@ -498,7 +491,6 @@
498491
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType4">
499492
<argument name="property" value="PageBuilderHeadingTypeProperty_H2"/>
500493
</actionGroup>
501-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection4"/>
502494
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment4">
503495
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
504496
</actionGroup>
@@ -688,7 +680,6 @@
688680
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType1">
689681
<argument name="property" value="PageBuilderHeadingTypeProperty_H3"/>
690682
</actionGroup>
691-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection1"/>
692683
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment1">
693684
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
694685
</actionGroup>
@@ -705,7 +696,6 @@
705696
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType2">
706697
<argument name="property" value="PageBuilderHeadingTypeProperty_H3"/>
707698
</actionGroup>
708-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
709699
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment2">
710700
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
711701
</actionGroup>
@@ -722,7 +712,6 @@
722712
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType3">
723713
<argument name="property" value="PageBuilderHeadingTypeProperty_H3"/>
724714
</actionGroup>
725-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
726715
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment3">
727716
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
728717
</actionGroup>
@@ -739,7 +728,6 @@
739728
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType4">
740729
<argument name="property" value="PageBuilderHeadingTypeProperty_H3"/>
741730
</actionGroup>
742-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection4"/>
743731
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment4">
744732
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
745733
</actionGroup>
@@ -929,7 +917,6 @@
929917
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType1">
930918
<argument name="property" value="PageBuilderHeadingTypeProperty_H4"/>
931919
</actionGroup>
932-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection1"/>
933920
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment1">
934921
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
935922
</actionGroup>
@@ -946,7 +933,6 @@
946933
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType2">
947934
<argument name="property" value="PageBuilderHeadingTypeProperty_H4"/>
948935
</actionGroup>
949-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
950936
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment2">
951937
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
952938
</actionGroup>
@@ -963,7 +949,6 @@
963949
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType3">
964950
<argument name="property" value="PageBuilderHeadingTypeProperty_H4"/>
965951
</actionGroup>
966-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
967952
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment3">
968953
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
969954
</actionGroup>
@@ -980,7 +965,6 @@
980965
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType4">
981966
<argument name="property" value="PageBuilderHeadingTypeProperty_H4"/>
982967
</actionGroup>
983-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection4"/>
984968
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment4">
985969
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
986970
</actionGroup>
@@ -1170,7 +1154,6 @@
11701154
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType1">
11711155
<argument name="property" value="PageBuilderHeadingTypeProperty_H5"/>
11721156
</actionGroup>
1173-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection1"/>
11741157
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment1">
11751158
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
11761159
</actionGroup>
@@ -1187,7 +1170,6 @@
11871170
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType2">
11881171
<argument name="property" value="PageBuilderHeadingTypeProperty_H5"/>
11891172
</actionGroup>
1190-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
11911173
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment2">
11921174
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
11931175
</actionGroup>
@@ -1204,7 +1186,6 @@
12041186
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType3">
12051187
<argument name="property" value="PageBuilderHeadingTypeProperty_H5"/>
12061188
</actionGroup>
1207-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
12081189
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment3">
12091190
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
12101191
</actionGroup>
@@ -1221,7 +1202,6 @@
12211202
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType4">
12221203
<argument name="property" value="PageBuilderHeadingTypeProperty_H5"/>
12231204
</actionGroup>
1224-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection4"/>
12251205
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment4">
12261206
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
12271207
</actionGroup>
@@ -1412,7 +1392,6 @@
14121392
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType1">
14131393
<argument name="property" value="PageBuilderHeadingTypeProperty_H6"/>
14141394
</actionGroup>
1415-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection1"/>
14161395
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment1">
14171396
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyDefault"/>
14181397
</actionGroup>
@@ -1429,7 +1408,6 @@
14291408
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType2">
14301409
<argument name="property" value="PageBuilderHeadingTypeProperty_H6"/>
14311410
</actionGroup>
1432-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
14331411
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment2">
14341412
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
14351413
</actionGroup>
@@ -1446,7 +1424,6 @@
14461424
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType3">
14471425
<argument name="property" value="PageBuilderHeadingTypeProperty_H6"/>
14481426
</actionGroup>
1449-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
14501427
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment3">
14511428
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
14521429
</actionGroup>
@@ -1463,7 +1440,6 @@
14631440
<actionGroup ref="validateSlideOutPanelField" stepKey="validateHeadingType4">
14641441
<argument name="property" value="PageBuilderHeadingTypeProperty_H6"/>
14651442
</actionGroup>
1466-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection4"/>
14671443
<actionGroup ref="validateSlideOutPanelField" stepKey="validateAlignment4">
14681444
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
14691445
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingTest.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@
169169
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
170170
<argument name="contentType" value="PageBuilderHeadingContentType"/>
171171
</actionGroup>
172-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection"/>
173172
<!-- Validate Default Values -->
174173
<comment userInput="Validate Default Values" stepKey="CommentValidateDefaultValues"/>
175174
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment">
@@ -228,7 +227,6 @@
228227
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
229228
<argument name="contentType" value="PageBuilderHeadingContentType"/>
230229
</actionGroup>
231-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
232230
<!-- Validate Edit Panel After Save -->
233231
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
234232
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment2">
@@ -311,7 +309,6 @@
311309
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
312310
<argument name="contentType" value="PageBuilderHeadingContentType"/>
313311
</actionGroup>
314-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection"/>
315312
<!-- Update Values -->
316313
<comment userInput="Update Values" stepKey="commentUpdateValues"/>
317314
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAlignmentCenter">
@@ -356,7 +353,6 @@
356353
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
357354
<argument name="contentType" value="PageBuilderHeadingContentType"/>
358355
</actionGroup>
359-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
360356
<!-- Validate Edit Panel -->
361357
<comment userInput="Validate Edit Panel" stepKey="commentValidateEditPanel"/>
362358
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment">
@@ -403,7 +399,6 @@
403399
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage3">
404400
<argument name="contentType" value="PageBuilderHeadingContentType"/>
405401
</actionGroup>
406-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection3"/>
407402
<!-- Validate Edit Panel After Save -->
408403
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
409404
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment2">
@@ -905,7 +900,6 @@
905900
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearHeadingTextProperty">
906901
<argument name="property" value="PageBuilderHeadingTextProperty"/>
907902
</actionGroup>
908-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection"/>
909903
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderRadiusProperty">
910904
<argument name="property" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
911905
</actionGroup>
@@ -968,7 +962,6 @@
968962
<argument name="property" value="PageBuilderHeadingTypeProperty_H3"/>
969963
</actionGroup>
970964
<!-- Fill All Advanced Fields -->
971-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection"/>
972965
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAlignmentCenter">
973966
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
974967
</actionGroup>
@@ -1027,7 +1020,6 @@
10271020
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="seeHeadingTypeH3">
10281021
<argument name="property" value="PageBuilderHeadingTypeProperty_H3"/>
10291022
</actionGroup>
1030-
<actionGroup ref="expandConfigurationSection" stepKey="expandConfigurationSection2"/>
10311023
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAlignmentCenter2">
10321024
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
10331025
</actionGroup>

0 commit comments

Comments
 (0)