Skip to content

Commit dd35294

Browse files
author
Hwashiang Yu
committed
MC-5386: Anchors Under Each Div if TinyMCE link Is Added to Banner/Slide (Add Notification for When Link Attribute Is Entered)
- Removed extra spacing - Fixed slide-item confirmation dialog logic
1 parent a761899 commit dd35294

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@
150150
<waitForPageLoad stepKey="waitForPageLoad2"/>
151151
<waitForElementNotVisible selector="{{WYSIWYGInsertLinkModal.modal}}" stepKey="waitForInsertLinkModalGone"/>
152152
</actionGroup>
153-
154153
<actionGroup name="addPageLinkToTinyMCEInline" extends="insertLinkInWYSIWYG">
155154
<waitForElementVisible selector="{{TinyMCESection.InsertLink}}" stepKey="waitForInsertLinkButton"/>
156155
<click selector="{{TinyMCESection.InsertLink}}" stepKey="clickInsertLinkButton"/>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ export default class Preview extends BasePreview {
298298
linkUrl[linkUrl.type].length !== 0) {
299299
confirmationDialog({
300300
actions: {
301-
confirm: () => {
301+
always: () => {
302302
const anchorLessMessage = content.replace(aLinkRegex, "");
303303
this.parent.dataStore.update(anchorLessMessage, "content");
304304
$("#" + this.wysiwyg.elementId).html(anchorLessMessage);

0 commit comments

Comments
 (0)