Skip to content

Commit ddde41b

Browse files
committed
MC-3723: Advanced properties saving when invalid value is specified
- remove upper limit for border-width and border-radius
1 parent 44baefd commit ddde41b

File tree

3 files changed

+0
-38
lines changed

3 files changed

+0
-38
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/AdvancedData.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -229,13 +229,6 @@
229229
<data key="value">-1</data>
230230
<data key="errorMessage">Please enter a value greater than or equal to 0.</data>
231231
</entity>
232-
<entity name="PageBuilderAdvancedBorderWidthProperty_11" type="pagebuilder_advanced_border_width_property">
233-
<data key="name">Border Width</data>
234-
<data key="section">advanced</data>
235-
<data key="fieldName">border_width</data>
236-
<data key="value">11</data>
237-
<data key="errorMessage">Please enter a value less than or equal to 10.</data>
238-
</entity>
239232
<!-- Border Radius -->
240233
<entity name="PageBuilderAdvancedBorderRadiusDefaultProperty" type="pagebuilder_advanced_border_radius_property">
241234
<data key="name">Border Radius</data>
@@ -283,13 +276,6 @@
283276
<data key="value">-1</data>
284277
<data key="errorMessage">Please enter a value greater than or equal to 0.</data>
285278
</entity>
286-
<entity name="PageBuilderAdvancedBorderRadiusProperty_51" type="pagebuilder_advanced_border_radius_property">
287-
<data key="name">Border Radius</data>
288-
<data key="section">advanced</data>
289-
<data key="fieldName">border_radius</data>
290-
<data key="value">51</data>
291-
<data key="errorMessage">Please enter a value less than or equal to 50.</data>
292-
</entity>
293279
<!-- CSS Classes -->
294280
<entity name="PageBuilderAdvancedCssClassesDefaultProperty" type="pagebuilder_advanced_css_classes_property">
295281
<data key="name">CSS Classes</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,17 +1154,6 @@
11541154
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidthNegative">
11551155
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
11561156
</actionGroup>
1157-
<!-- Add Invalid Border Width: 11 -->
1158-
<comment userInput="Add Border Width: 11" stepKey="commentAddBorderWidth11"/>
1159-
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enter11BorderWidth">
1160-
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_11"/>
1161-
</actionGroup>
1162-
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateError11">
1163-
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_11"/>
1164-
</actionGroup>
1165-
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidth11">
1166-
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1167-
</actionGroup>
11681157
<!-- User can recover after invalid input -->
11691158
<comment userInput="User can recover after invalid input" stepKey="commentCanRecover"/>
11701159
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderWidth2">
@@ -1441,17 +1430,6 @@
14411430
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderRadiusNegative">
14421431
<argument name="property" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
14431432
</actionGroup>
1444-
<!-- Add Invalid Border Radius: 51 -->
1445-
<comment userInput="Add Border Radius: 51" stepKey="commentAddBorderRadius51"/>
1446-
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enter51BorderRadius">
1447-
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_51"/>
1448-
</actionGroup>
1449-
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateError51">
1450-
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty_51"/>
1451-
</actionGroup>
1452-
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderRadius51">
1453-
<argument name="property" value="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
1454-
</actionGroup>
14551433
<!-- User can recover after invalid input -->
14561434
<comment userInput="User can recover after invalid input" stepKey="commentCanRecover"/>
14571435
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderRadius12">

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_base_form.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
</imports>
157157
<validation>
158158
<rule name="validate-number" xsi:type="boolean">true</rule>
159-
<rule name="less-than-equals-to" xsi:type="number">10</rule>
160159
<rule name="greater-than-equals-to" xsi:type="number">0</rule>
161160
</validation>
162161
</settings>
@@ -177,7 +176,6 @@
177176
<placeholder translate="true">Default</placeholder>
178177
<validation>
179178
<rule name="validate-number" xsi:type="boolean">true</rule>
180-
<rule name="less-than-equals-to" xsi:type="number">50</rule>
181179
<rule name="greater-than-equals-to" xsi:type="number">0</rule>
182180
</validation>
183181
</settings>

0 commit comments

Comments
 (0)