Skip to content

Commit e1eebd6

Browse files
committed
MC-4112: Tab Item Children Assumes Parent Minimum Height
- update MFTF test
1 parent c9ca243 commit e1eebd6

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemContentTests.xml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -977,8 +977,8 @@
977977
<stories value="Tabs"/>
978978
<title value="Tabs Content - Add Heading to Tabs container and verify minimum height on Admin and Storefront"/>
979979
<description value="As a Content Manager I want tab to be a container so that I can add any content inside the Tab, not only text"/>
980-
<severity value="CRITICAL"/>
981-
<useCaseId value="MC-964"/>
980+
<severity value="MAJOR"/>
981+
<useCaseId value="MC-4112"/>
982982
<testCaseId value="MC-4209"/>
983983
<group value="pagebuilder"/>
984984
<group value="pagebuilder-tabs-content"/>
@@ -1018,12 +1018,20 @@
10181018
<actionGroup ref="clickOutsideLiveEditHeading" stepKey="clickOutsideLiveEditHeading">
10191019
<argument name="index" value="1"/>
10201020
</actionGroup>
1021+
<!-- Verify Tab height on stage -->
1022+
<comment userInput="Verify Tab height on stage" stepKey="verifyTabOnStage"/>
10211023
<executeJS function="return {{TabOnStage.tabContentHeightJS('0')}}" stepKey="tabContentHeightStage"/>
1024+
<executeJS function="return {{PageBuilderTabMinimumHeightDefaultProperty.value}} + {{PageBuilderPaddingProperty40.paddingTop}} + {{PageBuilderPaddingProperty40.paddingBottom}}" stepKey="tabExpectedHeight"/>
1025+
<assertEquals stepKey="assertTabHeightStage">
1026+
<expectedResult type="variable">tabExpectedHeight</expectedResult>
1027+
<actualResult type="variable">tabContentHeightStage</actualResult>
1028+
</assertEquals>
10221029
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
10231030
<!-- Verify Tab height on storefront -->
10241031
<comment userInput="Verify Tab height on storefront" stepKey="viewTabOnStorefront"/>
1025-
<amOnPage url="tabs{{PageBuilderPageTitle.pageName}}" stepKey="amOnPageBuilderPage"/>
1026-
<waitForPageLoad stepKey="waitForStoreFrontPageLoad" time="30"/>
1032+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1033+
<argument name="contentType" value="PageBuilderTabsContentType"/>
1034+
</actionGroup>
10271035
<waitForElementVisible selector="{{TabOnStorefront.tabContent('1')}}" stepKey="waitForTabContentVisible"/>
10281036
<executeJS function="return {{TabsOnFrontend.tabsContentHeightJS('0')}}" stepKey="tabContentHeightStorefront"/>
10291037
<assertEquals stepKey="assertTabHeightStorefrontEqualsStage">

0 commit comments

Comments
 (0)