MC-3095: Display TypeScript errors within local build process

- Revert accidental change to suite.xml
- Resolve further TypeScript errors
- Add types for appearances config

Author: davemacaulay

app/code/Magento/PageBuilder/Test/Mftf/Suite/suite.xml

@@ -9,7 +9,7 @@
     <suite name="PageBuilderWithWYSIWYG">
         <before>
             <createData stepKey="enablePageBuilderAndWYSIWYG" entity="enablePageBuilderAndWYSIWYGForm"/>
-            <!--<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key AIzaSyCw10cOO31cpxb2bcwnHPHKtxov8oUbxJw" stepKey="setGoogleMapsAPIKey"/>-->
+            <magentoCLI command="config:set cms/pagebuilder/google_maps_api_key AIzaSyCw10cOO31cpxb2bcwnHPHKtxov8oUbxJw" stepKey="setGoogleMapsAPIKey"/>
         </before>
         <after>
             <createData stepKey="DisabledWYSIWYG" entity="disableWYSYWYGForm"/>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type-factory.js

@@ -5,7 +5,7 @@
 /**
  * @api
  */
-export interface ConfigFieldInterface {
+export default interface ConfigFieldInterface {
     [key: string]: {
         default: null | string | number;
     };

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type-toolbar.js

@@ -21,8 +21,75 @@ export default interface ContentTypeConfigInterface {
     preview_component: string;
     master_component: string;
     component: string;
-    appearances: string[];
+    appearances: {
+        [key: string]: ContentTypeConfigAppearanceInterface;
+    };
     readers: string[];
     allowed_parents: string[];
     is_visible: boolean;
 }
+
+export interface ContentTypeConfigAppearanceInterface {
+    readers: string[];
+    data_mapping: DataMappingInterface;
+    preview_template: string;
+    render_template: string;
+    render: string;
+    default: string;
+    form: string;
+}
+
+export interface DataMappingInterface {
+    path: string;
+    elements: {
+        [key: string]: {
+            style: DataMappingStyleInterface[];
+            attributes: DataMappingAttributesInterface[];
+            html: DataMappingHtmlInterface;
+            css: DataMappingCssInterface[];
+            tag: DataMappingTagInterface[];
+        };
+    };
+}
+
+export interface DataMappingStyleInterface {
+    var?: string;
+    name: string;
+    value?: string;
+    converter?: string;
+    preview_converter?: string;
+    virtual?: string;
+    persist?: string;
+    complex?: boolean;
+    static?: boolean;
+}
+
+export interface DataMappingAttributesInterface {
+    var?: string;
+    name: string;
+    reader?: string;
+    value?: string;
+    converter?: string;
+    preview_converter?: string;
+    virtual?: string;
+    persist?: string;
+    complex?: boolean;
+    static?: boolean;
+}
+
+export interface DataMappingHtmlInterface {
+    var: string;
+    converter: string;
+    preview_converter: string;
+}
+
+export interface DataMappingCssInterface {
+    var: string;
+    converter: string;
+    filter: string[];
+}
+
+export interface DataMappingTagInterface {
+    var: string;
+    converter: string;
+}

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/converter-pool-factory.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 
-import loadModule from "Magento_PageBuilder/js/loader";
+import loadModule from "Magento_PageBuilder/js/utils/loader";
 import events from "uiEvents";
 import _ from "underscore";
 import ConfigFieldInterface from "./config-field.d";