Skip to content

Commit ebb9b70

Browse files
committed
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Update BannerCollage*OverlayAndButtonOnHover tests to ensure inner/outer anchor navigation works
1 parent 70a2cb3 commit ebb9b70

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/LinkData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<data key="product">Product</data>
1414
<data key="category">Category</data>
1515
<data key="page">Page</data>
16-
<data key="googleUrl">https://www.google.com</data>
16+
<data key="googleUrl">https://www.google.com/</data>
1717
</entity>
1818
<entity name="ExternalLinkSearch" type="pagebuilder_external_link">
1919
<data key="page">cm</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -812,6 +812,15 @@
812812
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayTransparency">
813813
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
814814
</actionGroup>
815+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerLinkUrl">
816+
<argument name="property" value="PageBuilderBannerLinkUrlPropertyValidate"/>
817+
</actionGroup>
818+
<!-- Add Link To WYSIWYG -->
819+
<comment userInput="Add Link To WYSIWYG" stepKey="commentAddLink"/>
820+
<actionGroup ref="insertLinkInWYSIWYG" stepKey="insertLinkInWYSIWYG">
821+
<argument name="url" value="{{ExternalLink.googleUrl}}"/>
822+
<argument name="textToDisplay" value="{{ExternalLink.googleUrl}}"/>
823+
</actionGroup>
815824
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
816825
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
817826
<!-- Validate Stage -->
@@ -839,7 +848,24 @@
839848
<seeElement selector="{{BannerOnFrontend.button('1')}}" stepKey="seeButtonOnHoverStorefront"/>
840849
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
841850
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromBanner"/>
851+
<!-- Click banner anchor -->
852+
<comment userInput="Click banner anchor" stepKey="clickBannerAnchorStorefront" />
853+
<click selector="{{BannerOnFrontend.linkUrl('1', PageBuilderBannerLinkUrlPropertyValidate.value)}}" stepKey="clickLinkUrlStorefront"/>
854+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefront" />
855+
<seeCurrentUrlEquals url="{{PageBuilderBannerLinkUrlPropertyValidate.value}}" stepKey="seeThatUrlIsChangedToButtonUrlStorefront" />
856+
<!-- Click wysiwyg anchor -->
857+
<comment userInput="Click wysiwyg anchor" stepKey="clickWysiwygLinkAnchorStorefront" />
858+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront2">
859+
<argument name="contentType" value="PageBuilderBannerContentType"/>
860+
</actionGroup>
861+
<seeElement selector="{{BannerOnFrontend.wysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="seeWysiwygLinkUrlStorefront"/>
862+
<click selector="{{BannerOnFrontend.wysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="clickWysiwygLinkUrlStorefront"/>
863+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefront2" />
864+
<seeCurrentUrlEquals url="{{ExternalLink.googleUrl}}" stepKey="seeThatUrlIsChangedToWysiwygLinkUrlStorefront" />
842865
<!-- Validate Storefront Mobile -->
866+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront3">
867+
<argument name="contentType" value="PageBuilderBannerContentType"/>
868+
</actionGroup>
843869
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
844870
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
845871
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerAppearance_Poster.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
@@ -850,6 +876,20 @@
850876
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
851877
<seeElement selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="seeButtonOnHoverStorefrontMobile"/>
852878
<seeElement selector="{{BannerOnFrontend.mobileOverlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefrontMobile"/>
879+
<!-- Click banner anchor -->
880+
<comment userInput="Click mobile banner anchor" stepKey="clickMobileBannerAnchorStorefront" />
881+
<click selector="{{BannerOnFrontend.linkUrl('1', PageBuilderBannerLinkUrlPropertyValidate.value)}}" stepKey="clickLinkUrlStorefrontMobile"/>
882+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefrontMobile" />
883+
<seeCurrentUrlEquals url="{{PageBuilderBannerLinkUrlPropertyValidate.value}}" stepKey="seeThatUrlIsChangedToButtonUrlStorefrontMobile" />
884+
<!-- Click wysiwyg anchor -->
885+
<comment userInput="Click mobile wysiwyg anchor" stepKey="clickMobileWysiwygLinkAnchorStorefront" />
886+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront4">
887+
<argument name="contentType" value="PageBuilderBannerContentType"/>
888+
</actionGroup>
889+
<seeElement selector="{{BannerOnFrontend.mobileWysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="seeMobileWysiwygLinkUrlStorefront"/>
890+
<click selector="{{BannerOnFrontend.mobileWysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="clickMobileWysiwygLinkUrlStorefront"/>
891+
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurStorefrontMobile2" />
892+
<seeCurrentUrlEquals url="{{ExternalLink.googleUrl}}" stepKey="seeThatUrlIsChangedToMobileWysiwygLinkUrlStorefront" />
853893
</test>
854894
<test name="BannerPosterButtonsCanBeEditedInline">
855895
<annotations>

0 commit comments

Comments
 (0)