PB-108 static test fixes

Author: paras89

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column-group/grid-size.js

@@ -160,7 +160,7 @@ function redistributeColumnWidths(
     );
 
     columnGroup.getChildren()().forEach(
-        (columnLine: ContentTypeCollectionInterface<ColumnLinePreview>, index: number) => {
+        (columnLine: ContentTypeCollectionInterface<ColumnLinePreview>, columnLineIndex: number) => {
             let totalNewWidths = 0;
             let remainingWidth: number = 0;
             const numColumns = columnLine.getChildren()().length;
@@ -209,8 +209,8 @@ function redistributeColumnWidths(
                     remainingWidth += (existingWidth - parseFloat(newWidth));
 
                     /**
-                     * Determine if we have enough remaining width, and apply it to the current column, this results in a
-                     * subsequent column always receiving any additional width from the previous column
+                     * Determine if we have enough remaining width, and apply it to the current column, this results in
+                     * a subsequent column always receiving any additional width from the previous column
                      */
                     if (resizeUtils.getSmallestColumnWidth(newGridSize)
                         === resizeUtils.getAcceptedColumnWidth(remainingWidth.toString(), newGridSize)

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column-line/preview.js

@@ -360,8 +360,8 @@ export default class Preview extends PreviewCollection {
         }
 
         // Move the content type
-        if (this.columnLineDropPlaceholder.hasClass('active')
-            || this.columnLineBottomDropPlaceholder.hasClass('active')) {
+        if (this.columnLineDropPlaceholder.hasClass("active")
+            || this.columnLineBottomDropPlaceholder.hasClass("active")) {
             // if new column line placeholders are visible, add new column line and move column there
             createColumnLine(
                 this.contentType.parentContentType,
@@ -378,7 +378,7 @@ export default class Preview extends PreviewCollection {
 
             });
         } else  {
-            //@todo evaluate if this else is needed
+            // @todo evaluate if this else is needed
             moveContentType(column, movePosition.insertIndex, this.contentType);
             if (modifyOldNeighbour) {
                 updateColumnWidth(modifyOldNeighbour, oldNeighbourWidth);
@@ -491,14 +491,12 @@ export default class Preview extends PreviewCollection {
      */
     private handleMouseUp(): void {
 
-        let index = -1;
         const self = this;
         const dragColumn = getDragColumn();
         if ((this.columnLineDropPlaceholder.hasClass("active")
             || this.columnLineBottomDropPlaceholder.hasClass("active"))
         && !dragColumn) {
 
-
             createColumnLine(
                 this.contentType.parentContentType,
                 this.resizeUtils.getSmallestColumnWidth(),
@@ -1193,7 +1191,7 @@ export default class Preview extends PreviewCollection {
         const self = this;
         for (const child of this.contentType.parentContentType.children()) {
             index++;
-            if (child.id == self.contentType.id) {
+            if (child.id === self.contentType.id) {
                 break;
             }
         }
@@ -1204,28 +1202,25 @@ export default class Preview extends PreviewCollection {
         return index;
     }
 
-
     private isColumnBeingMovedToAnotherColumnLine(): boolean {
-        let column = getDragColumn();
+        const column = getDragColumn();
         if (!column) {
-            //if no move position, column is not being moved.
+            // if no move position, column is not being moved.
             return false;
         }
 
         if (column.parentContentType !== this.contentType) {
-            //if the parent content type is not same as this column line, column is being moved to new column line
+            // if the parent content type is not same as this column line, column is being moved to new column line
             return true;
         }
 
         if (column.parentContentType === this.contentType
-            && (this.columnLineDropPlaceholder.hasClass('active')
-                 || this.columnLineBottomDropPlaceholder.hasClass('active'))) {
-            //since new column line drop placeholder is visible, column move will introduce a new column line
+            && (this.columnLineDropPlaceholder.hasClass("active")
+                 || this.columnLineBottomDropPlaceholder.hasClass("active"))) {
+            // since new column line drop placeholder is visible, column move should introduce a new column line
             return true;
         }
 
         return false;
     }
-
-
 }