Skip to content

Commit eebe259

Browse files
author
Cari Spruiell
committed
MAGETWO-92703: Persist & validate grid size entry
- fix build failures
1 parent 5dfaa61 commit eebe259

File tree

4 files changed

+18
-2
lines changed

4 files changed

+18
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column/preview.js

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/column/preview.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,14 @@ export default class Preview extends PreviewCollection {
2828
public resizing: KnockoutObservable<boolean> = ko.observable(false);
2929
public element: JQuery;
3030

31+
/**
32+
* Fields that should not be considered when evaluating whether an object has been configured.
33+
*
34+
* @see {Preview.isConfigured}
35+
* @type {[string]}
36+
*/
37+
protected fieldsToIgnoreOnRemove: string[] = ["width"];
38+
3139
/**
3240
* @param {ContentTypeInterface} parent
3341
* @param {ContentTypeConfigInterface} config

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ export default class Preview extends PreviewCollection {
386386
let duplicatedTabIndex: number;
387387
events.on("tab-item:contentType:duplicate", (args: ContentTypeDuplicateEventParamsInterface) => {
388388
if (this.parent.id === args.duplicateContentType.parent.id) {
389-
const tabData = args.duplicateContentType.dataStore.get(args.duplicateContentType.id);
389+
const tabData = args.duplicateContentType.dataStore.get();
390390
args.duplicateContentType.dataStore.update(
391391
tabData.tab_name.toString() + " copy",
392392
"tab_name",

0 commit comments

Comments
 (0)