Skip to content

Commit f127cdb

Browse files
#514: User sees content snapshot on Category Page in Admin Panel
- remove redundant methods
1 parent 669e0ad commit f127cdb

File tree

2 files changed

+4
-28
lines changed

2 files changed

+4
-28
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/wysiwyg.js

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ define([
5757
initObservable: function () {
5858
this._super()
5959
.observe('isComponentInitialized visiblePageBuilder wysiwygConfigData loading transition ' +
60-
'transitionOut');
60+
'transitionOut overlayMouseover');
6161

6262
return this;
6363
},
@@ -100,10 +100,6 @@ define([
100100
selector: this.stageSelector
101101
}, this.disableDomObserver.bind(this));
102102

103-
if (!this.wysiwygConfigData()['pagebuilder_button']) {
104-
this.visiblePageBuilder(true);
105-
}
106-
107103
if (!this.wysiwygConfigData()['pagebuilder_button'] ||
108104
this.wysiwygConfigData()['pagebuilder_content_snapshot']) {
109105
this.visiblePageBuilder(true);
@@ -153,26 +149,6 @@ define([
153149
}
154150
},
155151

156-
/**
157-
* Overlay MouseOver
158-
*/
159-
onOverlayMouseOver: function () {
160-
if (!this.overlayMouseover && !$(this.overlaySelector).hasClass('_hover')) {
161-
$(this.overlaySelector).addClass('_hover');
162-
}
163-
this.overlayMouseover = true;
164-
},
165-
166-
/**
167-
* Overlay MouseOut
168-
*/
169-
onOverlayMouseOut: function () {
170-
if (this.overlayMouseover && $(this.overlaySelector).hasClass('_hover')) {
171-
$(this.overlaySelector).removeClass('_hover');
172-
}
173-
this.overlayMouseover = false;
174-
},
175-
176152
/**
177153
* Press Enter key on Overlay
178154
*/

app/code/Magento/PageBuilder/view/adminhtml/web/template/form/element/wysiwyg.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
class="action-default action"
1212
ko-disabled="disabled"
1313
click="pageBuilderEditButtonClick.bind($data)"
14-
event="{ mouseover: onOverlayMouseOver, mouseout: onOverlayMouseOut }, mouseoverBubble: false">
14+
event="{ mouseover: overlayMouseover.bind($data, true), mouseout: overlayMouseover.bind($data, false) }, mouseoverBubble: false">
1515
<span translate="pageBuilderEditButtonText" />
1616
</button>
1717
<if args="isComponentInitialized">
@@ -21,8 +21,8 @@
2121
<div if="wysiwygConfigData()['pagebuilder_content_snapshot']"
2222
class="pagebuilder-wysiwyg-overlay"
2323
click="pageBuilderEditButtonClick.bind($data)"
24-
css="'visible': !pageBuilder.isFullScreen()"
25-
event="{ mouseover: onOverlayMouseOver, mouseout: onOverlayMouseOut, keydown: onOverlayKeyDown }, mouseoverBubble: false"
24+
css="'visible': !pageBuilder.isFullScreen(), _hover: overlayMouseover"
25+
event="{ mouseover: overlayMouseover.bind($data, true), mouseout: overlayMouseover.bind($data, false), keydown: onOverlayKeyDown }, mouseoverBubble: false"
2626
tabindex="0">
2727
</div>
2828
<with args="pageBuilder">

0 commit comments

Comments
 (0)