Skip to content

Commit ff1171d

Browse files
danmooney2danmooney2
committed
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Extend BannerCollage*OverlayAndButtonOnHover on tests from BannerPosterOverlayAndButtonOnHover
1 parent 2059b9e commit ff1171d

File tree

3 files changed

+17
-275
lines changed

3 files changed

+17
-275
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 4 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@
549549
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStorefront"/>
550550
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
551551
</test>
552-
<test name="BannerCollageCenterOverlayAndButtonOnHover">
552+
<test name="BannerCollageCenterOverlayAndButtonOnHover" extends="BannerPosterOverlayAndButtonOnHover">
553553
<annotations>
554554
<features value="PageBuilder"/>
555555
<stories value="Banner"/>
@@ -562,85 +562,14 @@
562562
<group value="pagebuilder-banner"/>
563563
<group value="pagebuilder-bannerCollageCenter"/>
564564
</annotations>
565-
<before>
566-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
567-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
568-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
569-
</before>
570-
<after>
571-
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
572-
<actionGroup ref="logout" stepKey="logout"/>
573-
</after>
574-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
575-
<argument name="contentType" value="PageBuilderBannerContentType"/>
576-
</actionGroup>
577-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
578-
<argument name="group" value="PageBuilderBannerContentType"/>
579-
</actionGroup>
580-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
581-
<argument name="contentType" value="PageBuilderBannerContentType"/>
582-
</actionGroup>
583-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
584-
<argument name="contentType" value="PageBuilderBannerContentType"/>
585-
</actionGroup>
586-
<!-- Fill Out Edit Panel -->
587-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
588565
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
589566
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
590567
</actionGroup>
591-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
592-
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>
593-
</actionGroup>
594-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBannerButtonShowOnHover">
595-
<argument name="property" value="PageBuilderBannerShowButtonOnHoverProperty"/>
596-
</actionGroup>
597-
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBannerOverlayShowOnHover">
598-
<argument name="property" value="PageBuilderBannerShowContentOverlayOnHoverProperty"/>
599-
</actionGroup>
600-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayColor">
601-
<argument name="property" value="PageBuilderBannerContentOverlayColorProperty"/>
602-
</actionGroup>
603-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayTransparency">
604-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
605-
</actionGroup>
606-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
607-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
608-
<!-- Validate Stage -->
609-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
610-
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeCollageCenteredStage"/>
611-
<seeElement selector="{{BannerOnBackend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStage"/>
612-
<seeElementInDOM selector="{{BannerOnBackend.button('1')}}" stepKey="seeButtonInDOMStage"/>
613-
<dontSeeElement selector="{{BannerOnBackend.button('1')}}" stepKey="dontSeeButtonStage"/>
614-
<seeElement selector="{{BannerOnBackend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStage"/>
568+
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStage"/>
615569
<moveMouseOver selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="moveMouseOverBannerStage"/>
616-
<seeElement selector="{{BannerOnBackend.button('1')}}" stepKey="seeButtonOnHoverStage"/>
617-
<seeElement selector="{{BannerOnBackend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStage"/>
618-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
619-
<!-- Validate Storefront -->
620-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
621-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
622-
<argument name="contentType" value="PageBuilderBannerContentType"/>
623-
</actionGroup>
624-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeCollageCenteredStorefront"/>
625-
<seeElement selector="{{BannerOnFrontend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefront"/>
626-
<seeElementInDOM selector="{{BannerOnFrontend.button('1')}}" stepKey="seeButtonInDOMStorefront"/>
627-
<dontSeeElement selector="{{BannerOnFrontend.button('1')}}" stepKey="dontSeeButtonStorefront"/>
628-
<seeElement selector="{{BannerOnFrontend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefront"/>
629-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefront"/>
630-
<seeElement selector="{{BannerOnFrontend.button('1')}}" stepKey="seeButtonOnHoverStorefront"/>
631-
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
632-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromBanner"/>
633-
<!-- Validate Storefront Mobile -->
634-
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
635-
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
636-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeCollageCenteredStorefrontMobile"/>
637-
<seeElement selector="{{BannerOnFrontend.mobileBackgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefrontMobile"/>
638-
<seeElementInDOM selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="seeButtonInDOMStorefrontMobile"/>
570+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStorefront"/>
571+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageCenteredProperty.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
639572
<dontSeeElement selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="dontSeeButtonStorefrontMobile"/>
640-
<seeElement selector="{{BannerOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefrontMobile"/>
641-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
642-
<seeElement selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="seeButtonOnHoverStorefrontMobile"/>
643-
<seeElement selector="{{BannerOnFrontend.mobileOverlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefrontMobile"/>
644573
</test>
645574
<test name="BannerCollageCenterButtonsCanBeEditedInline">
646575
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 4 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@
549549
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStorefront"/>
550550
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
551551
</test>
552-
<test name="BannerCollageLeftOverlayAndButtonOnHover">
552+
<test name="BannerCollageLeftOverlayAndButtonOnHover" extends="BannerPosterOverlayAndButtonOnHover">
553553
<annotations>
554554
<features value="PageBuilder"/>
555555
<stories value="Banner"/>
@@ -562,85 +562,14 @@
562562
<group value="pagebuilder-banner"/>
563563
<group value="pagebuilder-bannerCollageLeft"/>
564564
</annotations>
565-
<before>
566-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
567-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
568-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
569-
</before>
570-
<after>
571-
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
572-
<actionGroup ref="logout" stepKey="logout"/>
573-
</after>
574-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
575-
<argument name="contentType" value="PageBuilderBannerContentType"/>
576-
</actionGroup>
577-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
578-
<argument name="group" value="PageBuilderBannerContentType"/>
579-
</actionGroup>
580-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
581-
<argument name="contentType" value="PageBuilderBannerContentType"/>
582-
</actionGroup>
583-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
584-
<argument name="contentType" value="PageBuilderBannerContentType"/>
585-
</actionGroup>
586-
<!-- Fill Out Edit Panel -->
587-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
588565
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
589566
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
590567
</actionGroup>
591-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
592-
<argument name="property" value="PageBuilderBackgroundColor_Plaintext_Green"/>
593-
</actionGroup>
594-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBannerButtonShowOnHover">
595-
<argument name="property" value="PageBuilderBannerShowButtonOnHoverProperty"/>
596-
</actionGroup>
597-
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBannerOverlayShowOnHover">
598-
<argument name="property" value="PageBuilderBannerShowContentOverlayOnHoverProperty"/>
599-
</actionGroup>
600-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayColor">
601-
<argument name="property" value="PageBuilderBannerContentOverlayColorProperty"/>
602-
</actionGroup>
603-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBannerOverlayTransparency">
604-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
605-
</actionGroup>
606-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
607-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
608-
<!-- Validate Stage -->
609-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
610-
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeCollageLeftStage"/>
611-
<seeElement selector="{{BannerOnBackend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStage"/>
612-
<seeElementInDOM selector="{{BannerOnBackend.button('1')}}" stepKey="seeButtonInDOMStage"/>
613-
<dontSeeElement selector="{{BannerOnBackend.button('1')}}" stepKey="dontSeeButtonStage"/>
614-
<seeElement selector="{{BannerOnBackend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStage"/>
568+
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStage"/>
615569
<moveMouseOver selector="{{BannerOnBackend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="moveMouseOverBannerStage"/>
616-
<seeElement selector="{{BannerOnBackend.button('1')}}" stepKey="seeButtonOnHoverStage"/>
617-
<seeElement selector="{{BannerOnBackend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStage"/>
618-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
619-
<!-- Validate Storefront -->
620-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
621-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
622-
<argument name="contentType" value="PageBuilderBannerContentType"/>
623-
</actionGroup>
624-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeCollageLeftStorefront"/>
625-
<seeElement selector="{{BannerOnFrontend.backgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefront"/>
626-
<seeElementInDOM selector="{{BannerOnFrontend.button('1')}}" stepKey="seeButtonInDOMStorefront"/>
627-
<dontSeeElement selector="{{BannerOnFrontend.button('1')}}" stepKey="dontSeeButtonStorefront"/>
628-
<seeElement selector="{{BannerOnFrontend.transparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefront"/>
629-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefront"/>
630-
<seeElement selector="{{BannerOnFrontend.button('1')}}" stepKey="seeButtonOnHoverStorefront"/>
631-
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefront"/>
632-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" x="-1" y="0" stepKey="moveMouseAwayFromBanner"/>
633-
<!-- Validate Storefront Mobile -->
634-
<comment userInput="Validate Storefront Mobile" stepKey="commentValidateStorefrontMobile"/>
635-
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
636-
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeCollageLeftStorefrontMobile"/>
637-
<seeElement selector="{{BannerOnFrontend.mobileBackgroundColor('1', PageBuilderBackgroundColor_Plaintext_Green.rgb)}}" stepKey="seeBackgroundColorStorefrontMobile"/>
638-
<seeElementInDOM selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="seeButtonInDOMStorefrontMobile"/>
570+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStorefront"/>
571+
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderBannerCollageLeftProperty.value)}}" stepKey="seeAppearanceStorefrontMobile"/>
639572
<dontSeeElement selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="dontSeeButtonStorefrontMobile"/>
640-
<seeElement selector="{{BannerOnFrontend.mobileTransparentOverlay('1')}}" stepKey="seeTransparentOverlayStorefrontMobile"/>
641-
<moveMouseOver selector="{{BannerOnFrontend.base('1')}}" stepKey="moveMouseOverBannerStorefrontMobile"/>
642-
<seeElement selector="{{BannerOnFrontend.mobileButton('1')}}" stepKey="seeButtonOnHoverStorefrontMobile"/>
643-
<seeElement selector="{{BannerOnFrontend.mobileOverlayColorAndTransparency('1', PageBuilderBannerContentOverlayColorProperty.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayOnHoverStorefrontMobile"/>
644573
</test>
645574
<test name="BannerCollageLeftButtonsCanBeEditedInline">
646575
<annotations>

0 commit comments

Comments
 (0)