Skip to content

Commit 0c77bf2

Browse files
Removed redundant method
1 parent 74f2774 commit 0c77bf2

File tree

1 file changed

+14
-27
lines changed

1 file changed

+14
-27
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/AbstractDialog.java

Lines changed: 14 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,20 @@ protected void clearValidationHighlighting() {
119119
* @return List[FieldValidationData]
120120
*/
121121
protected List<FieldValidationData> getFieldsToValidate() {
122-
return getAvailableForFiltering(fieldsValidationsList);
122+
final List<FieldValidationData> result = new LinkedList<>();
123+
124+
for (final FieldValidationData fieldValidationData : fieldsValidationsList) {
125+
final JComponent component = ExtractComponentFromFieldUtil.extract(
126+
fieldValidationData.getField(),
127+
this
128+
);
129+
130+
if (component != null && component.isVisible() && component.getParent().isVisible()) {
131+
result.add(fieldValidationData);
132+
}
133+
}
134+
135+
return result;
123136
}
124137

125138
/**
@@ -235,30 +248,4 @@ private int getParentTabPaneForComponent(final @NotNull Container component) {
235248

236249
return getParentTabPaneForComponent(parent);
237250
}
238-
239-
/**
240-
* Returns only available for validation field.
241-
*
242-
* @param allFields List
243-
*
244-
* @return List
245-
*/
246-
private List<FieldValidationData> getAvailableForFiltering(
247-
final @NotNull List<FieldValidationData> allFields
248-
) {
249-
final List<FieldValidationData> result = new LinkedList<>();
250-
251-
for (final FieldValidationData fieldValidationData : allFields) {
252-
final JComponent component = ExtractComponentFromFieldUtil.extract(
253-
fieldValidationData.getField(),
254-
this
255-
);
256-
257-
if (component != null && component.isVisible() && component.getParent().isVisible()) {
258-
result.add(fieldValidationData);
259-
}
260-
}
261-
262-
return result;
263-
}
264251
}

0 commit comments

Comments
 (0)