Added usage of translation bundle for warning messages

Author: Vasilii Burlacu

resources/magento2/inspection.properties

@@ -0,0 +1,2 @@
+inspection.plugin.duplicateInSameFile=The plugin name already used in this file. For more details see Inspection Description.
+inspection.plugin.duplicateInOtherPlaces=The plugin name "{0}" for targeted "{1}" class is already used in the module "{2}" ({3} scope). For more details see Inspection Description.

src/com/magento/idea/magento2plugin/bundles/InspectionBundle.java

@@ -0,0 +1,14 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+package com.magento.idea.magento2plugin.bundles;
+
+public class InspectionBundle extends AbstractBundle {
+    protected final String BUNDLE_NAME = "magento2.inspection";
+
+    public String getBundleName() {
+        return BUNDLE_NAME;
+    }
+}

src/com/magento/idea/magento2plugin/indexes/PluginIndex.java

@@ -12,6 +12,7 @@
 import com.intellij.psi.xml.XmlAttributeValue;
 import com.intellij.psi.xml.XmlFile;
 import com.intellij.util.indexing.FileBasedIndex;
+import com.magento.idea.magento2plugin.magento.files.ModuleDiXml;
 import com.magento.idea.magento2plugin.xml.XmlPsiTreeUtil;
 
 import java.util.ArrayList;
@@ -48,7 +49,7 @@ public Collection<PsiElement> getPluginElements(final String name, final GlobalS
         for (VirtualFile virtualFile : virtualFiles) {
             XmlFile xmlFile = (XmlFile) PsiManager.getInstance(project).findFile(virtualFile);
             Collection<XmlAttributeValue> valueElements = XmlPsiTreeUtil
-                    .findAttributeValueElements(xmlFile, "type", "name", name);
+                    .findAttributeValueElements(xmlFile, ModuleDiXml.PLUGIN_TYPE_ATTRIBUTE, ModuleDiXml.PLUGIN_TYPE_ATTR_NAME, name);
             result.addAll(valueElements);
         }
         return result;

src/com/magento/idea/magento2plugin/inspections/xml/PluginDeclarationInspection.java

@@ -18,13 +18,13 @@
 import com.intellij.psi.xml.XmlDocument;
 import com.intellij.psi.xml.XmlTag;
 import com.jetbrains.php.lang.inspections.PhpInspection;
+import com.magento.idea.magento2plugin.bundles.InspectionBundle;
 import com.magento.idea.magento2plugin.indexes.PluginIndex;
 import com.magento.idea.magento2plugin.magento.files.ModuleDiXml;
 import com.magento.idea.magento2plugin.magento.files.ModuleXml;
 import com.magento.idea.magento2plugin.magento.packages.Package;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
-
 import java.io.File;
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -37,9 +37,7 @@ public class PluginDeclarationInspection extends PhpInspection {
     public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder problemsHolder, boolean b) {
         return new XmlElementVisitor() {
             private final String moduleXmlFileName = ModuleXml.getInstance().getFileName();
-            private static final String duplicatedPluginNameSameFileProblemDescription = "The plugin name already used in this file. For more details see Inspection Description.";
-            private static final String duplicatedPluginNameProblemDescription =
-                    "The plugin name \"%s\" for targeted \"%s\" class is already used in the module \"%s\" (%s scope). For more details see Inspection Description.";
+            private InspectionBundle inspectionBundle = new InspectionBundle();
             private HashMap<String, VirtualFile> loadedFileHash = new HashMap<>();
             private final ProblemHighlightType errorSeverity = ProblemHighlightType.WARNING;
 
@@ -86,7 +84,7 @@ public void visitFile(PsiFile file) {
                         if (targetPluginHash.containsKey(pluginTypeKey)) {
                             problemsHolder.registerProblem(
                                 pluginTypeNameAttribute.getValueElement(),
-                                duplicatedPluginNameSameFileProblemDescription,
+                                inspectionBundle.message("inspection.plugin.duplicateInSameFile"),
                                 errorSeverity
                             );
                         }
@@ -101,8 +99,8 @@ public void visitFile(PsiFile file) {
                             if (!pluginProblems.containsKey(problemKey)){
                                 problemsHolder.registerProblem(
                                     pluginTypeNameAttribute.getValueElement(),
-                                    String.format(
-                                        duplicatedPluginNameProblemDescription,
+                                    inspectionBundle.message(
+                                        "inspection.plugin.duplicateInOtherPlaces",
                                         pluginTypeName,
                                         pluginNameAttributeValue,
                                         moduleName,