Skip to content

Commit 14456ab

Browse files
committed
2491: Refactor mouse click handling for safer resource usage.
Moved PsiManager and MagentoComponentManager initialization into the runnable to delay their usage until the appropriate execution context. Added a suppression for PMD warning to ensure clarity and maintain compatibility with standards.
1 parent 283f312 commit 14456ab

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/main/java/com/magento/idea/magento2plugin/project/RegenerateUrnMapListener.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,8 @@ public RegenerateUrnMapListener(final @NotNull Project project) {
4747
* @param event MouseEvent
4848
*/
4949
@Override
50+
@SuppressWarnings("PMD.UseNotifyAllInsteadOfNotify")
5051
public void mouseClicked(final MouseEvent event) {
51-
final PsiManager psiManager = PsiManager.getInstance(project);
52-
final MagentoComponentManager componentManager =
53-
MagentoComponentManager.getInstance(project);
54-
5552
if (DumbService.getInstance(project).isDumb()) {
5653
NotificationGroupManager.getInstance()
5754
.getNotificationGroup("Magento Notifications")
@@ -70,6 +67,9 @@ public void mouseClicked(final MouseEvent event) {
7067
new Runnable() {
7168
@Override
7269
public void run() {
70+
final PsiManager psiManager = PsiManager.getInstance(project);
71+
final MagentoComponentManager componentManager =
72+
MagentoComponentManager.getInstance(project);
7373
final ExternalResourceManager manager =
7474
ExternalResourceManager.getInstance();
7575
final Collection<VirtualFile> xsdFiles

0 commit comments

Comments
 (0)