Merge pull request #205 from mmezhensky/issue-131-di-type-name-test-coverage

Test coverage for type name attribute completion, linemarker and reference in the di.xml

Author: Vitaliy

testData/completion/xml/ConfigurationTypeCompletionRegistrar/diXmlTypeNameMustHaveCompletion/di.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+<config>
+    <type name="YesNo<caret>">
+    </type>
+</config>

testData/linemarker/php/ConfigurationTypeClassLinemarkerRegistrar/regularPhpClassShouldNotHaveLinemarker/ClassNotConfiguredInDiXml.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Model;
+
+class ClassNotConfiguredInDiXml
+{
+    public function someMethod()
+    {
+    }
+}

testData/linemarker/php/ConfigurationTypeClassLinemarkerRegistrar/typeNameClassShouldHaveLinemarker/Topmenu.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Theme\Block\Html;
+
+class Topmenu extends \Magento\Framework\View\Element\Template implements \Magento\Framework\DataObject\IdentityInterface
+{
+    public function someMethod()
+    {
+    }
+}

testData/reference/xml/ConfigurationTypeReferenceRegistrar/diXmlTypeNameMustHaveReference/di.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+<config>
+    <type name="Magento\Backend\Model\Source\YesNo<caret>">
+    </type>
+</config>

tests/com/magento/idea/magento2plugin/completion/xml/ConfigurationTypeCompletionRegistrarTest.java

@@ -0,0 +1,21 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+package com.magento.idea.magento2plugin.completion.xml;
+
+import com.magento.idea.magento2plugin.magento.files.ModuleDiXml;
+
+public class ConfigurationTypeCompletionRegistrarTest extends CompletionXmlFixtureTestCase {
+
+    private static final String[] lookupStringsTypeName = new String[] {
+        "Magento\\Backend\\Model\\Source\\YesNo"
+      };
+
+    public void testDiXmlTypeNameMustHaveCompletion() {
+        String filePath = this.getFixturePath(ModuleDiXml.FILE_NAME);
+        myFixture.copyFileToProject(filePath);
+
+        assertFileContainsCompletions(filePath, lookupStringsTypeName);
+    }
+}

tests/com/magento/idea/magento2plugin/linemarker/php/ConfigurationTypeClassLinemarkerRegistrarTest.java

@@ -0,0 +1,22 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+package com.magento.idea.magento2plugin.linemarker.php;
+
+public class ConfigurationTypeClassLinemarkerRegistrarTest extends LinemarkerPhpFixtureTestCase {
+
+    public void testTypeNameClassShouldHaveLinemarker() {
+        String filePath = this.getFixturePath("Topmenu.php");
+        myFixture.configureByFile(filePath);
+
+        assertHasLinemarkerWithTooltipAndIcon("Navigate to configuration", "/fileTypes/xml.svg");
+    }
+
+    public void testRegularPhpClassShouldNotHaveLinemarker() {
+        String filePath = this.getFixturePath("ClassNotConfiguredInDiXml.php");
+        myFixture.configureByFile(filePath);
+
+        assertHasNoLinemarkerWithTooltipAndIcon("Navigate to configuration", "/fileTypes/xml.svg");
+    }
+}

tests/com/magento/idea/magento2plugin/reference/xml/ConfigurationTypeReferenceRegistrarTest.java

@@ -0,0 +1,17 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+package com.magento.idea.magento2plugin.reference.xml;
+
+import com.magento.idea.magento2plugin.magento.files.ModuleDiXml;
+
+public class ConfigurationTypeReferenceRegistrarTest extends ReferenceXmlFixtureTestCase {
+
+    public void testDiXmlTypeNameMustHaveReference() {
+        String filePath = this.getFixturePath(ModuleDiXml.FILE_NAME);
+        myFixture.configureByFile(filePath);
+
+        assertHasReferencePhpClass("Magento\\Backend\\Model\\Source\\YesNo");
+    }
+}