Skip to content

Commit 22c01a1

Browse files
committed
fixed code after review
1 parent 758d6a2 commit 22c01a1

File tree

7 files changed

+5
-5
lines changed

7 files changed

+5
-5
lines changed

resources/META-INF/plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@
234234
bundle="magento2.inspection" key="inspection.displayName.PluginAttrTypeInspection"
235235
groupBundle="magento2.inspection" groupKey="inspection.group.name"
236236
enabledByDefault="true" level="WARNING"
237-
implementationClass="com.magento.idea.magento2plugin.inspections.xml.PluginAttrTypeInspection"/>
237+
implementationClass="com.magento.idea.magento2plugin.inspections.xml.PluginAttributeTypeInspection"/>
238238

239239
<internalFileTemplate name="Magento Composer JSON"/>
240240
<internalFileTemplate name="Magento Registration PHP"/>

src/com/magento/idea/magento2plugin/inspections/xml/PluginAttrTypeInspection.java renamed to src/com/magento/idea/magento2plugin/inspections/xml/PluginAttributeTypeInspection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.magento.idea.magento2plugin.magento.files.ModuleDiXml;
2222
import org.jetbrains.annotations.NotNull;
2323

24-
public class PluginAttrTypeInspection extends XmlSuppressableInspectionTool {
24+
public class PluginAttributeTypeInspection extends XmlSuppressableInspectionTool {
2525

2626
@Override
2727
public @NotNull

tests/com/magento/idea/magento2plugin/inspections/xml/PluginAttrTypeInspectionTest.java renamed to tests/com/magento/idea/magento2plugin/inspections/xml/PluginAttributeTypeInspectionTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import com.magento.idea.magento2plugin.magento.files.ModuleDiXml;
99

10-
public class PluginAttrTypeInspectionTest extends InspectionXmlFixtureTestCase {
10+
public class PluginAttributeTypeInspectionTest extends InspectionXmlFixtureTestCase {
1111

1212
private static final String ARGUMENT_VALUE_IS_EMPTY =
1313
"inspection.error.idAttributeCanNotBeEmpty";
@@ -21,7 +21,7 @@ public class PluginAttrTypeInspectionTest extends InspectionXmlFixtureTestCase {
2121
@Override
2222
public void setUp() throws Exception {
2323
super.setUp();
24-
myFixture.enableInspections(PluginAttrTypeInspection.class);
24+
myFixture.enableInspections(PluginAttributeTypeInspection.class);
2525
}
2626

2727
/**
@@ -40,7 +40,7 @@ public void testAttrArgTypeValueIsEmpty() {
4040
}
4141

4242
/**
43-
* Test for an no error for the "type" attribute because this class exists.
43+
* Test for no error for the "type" attribute because this class exists.
4444
* <plugin name="unique_plugin_name" type="Magento\Catalog\Plugin\PluginClass" />
4545
*/
4646
public void testAttrTypeClassExists() {

0 commit comments

Comments
 (0)