Skip to content

Commit 261748e

Browse files
committed
Merge branch 'mainline-entity-manager' of github.com:magento/magento2-phpstorm-plugin into entity-creator-fields-validation
2 parents 603ceb3 + 9868a52 commit 261748e

File tree

56 files changed

+872
-973
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+872
-973
lines changed

CHANGELOG.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,45 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
66

77
## 3.2.0
88

9+
### Added
10+
11+
- Code generation for a Magento Entity in [#521](https://github.com/magento/magento2-phpstorm-plugin/pull/521)
12+
- Code generation for email templates in [#350](https://github.com/magento/magento2-phpstorm-plugin/pull/350)
13+
- Reference navigation for disabled observers in `events.xml` in [#439](https://github.com/magento/magento2-phpstorm-plugin/pull/439)
14+
- Line markers for test fixtures in [#477](https://github.com/magento/magento2-phpstorm-plugin/pull/477)
15+
16+
### Changed
17+
18+
- Added ability to set the module sequence at generating new module [#266](https://github.com/magento/magento2-phpstorm-plugin/pull/266)
19+
20+
### Fixed
21+
22+
- ArrayIndexOutOfBoundsException in the New Module Action in [#519](https://github.com/magento/magento2-phpstorm-plugin/pull/519)
23+
24+
## 3.1.3
25+
26+
### Changed
27+
28+
- Require restart on plugin update due to using native libraries
29+
30+
### Fixed
31+
32+
- Class completion doesn't display interfaces
33+
- Fixed invalid check 'setup_version' in the etc/module.xml
34+
35+
## 3.1.2
36+
37+
### Fixed
38+
39+
- Reference navigation for classes under directories with underscores
40+
- Fixed the array access exception when using copy path action
41+
42+
## 3.1.1
43+
44+
### Fixed
45+
46+
- Fixed null pointer exception on the copy path action
47+
948
## 3.1.0
1049

1150
### Added

src/com/magento/idea/magento2plugin/actions/generation/data/DeleteEntityByIdCommandData.java

Lines changed: 19 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -8,41 +8,34 @@
88
import org.jetbrains.annotations.NotNull;
99

1010
public class DeleteEntityByIdCommandData {
11+
1112
private final String moduleName;
1213
private final String entityName;
13-
private final String namespace;
14-
private final String classFqn;
15-
private final String modelClassFqn;
16-
private final String resourceModelClassFqn;
1714
private final String entityId;
15+
private final String modelName;
16+
private final String resourceModelName;
1817

1918
/**
2019
* Delete Command DTO Constructor.
2120
*
2221
* @param moduleName String
2322
* @param entityName String
24-
* @param namespace String
25-
* @param classFqn String
26-
* @param modelClassFqn String
27-
* @param resourceModelClassFqn String
2823
* @param entityId String
24+
* @param modelName String
25+
* @param resourceModelName String
2926
*/
3027
public DeleteEntityByIdCommandData(
3128
final @NotNull String moduleName,
3229
final @NotNull String entityName,
33-
final @NotNull String namespace,
34-
final @NotNull String classFqn,
35-
final @NotNull String modelClassFqn,
36-
final @NotNull String resourceModelClassFqn,
37-
final @NotNull String entityId
30+
final @NotNull String entityId,
31+
final @NotNull String modelName,
32+
final @NotNull String resourceModelName
3833
) {
3934
this.moduleName = moduleName;
4035
this.entityName = entityName;
41-
this.namespace = namespace;
42-
this.classFqn = classFqn;
43-
this.modelClassFqn = modelClassFqn;
44-
this.resourceModelClassFqn = resourceModelClassFqn;
4536
this.entityId = entityId;
37+
this.modelName = modelName;
38+
this.resourceModelName = resourceModelName;
4639
}
4740

4841
/**
@@ -64,47 +57,29 @@ public String getEntityName() {
6457
}
6558

6659
/**
67-
* Get namespace.
68-
*
69-
* @return String
70-
*/
71-
public String getNamespace() {
72-
return namespace;
73-
}
74-
75-
/**
76-
* Get class FQN.
77-
*
78-
* @return String
79-
*/
80-
public String getClassFqn() {
81-
return classFqn;
82-
}
83-
84-
/**
85-
* Get entity model class FQN.
60+
* Get entity Id.
8661
*
8762
* @return String
8863
*/
89-
public String getModelClassFqn() {
90-
return modelClassFqn;
64+
public String getEntityId() {
65+
return entityId;
9166
}
9267

9368
/**
94-
* Get entity resource model class FQN.
69+
* Get model name.
9570
*
9671
* @return String
9772
*/
98-
public String getResourceModelClassFqn() {
99-
return resourceModelClassFqn;
73+
public String getModelName() {
74+
return modelName;
10075
}
10176

10277
/**
103-
* Get entity Id.
78+
* Get resource model name.
10479
*
10580
* @return String
10681
*/
107-
public String getEntityId() {
108-
return entityId;
82+
public String getResourceModelName() {
83+
return resourceModelName;
10984
}
11085
}

src/com/magento/idea/magento2plugin/actions/generation/data/DeleteEntityControllerFileData.java

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ public class DeleteEntityControllerFileData {
1111

1212
private final String entityName;
1313
private final String moduleName;
14-
private final String namespace;
15-
private final String deleteCommandFqn;
1614
private final String acl;
1715
private final String entityId;
1816

@@ -21,22 +19,17 @@ public class DeleteEntityControllerFileData {
2119
*
2220
* @param entityName String
2321
* @param moduleName String
24-
* @param namespace String
2522
* @param acl String
2623
* @param entityId String
2724
*/
2825
public DeleteEntityControllerFileData(
2926
final @NotNull String entityName,
3027
final @NotNull String moduleName,
31-
final @NotNull String namespace,
32-
final @NotNull String deleteCommandFqn,
3328
final @NotNull String acl,
3429
final @NotNull String entityId
3530
) {
3631
this.entityName = entityName;
3732
this.moduleName = moduleName;
38-
this.namespace = namespace;
39-
this.deleteCommandFqn = deleteCommandFqn;
4033
this.acl = acl;
4134
this.entityId = entityId;
4235
}
@@ -59,24 +52,6 @@ public String getModuleName() {
5952
return moduleName;
6053
}
6154

62-
/**
63-
* Get namespace.
64-
*
65-
* @return String
66-
*/
67-
public String getNamespace() {
68-
return namespace;
69-
}
70-
71-
/**
72-
* Get delete command Fqn.
73-
*
74-
* @return String
75-
*/
76-
public String getDeleteCommandFqn() {
77-
return deleteCommandFqn;
78-
}
79-
8055
/**
8156
* Get acl.
8257
*

src/com/magento/idea/magento2plugin/actions/generation/data/EditEntityActionData.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ public class EditEntityActionData {
1111

1212
private final String entityName;
1313
private final String moduleName;
14-
private final String classFqn;
15-
private final String namespace;
1614
private final String acl;
1715
private final String menuIdentifier;
1816

@@ -21,23 +19,17 @@ public class EditEntityActionData {
2119
*
2220
* @param entityName String
2321
* @param moduleName String
24-
* @param classFqn String
25-
* @param namespace String
2622
* @param acl String
2723
* @param menuIdentifier String
2824
*/
2925
public EditEntityActionData(
3026
final @NotNull String entityName,
3127
final @NotNull String moduleName,
32-
final @NotNull String classFqn,
33-
final @NotNull String namespace,
3428
final @NotNull String acl,
3529
final @NotNull String menuIdentifier
3630
) {
3731
this.entityName = entityName;
3832
this.moduleName = moduleName;
39-
this.classFqn = classFqn;
40-
this.namespace = namespace;
4133
this.acl = acl;
4234
this.menuIdentifier = menuIdentifier;
4335
}
@@ -60,24 +52,6 @@ public String getModuleName() {
6052
return moduleName;
6153
}
6254

63-
/**
64-
* Get class FQN.
65-
*
66-
* @return String
67-
*/
68-
public String getClassFqn() {
69-
return classFqn;
70-
}
71-
72-
/**
73-
* Get namespace.
74-
*
75-
* @return String
76-
*/
77-
public String getNamespace() {
78-
return namespace;
79-
}
80-
8155
/**
8256
* Get acl.
8357
*

src/com/magento/idea/magento2plugin/actions/generation/data/FormGenericButtonBlockData.java

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,22 @@ public class FormGenericButtonBlockData {
1212
private final String moduleName;
1313
private final String entityName;
1414
private final String entityId;
15-
private final String classFqn;
16-
private final String namespace;
1715

1816
/**
1917
* Generic button DTO constructor.
2018
*
2119
* @param moduleName String
2220
* @param entityName String
2321
* @param entityId String
24-
* @param classFqn String
25-
* @param namespace String
2622
*/
2723
public FormGenericButtonBlockData(
2824
final @NotNull String moduleName,
2925
final @NotNull String entityName,
30-
final @NotNull String entityId,
31-
final @NotNull String classFqn,
32-
final @NotNull String namespace
26+
final @NotNull String entityId
3327
) {
3428
this.moduleName = moduleName;
3529
this.entityName = entityName;
3630
this.entityId = entityId;
37-
this.classFqn = classFqn;
38-
this.namespace = namespace;
3931
}
4032

4133
/**
@@ -64,22 +56,4 @@ public String getEntityName() {
6456
public String getEntityId() {
6557
return entityId;
6658
}
67-
68-
/**
69-
* Get class FQN.
70-
*
71-
* @return String
72-
*/
73-
public String getClassFqn() {
74-
return classFqn;
75-
}
76-
77-
/**
78-
* Get namespace.
79-
*
80-
* @return String
81-
*/
82-
public String getNamespace() {
83-
return namespace;
84-
}
8559
}

0 commit comments

Comments
 (0)