Skip to content

Commit 26504ab

Browse files
committed
Fixed PHP class validation rule
1 parent 8f3f516 commit 26504ab

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewControllerDialog.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,8 @@
1212
import com.magento.idea.magento2plugin.actions.generation.data.ControllerFileData;
1313
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.FieldValidation;
1414
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.RuleRegistry;
15-
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.AlphanumericRule;
1615
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NotEmptyRule;
1716
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.PhpClassRule;
18-
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.PhpNamespaceNameRule;
19-
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.StartWithNumberOrCapitalLetterRule;
2017
import com.magento.idea.magento2plugin.actions.generation.generator.ModuleControllerClassGenerator;
2118
import com.magento.idea.magento2plugin.magento.files.ControllerBackendPhp;
2219
import com.magento.idea.magento2plugin.magento.files.ControllerFrontendPhp;
@@ -63,16 +60,12 @@ public class NewControllerDialog extends AbstractDialog {
6360

6461
@FieldValidation(rule = RuleRegistry.NOT_EMPTY,
6562
message = {NotEmptyRule.MESSAGE, CONTROLLER_NAME})
66-
@FieldValidation(rule = RuleRegistry.PHP_NAMESPACE_NAME,
67-
message = {PhpNamespaceNameRule.MESSAGE, CONTROLLER_NAME})
63+
@FieldValidation(rule = RuleRegistry.PHP_CLASS,
64+
message = {PhpClassRule.MESSAGE, CONTROLLER_NAME})
6865
private JTextField controllerName;
6966

7067
@FieldValidation(rule = RuleRegistry.NOT_EMPTY,
7168
message = {NotEmptyRule.MESSAGE, ACTION_NAME})
72-
@FieldValidation(rule = RuleRegistry.START_WITH_NUMBER_OR_CAPITAL_LETTER,
73-
message = {StartWithNumberOrCapitalLetterRule.MESSAGE, ACTION_NAME})
74-
@FieldValidation(rule = RuleRegistry.ALPHANUMERIC,
75-
message = {AlphanumericRule.MESSAGE, ACTION_NAME})
7669
@FieldValidation(rule = RuleRegistry.PHP_CLASS,
7770
message = {PhpClassRule.MESSAGE, ACTION_NAME})
7871
private JTextField actionName;

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/rule/PhpClassRule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
package com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule;
77

8-
import com.jetbrains.php.refactoring.PhpNameUtil;
8+
import com.magento.idea.magento2plugin.util.RegExUtil;
99

1010
public class PhpClassRule implements ValidationRule {
1111
public static final String MESSAGE = "validator.class.isNotValid";
1212
private static final ValidationRule INSTANCE = new PhpClassRule();
1313

1414
@Override
1515
public boolean check(final String value) {
16-
return PhpNameUtil.isValidClassName(value);
16+
return value.matches(RegExUtil.Magento.PHP_CLASS);
1717
}
1818

1919
public static ValidationRule getInstance() {

src/com/magento/idea/magento2plugin/util/RegExUtil.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ public class RegExUtil {
3232
= "(\\d+)\\.(\\d+)\\.(\\d+)[a-zA-Z0-9_\\-]*";
3333

3434
public static class Magento {
35+
public static final String PHP_CLASS
36+
= "[A-Z][a-zA-Z0-9]+";
37+
3538
public static final String MODULE_NAME
3639
= "[A-Z][a-zA-Z0-9]+_[A-Z][a-zA-Z0-9]+";
3740

0 commit comments

Comments
 (0)