Skip to content

Commit 27aea9b

Browse files
author
Roman Glushko
committed
#184 Fixing checkstyle violations
1 parent 255d0f0 commit 27aea9b

File tree

1 file changed

+29
-7
lines changed

1 file changed

+29
-7
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAnObserverDialog.java

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
* Copyright © Magento, Inc. All rights reserved.
33
* See COPYING.txt for license details.
44
*/
5+
56
package com.magento.idea.magento2plugin.actions.generation.dialog;
67

78
import com.intellij.openapi.project.Project;
@@ -18,8 +19,16 @@
1819
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
1920
import org.jetbrains.annotations.NotNull;
2021

21-
import javax.swing.*;
22-
import java.awt.event.*;
22+
import javax.swing.JButton;
23+
import javax.swing.JComboBox;
24+
import javax.swing.JComponent;
25+
import javax.swing.JLabel;
26+
import javax.swing.JPanel;
27+
import javax.swing.JTextField;
28+
import javax.swing.KeyStroke;
29+
import java.awt.event.KeyEvent;
30+
import java.awt.event.WindowAdapter;
31+
import java.awt.event.WindowEvent;
2332
import java.util.List;
2433

2534
public class CreateAnObserverDialog extends AbstractDialog {
@@ -62,26 +71,38 @@ public void windowClosing(WindowEvent e) {
6271
}
6372
});
6473

65-
contentPane.registerKeyboardAction(new ActionListener() {
66-
public void actionPerformed(ActionEvent e) {
67-
onCancel();
68-
}
69-
}, KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0), JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT);
74+
contentPane.registerKeyboardAction(
75+
e -> onCancel(),
76+
KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0),
77+
JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT
78+
);
7079
}
7180

81+
/**
82+
* Open an action dialog
83+
*
84+
* @param project
85+
* @param targetEvent
86+
*/
7287
public static void open(@NotNull Project project, String targetEvent) {
7388
CreateAnObserverDialog dialog = new CreateAnObserverDialog(project, targetEvent);
7489
dialog.pack();
7590
dialog.centerDialog(dialog);
7691
dialog.setVisible(true);
7792
}
7893

94+
/**
95+
* Setup observer area combobox
96+
*/
7997
private void fillTargetAreaOptions() {
8098
for (Package.Areas area : Package.Areas.values()) {
8199
observerArea.addItem(area.toString());
82100
}
83101
}
84102

103+
/**
104+
* Perform code generation using input data
105+
*/
85106
private void onOK() {
86107
if (!validator.validate(project)) {
87108
return;
@@ -126,6 +147,7 @@ public String getObserverModule() {
126147
return this.observerModule.getSelectedItem().toString();
127148
}
128149

150+
@SuppressWarnings("checkstyle:AbbreviationAsWordInName")
129151
private void createUIComponents() {
130152
List<String> allModulesList = ModuleIndex.getInstance(project).getEditableModuleNames();
131153

0 commit comments

Comments
 (0)