Added test coverage for the layout update handle

Vitaliy Boyko · Vitaliy Boyko · commit 3ee3d5433927 · 2020-05-11T15:03:06.000+03:00
diff --git a/testData/completion/xml/LayoutUpdateHandleCompletionRegistrar/updateHandleMustHaveCompletion/test_test_test.xml b/testData/completion/xml/LayoutUpdateHandleCompletionRegistrar/updateHandleMustHaveCompletion/test_test_test.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0"?>
+
+<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
+    <update handle="test_index<caret>" />
+</page>
diff --git a/testData/project/magento2/vendor/magento/module-catalog/view/frontend/layout/test_index_index2.xml b/testData/project/magento2/vendor/magento/module-catalog/view/frontend/layout/test_index_index2.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0"?>
+
+<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
+    <body>
+    </body>
+</page>
diff --git a/testData/reference/xml/LayoutUpdateHandleReferenceRegistrar/layoutUpdateHandleMustHaveReference/test_test_test.xml b/testData/reference/xml/LayoutUpdateHandleReferenceRegistrar/layoutUpdateHandleMustHaveReference/test_test_test.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0"?>
+
+<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
+    <update handle="test_index_index<caret>" />
+</page>
diff --git a/tests/com/magento/idea/magento2plugin/completion/xml/LayoutUpdateHandleCompletionRegistrarTest.java b/tests/com/magento/idea/magento2plugin/completion/xml/LayoutUpdateHandleCompletionRegistrarTest.java
@@ -0,0 +1,24 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+package com.magento.idea.magento2plugin.completion.xml;
+
+public class LayoutUpdateHandleCompletionRegistrarTest extends CompletionXmlFixtureTestCase {
+
+    /**
+     * The `handle` attribute of the `update` tag in the layout XML must
+     * have completion based on layout index.
+     */
+    public void testUpdateHandleMustHaveCompletion() {
+        final String filePath = this.getFixturePath("test_test_test.xml");
+        myFixture.configureByFile(filePath);
+
+        assertCompletionContains(
+                filePath,
+                "test_index_index",
+                "test_index_index2"
+        );
+    }
+}
diff --git a/tests/com/magento/idea/magento2plugin/reference/xml/LayoutUpdateHandleReferenceRegistrarTest.java b/tests/com/magento/idea/magento2plugin/reference/xml/LayoutUpdateHandleReferenceRegistrarTest.java
@@ -0,0 +1,22 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+package com.magento.idea.magento2plugin.reference.xml;
+
+public class LayoutUpdateHandleReferenceRegistrarTest extends ReferenceXmlFixtureTestCase {
+
+    /**
+     * The `handle` attribute of the `update` tag in the layout XML must
+     * have reference to the layout.
+     */
+    public void testLayoutUpdateHandleMustHaveReference() {
+        final String filePath = this.getFixturePath("test_test_test.xml");
+        myFixture.configureByFile(filePath);
+
+        assertHasReferenceToFile(
+                "magento/module-catalog/view/frontend/layout/test_index_index.xml"
+        );
+    }
+}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,6 @@ @@
 +<?xml version="1.0"?>
++
 +<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
 +    <body>
 +    </body>
 +</page>